From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760344AbdCVRJL (ORCPT ); Wed, 22 Mar 2017 13:09:11 -0400 Received: from mail-sn1nam02on0053.outbound.protection.outlook.com ([104.47.36.53]:38688 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759852AbdCVRIy (ORCPT ); Wed, 22 Mar 2017 13:08:54 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=fail action=none header.from=nxp.com; From: Leonard Crestez To: Mark Brown , Liam Girdwood , Viresh Kumar , "Rafael J. Wysocki" , Shawn Guo , Sascha Hauer CC: Leonard Crestez , Robin Gong , Anson Huang , Irina Tirdea , Rob Herring , Mark Rutland , Fabio Estevam , Octavian Purdila , , , , Subject: [RFC 5/8] regulator: anatop: fix min dropout for bypass mode Date: Wed, 22 Mar 2017 18:53:07 +0200 Message-ID: X-Mailer: git-send-email 2.7.4 In-Reply-To: References: X-EOPAttributedMessage: 0 X-Matching-Connectors: 131346752256040389;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(336005)(39850400002)(39400400002)(39410400002)(39840400002)(39860400002)(39450400003)(39380400002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(9170700003)(8676002)(50226002)(50986999)(4326008)(6666003)(86362001)(106466001)(39060400002)(53936002)(76176999)(77096006)(7416002)(36756003)(8656002)(305945005)(2950100002)(5660300001)(81166006)(2906002)(8936002)(54906002)(48376002)(85426001)(105606002)(189998001)(118296001)(38730400002)(33646002)(5003940100001)(47776003)(104016004)(50466002)(356003);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR03MB2800;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:ovrnspm;A:1;MX:1;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD028;1:Eo2ShQ5xxc3XiJ7XqPvpdpVF+aaZ335eEVfdPXv5z8lXic0X1tsa+s+MoylyUEio40PEPh6zOxliLqqn91tZEZM/vZEkHmupCHeB2OKo6cRz3FSMqBvsgZk+yYgXXaj1wxqvT/xfqBUNj96vO6UeNdTetIvyvSk1jBiCxdYPkQYo2qVdpMRDCfEauXDxrJfjPhsTJFuXc5vOsjIa6jdpHnv7AF/ZJVQxD1IcA90NnBhTAJy7EZIL6hViVGoSqg8vri81Zpysf6iMAd4Im7Ie5j7FEzWwdX7lf1nk0ycR9edYOvvn8BBeKiuRfqPQNWurIOmJyApkv9n7LHWfH6Iyf99Q2gJuZ1c5Cj3ts3J9fR75lt3Fn5mTbWZv+ZsDZRQ8LJbeAd95UDPLYsl/vrPAQfG1m7bi895uIcO8VMusq3KZ+/Z6EzQp34f4u+mDeixeWYhIfQi6DXzVlXEMPPlGHN0l3u299jtKjP5qSdTE+viAxrzbNQiMrYj6PEbFlF1/bmEDBVykP5IBnfh9kYvcyzV/KsQp+EPUc6Ia+Muwej37qrNiIaA0n1IWor2NACWlmjsKMs4MpKs8V7HbWaO4On1MqaXaYF+kJsjkC9B+TxHEgKzkANCVoQkTqhhi1Tmo MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 3d45aed4-99ae-4e30-fc64-08d471440113 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR03MB2800; X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2800;3:GAkY3aj1usthqxt5l02oCatRmCl63gGnRHCyIOhWDlLULuuWZZfKt8AvB9NUp+XuKOE1ZaWlGf0PuI0puUx8EbR7FPDtzyWjTitloE1AAtdYYYG42JoNet8+iZCeqHgKQtWwJrHqBWfrimPt5lBnGxyyxJSyfpYDaYQwRwfdNAeDB4HrdBW9RbJ8ETphPeSTGklt56i8KmemkIFo6jSf037j1JLX7fBRn3+Ft+XujkgkGZR7V5MldP2b/CxHs5nd9/wrALiZDdxrYuXsir8OHTeWtYQukIek6ToIHPSpnAkEtilch4qkUb7SAfvJrYLkc5Ja5FWm39nKxol0d8txkoCjfVQ59Hyd7pIpkRmFVbZBQDXSxKHjetzbLJusYOiR;25:4t7ahuVuhIwxILHo2keaKt00f+wVMjuGVnEXRcNJ/gaKnwuuemFK8CopIqoeQ3HOBCUuYVo2KXNltPOduo66Jg+kt18qJXJKl+HaC0jxlyrGBTJudhAV+o8evR/2z+2UBDeSQ8X7NoyL866WVAVbFDDsz30f1pkfEaVJHmyB3a23xxPKbESAEUslovaF5A4lDZq2A/5+78czH/FitF+apCcHV3LuPRZhJvVMRzc8uQWPHKF9WXRbZL1ZbHPupaVvfVstXKM6P65AXJD3gr7V66EDvzf75ReThid5hbrT8fJt3r9szRTSCLl+hKSWmsqxx600VbRq/pbJW14X5FKgt44I7MJ5J6SDase04hzG8g5gS8NCx3+57uNrmbf7Ce2EPXhU0KikPD694BsFTLjxue6HcpVncwQGv4pO2+ai+/k12UU6hnLh+AvuAeBVEm4kfWE7sN4kKA4MOGwZh+defQ== X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2800;31:CN+LJvVHmWVZx92VOOqO55dJ1KIVm4PcaksE0hY/diJUK03yGixg8Sqpb69hKl1Tjr1cJvhBrGXS+zL7DSYF8Q1arsTA8USsNOtqnNquZLSnHXbPH40ZqV52M/EGcGA39JSzKrPYGumSKf4SkDT7IQwgO+8Qwh9V226SpIWGpqpHkxZQIqsRXBJw7rYcgkPxnnkMiYlNOGzhrQnIZ4j2cAkOE8BVcPK1ychCJ9IMYlH5SWtn50sU8QYjIc850yMRzFx8f6g+xp11qe15Q+YwOovBRJgPmKNvGXTAeogd+sM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6095060)(601004)(2401047)(13018025)(5005006)(13017025)(13015025)(8121501046)(13023025)(13024025)(10201501046)(3002001)(6055026)(6096035)(20161123561025)(20161123565025)(20161123559025)(20161123563025)(20161123556025);SRVR:MWHPR03MB2800;BCL:0;PCL:0;RULEID:(400006);SRVR:MWHPR03MB2800; X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2800;4:6pRhm1iQaorPkfGP+ZeZs8aKG+G7FiWQuyfGKKcN7hvAHPHagK+7LZhTKuSehjeZH4kfowW7/4p8G9k9RYM/qpxmXRRn51LiMMhzpuMW/rPLJ3rq5pCEl29nOvDJzIxPUaSZV8UvKLlxipxZp95KYunz+j7CjuzHdIpmDAO514jOnQGf2q/VzGf1gvHnVJCsLS7z6OhmSDGyqG/wVn6j5v8MLRlM0OSsR1AGETWgRTJm/I3HiahqGtKFOup5M9i22uZk8oAdeJLilz5kQqwTTTzyzVcCJWSXG8zPJaWN4bIcqH2m/fvvt5H+LqsF0QAzrSW8i8r2F7vHvxeToMEFSg26ql+GHkK1OTWRP6FPtGm3b6zEiVS/KP75DfYYHypnH/CHpvJWNs11zWCdfJpN1ZBh+VivUYq6UF8h2hh6ViFUuzmi7Y35gV4VBQXpUV4LJa5Qsh38rIfSiLxG5cYfZK1Nt4QxivdjkIsFs/LXOYCEQ/Allc1A1cVpwKk5KbLA2Hkuhh7IxZVY6XsMtzpl4HRNj28G26N8XB6NofV6zX9MoNq4OtH9qg0qXr241esntHbuLkM0b8WPmSk3xp1fkPSte9aP4LUt0Sk9Ac6ogbRKKsv+zGiQhpmzj3SlRQXnyruAHevdscXeO5rYE8SkRJEwpO4KfHuK4MxLHo03m2ZWOYp48SYxe4E5/4LXbro2/DKA9tcFE8ZLk3U4SCpaDVJ/iQ9dDVTBAcukVbqBudpxBdTPpGxY7RgYsZodHkMJ X-Forefront-PRVS: 02543CD7CD X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR03MB2800;23:YCoP10EBPBKVgOF1ftoof18M2Xo0b6EYv8UXVa7gP?= =?us-ascii?Q?pmWnu6QSKQFpq3I3IKdAfZyTxY32Xe+YtXW1ZOXs+H69cpwp94ReGW/L2yOY?= =?us-ascii?Q?/sptn1sp+qplqsT3jSvNCz73WZWGz4yY3hXyEwRevDKtGUFBjDM6zHbGzOuL?= =?us-ascii?Q?pGjDUJXzr6/YXtRghMWjrpNkxChZXOJCBBEjo3hiMQgBhbJqw1UfMYqkvkgE?= =?us-ascii?Q?GEs1RCVg5Lm+DzUsk22jPXkhjFzJq5kmAVubvuEHdWMldM6PDHq2QfMerNAI?= =?us-ascii?Q?fa2NcCzB9Dk5jP0QB5q+rnTgIbw+/ExbadcQizTCLRpc9bIY2wBNDm0Llu1N?= =?us-ascii?Q?n0ZugSwC501xaLy7uvKfGyQ4Np91l3pss/B78l0IsXnUf2AmGPSMCl4awLit?= =?us-ascii?Q?v6wHqgZwz2oB8Shfc1jtaAGNhdZFE4vTS9UeWmSfxXRMFZLZKzeJXmQOuYwe?= =?us-ascii?Q?GHnG+AznatbvVppfAxszs89WtrMftjxEubLKU74eEEB8NPqyWDlY8Uzbz2Ne?= =?us-ascii?Q?w4bStYuCgZa2M5PB7tJJJJgT3jAfp/v/aKBYWs2JQhsKjrU43bsZoHXOp0ry?= =?us-ascii?Q?qdlaxNcVMl2THeeftlXPrrTPzH8nZXHLP0hP6+J7RNPMu4BTgrLWd/Vh9qbu?= =?us-ascii?Q?pYpLPygKPzO5h2su32Cc1MRSq+tYPIKGIikGRRVUSs3VebK9+UGm9imvdwUE?= =?us-ascii?Q?o6GGz3hSTQuRdpYmlW66e+94RjibwXikzhlkFn6jKPGhA63S7bvUNMBjUvpc?= =?us-ascii?Q?VTFFglock5518XT6fEnGl+MX8tXIxfBdAUfeUZ341G1JmhSkEDoAYAIbdWrn?= =?us-ascii?Q?O3iqM5QaznVNNsCV+uKu4vC98yoTR47ERDw2vDRVNCieO0EMglqNiqYqM/Qs?= =?us-ascii?Q?yS1/MPhGT0s9L9I8bhhkkfVAFa4W6WTRHKKaasertY26GVDCuwMkJ0aiO8/c?= =?us-ascii?Q?CnlU0H/jkPBK8PKVJn4+gD100g9qUVEkCSzDiOa+D9JkSSj0+Ai9o/oqAYpT?= =?us-ascii?Q?e3b2QQslvMLeaDhqCm7R5hZBLHcr8y/pvI1VBTNh5+WQI4CIqmbyFCCr63ey?= =?us-ascii?Q?Bj0WFHMtXUcBI0r+NT7C4AF3yy5WaYevUd46AAXcgGLuxIRUmkI/xxNH4SHp?= =?us-ascii?Q?qQy3DVwxkDxLSttYEM7zYBTTEvEfBnrGS3/XfIYsqYWSadD03LNsmK1I1NUn?= =?us-ascii?Q?IvcVjipOlLLrANYF5E14+Ph/gGs+9fmUA7CZuQTXiIe+GFR7+eV/zB5pw=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2800;6:6dZ+UG11Sps0MEFMPvt2ps+OVmUS3Bu9Xpb+XH/OdusXZ60FT1O2o5PAENC8GmUbh3ywP0SsEGpAoZmfCXV0u28I+5K9opCeW4RvFbOpDPa/zuRsvfgSxv1KgvJMf1VoFvfflhSi4+wnbosdxF0BnmOjvQzFCPb7a/e8O9WIV5Oom902cQqE0TWjuXtoTVn6bI+UV9tOhWcv20HWToe6TczlU9W2uoXjn8TLvVyJWQ8Hl4sFVOw+r4h6Sh0DowYlnpJg+X1/YffhfSlWJF0tlROfUWYth9z8eYdLF473OODu8gPxjhJlZ63Tcrx0WZduT5g+Bhx6neujm1x7Qf+v6Arr0fmSM3NL2JQfjD9mJ78UowZqbRUbDm5tOpPdNMZnAm0BhNgMhRKSMg4bZhci2IpiV8nMxvn83gXg7gYu5h0=;5:BIG3lNKc/OgBGrivM7lf3AYaWwq8arKKOVOfW1N2Yvu3/ECOPIAEOsFcO2wlSd6WeVfTMi8VO7OmWABPhH8YK3SrgNa0W/Ne51xRHBGkcYHLs2usTye4tCt8H7N9ul5JWkKNL8vKtJgAuAvdkvpLw73EL1tzJpryOTuC26d3+ZUn5k9dwmcq1VU41ofAOO8B;24:nDXlqEFbTAuv1mWtg1gr/0h4vdDE+fxfm4LmMOR9sAsVxB+Vl7EUo4ma/h8JWiYu3nu4Dse3muFwrT8NzK2iXxo2nWJZPDr7MREemFYhKzY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR03MB2800;7:nGFRUBnIO0D597eC/7RDggWKJtOgfFm0AyUgrmj5P3RgQRzsrPuoPQIF7Oupo6koU/a4GULFiHQ+L+KXFiQ0b0AVTM5tmbeTUcBJevwY/M2PSIOi0iwLYbo44Kd5dKMhR+smj9gNTsg5K9xis3Z11b9zLW6b/RTJy219qXaRXcGs3GFLSopEUQiZPOHvdQK3wC6KUeVllfY6RVOdRBQMOJTMqCkfJbdzSDBynp22NXZzWA98uHZF50XA8MehVcNVdduGJu6J80qtQfPfwz25AmZ7jnZ1R+e+qxlkLxzpU3MWBrnV+Zt2G2CHZ8aV6j2IelQS9ZDbbeoiRh1dPCEVCg== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2017 16:53:45.3700 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2800 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Irina Tirdea In bypass mode, the anatop digital regulators do not have any minimum dropout value (the input voltage is equal to the output voltage according to documentation). Having a min dropout value of 125mV will lead to an increased voltage for PMIC supplies. Only set minimum dropout value for ldo enabled mode. Signed-off-by: Irina Tirdea Signed-off-by: Leonard Crestez --- drivers/regulator/anatop-regulator.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/anatop-regulator.c b/drivers/regulator/anatop-regulator.c index b041f27..64554e8 100644 --- a/drivers/regulator/anatop-regulator.c +++ b/drivers/regulator/anatop-regulator.c @@ -38,6 +38,8 @@ #define LDO_POWER_GATE 0x00 #define LDO_FET_FULL_ON 0x1f +#define LDO_MIN_DROPOUT_UV 125000 + struct anatop_regulator { const char *name; u32 control_reg; @@ -153,6 +155,10 @@ static int anatop_regmap_set_bypass(struct regulator_dev *reg, bool enable) sel = enable ? LDO_FET_FULL_ON : anatop_reg->sel; anatop_reg->bypass = enable; + if (anatop_reg->bypass) + anatop_reg->rdesc.min_dropout_uV = 0; + else + anatop_reg->rdesc.min_dropout_uV = LDO_MIN_DROPOUT_UV; return regulator_set_voltage_sel_regmap(reg, sel); } @@ -264,7 +270,7 @@ static int anatop_regulator_probe(struct platform_device *pdev) rdesc->vsel_reg = sreg->control_reg; rdesc->vsel_mask = ((1 << sreg->vol_bit_width) - 1) << sreg->vol_bit_shift; - rdesc->min_dropout_uV = 125000; + rdesc->min_dropout_uV = LDO_MIN_DROPOUT_UV; config.dev = &pdev->dev; config.init_data = initdata; @@ -286,6 +292,7 @@ static int anatop_regulator_probe(struct platform_device *pdev) if (sreg->sel == LDO_FET_FULL_ON) { sreg->sel = 0; sreg->bypass = true; + rdesc->min_dropout_uV = 0; } /* -- 2.7.4