From: Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>
To: <leoli@freescale.com>, <balbi@ti.com>, <michal.simek@xilinx.c>
Cc: <linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-usb@vger.kernel.org>,
Punnaiah Choudary Kalluri <punnaia@xilinx.com>
Subject: [RFC PATCH 0/2] usb: Reuse fsl driver code for synopsys usb controller
Date: Sun, 20 Apr 2014 21:53:27 +0530 [thread overview]
Message-ID: <cd97cc6f-7944-4aac-963a-0dedc7bed938@CH1EHSMHS032.ehs.local> (raw)
Zynq soc contains a dual role usb controller and this IP is from synopsys. We
observed that there is driver available for this controller from freescale and
decided to reuse this driver for zynq use.
Here is the link for zynq soc TRM. Please refer chapter 15 for usb controller
related information.
http://www.xilinx.com/support/documentation/user_guides/ug585-Zynq-7000-TRM.pdf
The following series of patches add initial support for zynq soc in fsl gadget controller
driver and fsl host controller driver.
Based on these patches, I have the following concerns and sugesstions
Since the freescale usb driver is for synopsys IP, Please consider rebranding
this driver name and config options to reflect that it is a sysnopsys IP. So
that other vendors who using this IP can reuse thie driver.
Also the ehci-fsl.c is for powerpc based soc's, and zynq is ARM based, i have
protected the code which is specifc to freescale with CONFIG_FSL_SOC. Please
suggest if there is a better way of doing this?
Punnaiah Choudary Kalluri (2):
usb: gadget: fsl_udc: Add support for zynq usb device controller
usb: ehci-fsl: Add support for zynq usb host controller
drivers/usb/gadget/Kconfig | 2 +-
drivers/usb/gadget/Makefile | 1 +
drivers/usb/gadget/fsl_mxc_udc.c | 21 ++++++++++++
drivers/usb/gadget/fsl_udc_core.c | 5 +++
drivers/usb/gadget/fsl_usb2_udc.h | 2 +-
drivers/usb/host/Kconfig | 2 +-
drivers/usb/host/ehci-fsl.c | 63 ++++++++++++++++++++++++++++++++++++-
drivers/usb/host/fsl-mph-dr-of.c | 9 +++++
8 files changed, 101 insertions(+), 4 deletions(-)
--
1.7.4
next reply other threads:[~2014-04-20 16:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-20 16:23 Punnaiah Choudary Kalluri [this message]
2014-04-20 16:27 Punnaiah Choudary Kalluri
2014-04-20 16:58 ` Greg KH
2014-04-20 17:56 ` Alan Stern
2014-04-20 18:52 ` Marc Kleine-Budde
2014-04-21 4:53 ` punnaiah choudary kalluri
2014-04-21 15:18 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd97cc6f-7944-4aac-963a-0dedc7bed938@CH1EHSMHS032.ehs.local \
--to=punnaiah.choudary.kalluri@xilinx.com \
--cc=balbi@ti.com \
--cc=leoli@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=michal.simek@xilinx.c \
--cc=punnaia@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®