From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20A7122B584 for ; Wed, 17 Sep 2025 10:22:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758104543; cv=none; b=JtF61guMCEzIip544eg264zNrlwIPDUqJoHW6KLBPcHLU4vFBdkUQHMAZ+hajI57j0SRr/H9DBPywETbMRWQQsfj3oTieQCHSpYKB8AtkrDQFAxVMK/YuYhzOrdSxfKgfwZ6Bg2pFn/ukIG7fpGfN8I60y8Guktjb94STEF52rg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1758104543; c=relaxed/simple; bh=12hYLPGSZe3mYZaPruoDOS1ERatKxSIVgmghftcEuKI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kcDnjTuvkZ7Ij1nio/QJ/GfNR21tn8PcrtdK0srUrlxc9D20dfByGm7RhdwJJp5RHjgDN/l5vnawLApsjVr5Hx2Hj/kyelLUiCbv3i1N+jKXO+e9PhR/jizyGd+n9mfSc9hTk2RAdUjHmIuA+YVlylOR/p+qDTn//lixBUqN4so= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZMzL6mfk; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZMzL6mfk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758104541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mKyszV1q06Fp6TRfybx7eNtO4VCdcm3YS1IzQgwBUT4=; b=ZMzL6mfkrHmLoUibbiznuyddUlhAZ+I9R0pcZB+af6X3xUo1sgx0Pxuzn62xNpcd665q2j fqwyy7XngTT7Enhq2lvjQSNwLUiU31JcWcHgrq6IFenVpJ9k9t/WD78RUbjB+a9sQGa5V6 /8Pz6ux3PJQm3AAA3uAwBXjszFRZfNc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-108-PQnfsdP7MgCzDx1qmdIUAQ-1; Wed, 17 Sep 2025 06:22:19 -0400 X-MC-Unique: PQnfsdP7MgCzDx1qmdIUAQ-1 X-Mimecast-MFC-AGG-ID: PQnfsdP7MgCzDx1qmdIUAQ_1758104539 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45f2a1660fcso31667645e9.1 for ; Wed, 17 Sep 2025 03:22:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758104538; x=1758709338; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mKyszV1q06Fp6TRfybx7eNtO4VCdcm3YS1IzQgwBUT4=; b=XHedRH+b7XxB4jp6CMWAGOdhUNEocWA5QZgfjMcdmQHZm3nKIjtdHua0R1b82wYFvY STTjZ+dYrI8SzpArOZJTsBEdByo7d8QS/IGr8Uwew4W0NbX9xoqevo7IvFeEuQRU02/T ChyZ5acsEqtcC9YFCQg24TR/aCzDnTYkmhAs/HxPIa+S6C9tmvbV0ZshImaojj6fxuK6 Wl+fkQ9Tks+d799hw1UaBBP7lDQZ7RH4kChRWpR1EMXmp9KFLApwAhKTZ/zcQxjeeMDe TQXniS1n1ZOpAl/k/Uwdf4YkMwMBd+Or1trJQm52vSBp7qgh6z0xm0qtNoSWcza5XMVT TIoQ== X-Forwarded-Encrypted: i=1; AJvYcCU72S30Ihwwq+0gTr9HLmw7TBm4Jmyd9nKkqm0cNLOT02Px9t0TlAb08EuwYQxDqWkuF9ODmFsQKx4i+Jk=@vger.kernel.org X-Gm-Message-State: AOJu0YzSHN1/AZKuYeCQ7K+A3zq5950VmvBde8OEllylfzJ04raemgTl oOaat0HKrYp1rjAY0yHSuPXT+lxMrPc1jyi9THX+QSCouJbX+4SrDuHoN9CBJ04D0s3tXHL6qcX bbkSbxMyGkbHPPe7L6HGu5/5WPUHFTsOdb4Pb6Eks1hHFHv1MfpNP6/TUFCHTxDQkiQ== X-Gm-Gg: ASbGncvzwTUj/S8TarN+Kkkn16/83RupXeZWZDIShsCa82klphicc4D3nMtc06AEccl ldm+sqNRtRZEX94q/DRrxMNtofZKE8Y7G57V8vhK3X2x3UAmdtX9skGucdz3dZI1N20xAX+8so4 i6eElIEeGD3wqw+irs/g5WveoHBBqK8OJhJ67Mq/NPKym9eZsAcQdmc1wrrNkzURafTTH8fhjUa 8LsLPTK/ShkKNOeXUajK20mw1g20SZ9yCxA1iqoxN8udSb53IOX8OFUaNKp5ZdkuBeLkyaLHAv1 ga80h11E86QM9Waq1kr1RiZUAWcXJGNfGxrR22IDiYW8fHJfIrePGudH2cvNbrKMLnVZXyPpZ6L tm+8ybQAYotUfXq19kH5bfhkpPPDToZ3k8JWOswkomt7m4MpMeahee3xkHAYhDcm3 X-Received: by 2002:a05:600c:3b20:b0:45d:e110:e673 with SMTP id 5b1f17b1804b1-46202175527mr14813525e9.4.1758104538529; Wed, 17 Sep 2025 03:22:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHo6HbjqyIn3oQJnoxmTmcqeb7EBkzpfCOw15hL8v6Me3R6DzuZDAIwQ1WGLFWW9sjTfM1yRQ== X-Received: by 2002:a05:600c:3b20:b0:45d:e110:e673 with SMTP id 5b1f17b1804b1-46202175527mr14813245e9.4.1758104538056; Wed, 17 Sep 2025 03:22:18 -0700 (PDT) Received: from ?IPV6:2003:d8:2f27:6d00:7b96:afc9:83d0:5bd? (p200300d82f276d007b96afc983d005bd.dip0.t-ipconnect.de. [2003:d8:2f27:6d00:7b96:afc9:83d0:5bd]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4613930bdd8sm31088005e9.19.2025.09.17.03.22.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Sep 2025 03:22:17 -0700 (PDT) Message-ID: Date: Wed, 17 Sep 2025 12:22:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v5 02/15] mm/huge_memory: add device-private THP support to PMD operations To: Balbir Singh , linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: damon@lists.linux.dev, dri-devel@lists.freedesktop.org, Andrew Morton , Zi Yan , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Oscar Salvador , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , Ralph Campbell , =?UTF-8?Q?Mika_Penttil=C3=A4?= , Matthew Brost , Francois Dugast References: <20250908000448.180088-1-balbirs@nvidia.com> <20250908000448.180088-3-balbirs@nvidia.com> <17e3c19e-0719-4643-8db8-cf8c5b5aa022@redhat.com> <49776f0a-d891-40be-bce3-c2b1f16bd825@nvidia.com> <4de00290-7c29-42f5-b8aa-58a77b17c1d5@redhat.com> <8a2c4803-d613-4592-9114-d68b97bf3fb0@nvidia.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <8a2c4803-d613-4592-9114-d68b97bf3fb0@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit >>>> >>>> Couldn't we do here >>>> >>>> if (!pmd_present(pmdval)) >>>>      goto nomap; >>>> >>>> To replace the original pmd_none() .. check. >>>> >>>> A page table must always be present IIRC. >>>> >>> >>> I am not sure about the pmd_none(), a page table may not be present, I've not audited >>> the callers. But I think we can do >> >> IIRC page tables must always have the present bit set. So we can just simplify to the single pmd_present() check. >> > > Not sure about that one, are you happy if we follow it up later with a separate fix Taking a look at other page table walkers, they couldn't possibly work if tables would not be pmd_present(). E.g., walk_pmd_range() in mm/pagewalk.c has if (walk->vma) split_huge_pmd(walk->vma, pmd, addr); else if (pmd_leaf(*pmd) || !pmd_present(*pmd)) continue; /* Nothing to do. */ err = walk_pte_range(pmd, addr, next, walk); if (err) break; If a PTE table would not be pmd_present() we would never ever call walk_pte_range(). So I am pretty sure that this can just be: diff --git a/mm/pgtable-generic.c b/mm/pgtable-generic.c index 567e2d084071e..1916d22aaf1f1 100644 --- a/mm/pgtable-generic.c +++ b/mm/pgtable-generic.c @@ -290,7 +290,7 @@ pte_t *___pte_offset_map(pmd_t *pmd, unsigned long addr, pmd_t *pmdvalp) if (pmdvalp) *pmdvalp = pmdval; - if (unlikely(pmd_none(pmdval) || is_pmd_migration_entry(pmdval))) + if (unlikely(!pmd_present(pmdval))) goto nomap; if (unlikely(pmd_trans_huge(pmdval))) goto nomap; Unless I am missing something important :) -- Cheers David / dhildenb