From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34543C77B72 for ; Mon, 17 Apr 2023 22:50:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229842AbjDQWuF (ORCPT ); Mon, 17 Apr 2023 18:50:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229762AbjDQWuC (ORCPT ); Mon, 17 Apr 2023 18:50:02 -0400 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0ED4446A8; Mon, 17 Apr 2023 15:50:01 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id BFAB83200949; Mon, 17 Apr 2023 18:49:57 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Mon, 17 Apr 2023 18:49:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1681771797; x=1681858197; bh=Uv 1oc3npXKlB1WxLwiqApxeyeE+yNkaEVZoDDF0LLXU=; b=GYe9tZQN8GYHgiPkdP lWkvIiTgewMK5ToHiirxxofpi7Bs4mgEVppU//lBKkyYpZv6Rz3+A7GCpOB5J0zN S7bUtjxBmVTH6x3SCRXwY0u4WW7Vv6H8BGP9ZxlJpkeZmm4i+KlgKAZ10KBjfqq5 F7ujmKZ0b/LO9RSgpWaUNq8AcpMBCYYau/cBay+/6NeCkpJlRRHQ4X7i7f/4gk+9 HEwDOQE9NfuhPPHm85fliEdpvGKouapsPqeMhw85VnCADuYZwub+b92W/L2TFo1U Lw2WVHE/2lJPhepvLmMj4sPoJmEIWQhVz7aSDcgfQu0iMssxoURRz9lJURU9tDkY XPxQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1681771797; x=1681858197; bh=Uv1oc3npXKlB1 WxLwiqApxeyeE+yNkaEVZoDDF0LLXU=; b=YpZYZm1mNPrHbxzvS2jV71YKVaRZl wwho1zUDeGuUVGoVnsKR1vt6dFjOhfcDOiFn5+h7chKrWys/nBNDHjmyLh0QwH7Y Zr4aIIirvK9OWVsK9Ivkl0QGMgt/TmU57CKgul8fpKir+9+0wyew9i05nkvZXXvl ZFazSGAiphEQqlwMWoceWk7UK13gGHrGBQhIaM3P6oJbIHOCEqY7m4YeMNAqrX17 /axg4hehsxLAhRBOon+bc8q2UwLejAltCxNHfZY5QhdEcjifALV6thqtCG5xRs4H 9neqIYAFnv5NFo9LJM1J7ntnwgNZkCY0t5eZkgkEk9l9jHFmRU3/5nlfA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeljedgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 0EA74B60086; Mon, 17 Apr 2023 18:49:56 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-372-g43825cb665-fm-20230411.003-g43825cb6 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20230417220254.3215576-1-arnd@kernel.org> <20230417220254.3215576-2-arnd@kernel.org> Date: Tue, 18 Apr 2023 00:49:29 +0200 From: "Arnd Bergmann" To: "Luis Chamberlain" , "Arnd Bergmann" , "Linus Torvalds" Cc: "Aaron Tomlin" , "Christophe Leroy" , "Viktor Malik" , "Jason Baron" , "Song Liu" , "Jim Cromie" , "Kees Cook" , "Masahiro Yamada" , "Sami Tolvanen" , linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] module: fix building stats for 32-bit targets Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 18, 2023, at 00:15, Luis Chamberlain wrote: > On Tue, Apr 18, 2023 at 12:02:47AM +0200, Arnd Bergmann wrote: >> I have no idea if there is a risk of these variables actually >> overflowing 'long' on 32-bit machines. If they provably can't, it >> would be better to do the opposite patch. > > I had originally used atomic64_t and added a debugfs knob for it but > Linus had advised against it because its not a stat we care too much > on 32-bit and atomic64 is nasty on 32-bit [0]. > > So I went with atomic_long and the cast becuase we're just reading. > > Is there a way to fix this without doing the fully jump? If not oh well. I've sent a v2 now that does it the other way round, which is clearly much more efficient. Have only done minimal build testing so far, but it passes the randconfigs that failed before. Arnd