From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender6-op-o11.zoho.com (sender6-op-o11.zoho.com [165.173.180.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2847741D635 for ; Sun, 11 Oct 2026 22:04:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=165.173.180.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791756271; cv=pass; b=La/hLzyRwtmk0tO9+FTzWiEl0/V0etbdr2YL/U2I0uxisLb/6TFQNuGOfAcgKamdgoiKkKbdOT7XlygnYwetGmx6isE027TAfHH1L97j3yp1DzkcSpH6lwM8HttdugomROMHw4QU36pNMKX0k3BdQ1TaQE4gdM6+PiLoSxRmXF4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791756271; c=relaxed/simple; bh=7UPp9ElkGnZalsMH/5actDI6CxXZr0lhP963YES1Dqs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Zl6TmLQz12T7N8woei5Ovsev+GuI7Kh2sRbgFYCRJYXLE/gnvhoKrt1DsbQ0B5tnn+G6wymK9ycUOZFFFnvggvF/cS12RGGOGBQcHO4WQBsGYe2CCL5UzY8VcYbL7Uk5V/mw4ODOnpn3I6SXTOse4s+TRYUvCtvf+ZwNDfNkHeA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=dmitry.osipenko@collabora.com header.b=ivhPQ/0N; arc=pass smtp.client-ip=165.173.180.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=dmitry.osipenko@collabora.com header.b="ivhPQ/0N" ARC-Seal: i=1; a=rsa-sha256; t=1791756245; cv=none; d=zohomail.com; s=zohoarc; b=XBGn0EDiYLl2ayemR909LBeoVeG4BdqbgPbug6BE2YDLi4qdojAkJjOVsECwylTRN8bgJKbIj1IZix1be3boaFrCyffPZvxyZrcHif4cofQVryIe/SVV2pMk5MYf3Xau6FxiLGh+yb211yqLCwyx1isZrFO+yaF020a84blHPJc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791756245; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=nCzvftucFk6WSAIfrGo74dUEjckzzf0Uo1ODZeMVfTo=; b=YgTA7zWhjYvHNFjzFGXCFMih5yaH5SMU9/n/N4ZDvM1aacmOLwyUg77tdZWIjrvPOkDvSXJHXh4+VezUld0gS3mz90WBSnE4F3ya3Nsg7it0Z9L1PiXbESSMyM1Wmt/NaoW3Y4Nc60oKHufw5Y6R7gk+frzZ4T+OhnHA61ZofZk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1791756245; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=nCzvftucFk6WSAIfrGo74dUEjckzzf0Uo1ODZeMVfTo=; b=ivhPQ/0N5acPf1VXsyY1WmGHwLXFfthSlusOrjJzvFQIyJqkf9z/cLlkACyPsapR tz1f6OmP6GQ0VYTMR1X28PXbR8gdIwgFagIq3j4fbXfDcki846JFZuS5pQDG1Pv86LB iSk+0r5u4dTG72UuNQLaaQXE33VwJmKir8n7Tg4c= Received: by smtp.zohomail.com with SMTPS id 1791756244116211.11807230278964; Sun, 11 Oct 2026 15:04:04 -0700 (PDT) Message-ID: Date: Mon, 12 Oct 2026 01:04:00 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] Revert "drm/virtio: Add pixel blend mode property to cursor plane" To: Marek Szyprowski , David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu Cc: dri-devel@lists.freedesktop.org, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org References: <20261007222244.295186-1-dmitry.osipenko@collabora.com> <64f7ea95-516f-4b95-a42e-14fd606879f9@samsung.com> Content-Language: en-US From: Dmitry Osipenko In-Reply-To: <64f7ea95-516f-4b95-a42e-14fd606879f9@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 10/8/26 12:40, Marek Szyprowski wrote: > On 08.10.2026 11:35, Dmitry Osipenko wrote: >> On 10/8/26 01:22, Dmitry Osipenko wrote: >>> The cursor blending mode was added twice because the same change was >>> applied by accident from different patches. Revert the second patch. >>> >>> Reported-by: Marek Szyprowski >>> Link: https://lore.kernel.org/dri-devel/ce84d3d2-e78b-4939-aecf-9ef7267bd42a@samsung.com/ >>> Fixes: 6947b78df4d2 ("drm/virtio: Add pixel blend mode property to cursor plane") >>> Signed-off-by: Dmitry Osipenko >>> --- >>> drivers/gpu/drm/virtio/virtgpu_plane.c | 13 ------------- >>> 1 file changed, 13 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c >>> index b422eba42a5f..640815af4098 100644 >>> --- a/drivers/gpu/drm/virtio/virtgpu_plane.c >>> +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c >>> @@ -589,7 +589,6 @@ struct drm_plane *virtio_gpu_plane_init(struct virtio_gpu_device *vgdev, >>> struct drm_plane *plane; >>> const uint32_t *formats; >>> int nformats; >>> - int ret; >>> >>> if (type == DRM_PLANE_TYPE_CURSOR) { >>> formats = virtio_gpu_cursor_formats; >>> @@ -615,17 +614,5 @@ struct drm_plane *virtio_gpu_plane_init(struct virtio_gpu_device *vgdev, >>> drm_plane_create_blend_mode_property(plane, >>> BIT(DRM_MODE_BLEND_PREMULTI)); >>> >>> - if (type == DRM_PLANE_TYPE_CURSOR) { >>> - /* >>> - * The cursor plane exposes a format with an alpha channel, >>> - * which requires a blend mode property. The host blends >>> - * premultiplied alpha, matching the property's default. >>> - */ >>> - ret = drm_plane_create_blend_mode_property(plane, >>> - BIT(DRM_MODE_BLEND_PREMULTI)); >>> - if (ret) >>> - return ERR_PTR(ret); >>> - } >>> - >>> return plane; >>> } >> Marek, could you please give your r-b? > > Reviewed-by: Marek Szyprowski Thanks, applied to misc-fixes -- Best regards, Dmitry