From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752748AbdEJJTd (ORCPT ); Wed, 10 May 2017 05:19:33 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:43899 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752113AbdEJJTb (ORCPT ); Wed, 10 May 2017 05:19:31 -0400 Subject: Re: [PATCH] dm ioctl: make dm_open and dm_release release To: Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, Shaohua Li , linux-raid@vger.kernel.org References: <20170510091821.17995-1-colin.king@canonical.com> Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org From: Colin Ian King Message-ID: Date: Wed, 10 May 2017 10:19:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170510091821.17995-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/17 10:18, Colin King wrote: > From: Colin Ian King > > Making dm_open and dm_release static fixes the sparse warnings: > > warning: symbol 'dm_open' was not declared. Should it be static? > warning: symbol 'dm_release' was not declared. Should it be static? > > Fixes: ab2c6224f4c0c ("dm: a basic support for using the select or poll function") > Signed-off-by: Colin Ian King > --- > drivers/md/dm-ioctl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c > index 70dc5db90ef2..d45c68115d4c 100644 > --- a/drivers/md/dm-ioctl.c > +++ b/drivers/md/dm-ioctl.c > @@ -1893,7 +1893,7 @@ static long dm_compat_ctl_ioctl(struct file *file, uint command, ulong u) > #define dm_compat_ctl_ioctl NULL > #endif > > -int dm_open(struct inode *inode, struct file *filp) > +static int dm_open(struct inode *inode, struct file *filp) > { > int r; > struct dm_file *priv; > @@ -1911,7 +1911,7 @@ int dm_open(struct inode *inode, struct file *filp) > return 0; > } > > -int dm_release(struct inode *inode, struct file *filp) > +static int dm_release(struct inode *inode, struct file *filp) > { > kfree(filp->private_data); > return 0; > Sorry, ignore this, it had a mistake in the subject line