From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F8D82EC571 for ; Mon, 29 Jun 2026 13:51:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782741102; cv=none; b=PRbi3Kx3OTpUCpSdlOkND/h+6w6qkzPcb9K9GFuEAtS1Dy9banWOj8hBwqU/Y+W0bhFpT9urREsIWNgaKgpYehpNZXdO0U7/ytDnrIA+/WzFxwFusIy/SJ25OpagZUleN6ynjRSP7YJEEF08NW2/xZo3rGD8VJd4l6TFcz65BBk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782741102; c=relaxed/simple; bh=Anf9lqMzdcDn0HxQ9omAPbbmLofJntbIF/EOfhUsnEE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j67oYhzfbN6SGjr/0zUrwa9agrHpAhHiwS7DDQ7yxzt7YknNnJbKwhPMX/HxLyX+g2q2O4OZtj2W81L4SwVeFEgpRkuvNV0S6TMgHLfkfBxPC55aytUQ6L/v/u+rcGrgCV1Sk3xiSppAgDQQDK2NuTIgF1WaV8oiixgQYyumIZs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ufNlTX7B; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ufNlTX7B" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-c127ec4447cso50039866b.2 for ; Mon, 29 Jun 2026 06:51:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1782741100; x=1783345900; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A8EFC4s909q8I7RU8JVrkHNARL0nFv4eMvLzK4nBUtQ=; b=ufNlTX7BfPn4IaANtkEmrGj/YMcyjP6eCUw+REMKX8SVC5agxxrXrMb+kYLaj4uyuY vZ9jfjOwUuHKmtENE/J8ihBgqEC93IwCfEgi2OOW4ndahSro4MT+mYknbytq4UC2vjME AmbagbAPEVGp0faqO//4x5laQzJUGmQdYL6yUZfmdXUsHWJR/20Lr5R5Z+3u6xUrBJfZ Ijsa+JOrplXU89EMhY/2bav+YhXi7ao0QwN0vwRU62tYexB28SV0i/gOxhwf1A9Kr/b2 A5MA/+3lOl2gEJhNNDNdZrbIxUTExeGRP3Jct72FNpISheheBdJd8JAcsMSJJTWw/r8p hxfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782741100; x=1783345900; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A8EFC4s909q8I7RU8JVrkHNARL0nFv4eMvLzK4nBUtQ=; b=jlN4zgC14aF7il6p+EPV/7/72OXAFbFv4F+D0jZid7AyEDXZDswK1S5g0Ni9eRwQbv uW4S5LpaMu01KsY6KkxUXOubknQWQkY3gmwTzLxCGTudplONpFejpal1PuyFwy78Yofa z4iqafwNGspfa4KOrOolXoE9BDcu6y3veKsEiJx71G+mtXsr8nuCzhJq3JvTtrYQi+S1 Yt9cQgs7VMO/y7fuKjeipxUGiSBDY54YyF0DeV0lPwRXDihi0PU0jbSy59iyP5nhFm21 /9TCVsQibJSU5ZCUf/eLQl5/jXu4aw+P8E9f3eGeCX2gpSLrclKm2YRF3yvakc3TTX3N Qmzw== X-Forwarded-Encrypted: i=1; AHgh+RpALLTmcNjoydjC2PWia9uAcdbt/0MyCXZoiz5bQTeoZ+8i5AjAfi3CpMvAi4tpOtQVukBULyCrSWsWleg=@vger.kernel.org X-Gm-Message-State: AOJu0YzIn30rEfD+hT6juBuGgZq2EUh3JlY2q+7fUbvhq+EMdiAUHcqg 8f6Ltrby17azxnejkGloajJXqRiCL+pa679CmvKwJdTrfAoptvSTUvv2BJnHiY+7KjU= X-Gm-Gg: AfdE7ckrKce5mgOTCagzr7Ffouz/4jFifPCqJ3XXAC86VPWFmRmBe28U5Ut69w3bxAu dWNVNwMavMut/4BeEle9Adn1PuNffebPgBSAR5KuLIdqIJZJJuQyltP2yW7GUud/oylVzRKNDbe TMRTll/HliGW9KUoL0is1fiHXExy4o4+m5tibXD4/uOFFqkXXOEETc2gHCLJoYUIE/y3DaE/b3F 3H84imp4FKGeC3KkFJrKZTnO1oZIJMbP69OeIf40/uxccAIV8gBIkFaBuL7jeiV5BJbH4/+wPak CFml/ei0gRDn5xmaTUBGANj6LN4Fr8wFdelyq0barWRhO7QlafIXTZdbZGbj/lK8U1Xi7bab4ks o+mYqC4V8iH+PuuS4wDeDI3y9n/ZFeWSnkyaJJNPk9NIxg+jfL5YgROvpX3oKsiC8m6ozLcsv3X b47dUxrvtaYqM8wUB/U9gJh+Ic X-Received: by 2002:a17:906:8c4:b0:c12:79aa:8289 with SMTP id a640c23a62f3a-c12816c2116mr28295466b.40.1782741097886; Mon, 29 Jun 2026 06:51:37 -0700 (PDT) Received: from [192.168.0.101] ([109.77.22.163]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c126ff294b6sm124967466b.21.2026.06.29.06.51.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 06:51:37 -0700 (PDT) Message-ID: Date: Mon, 29 Jun 2026 14:51:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/9] media: iris: Replace ternary conditionals with max() To: Ricardo Ribalda , Mauro Carvalho Chehab , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Shuah Khan , Kieran Bingham , Bin Du , Nirujogi Pratap , Sultan Alsawaf , Svetoslav Stoilov , Sakari Ailus , Abylay Ospan Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260629-cocci-7-2-v1-0-5884c80ee3b6@chromium.org> <20260629-cocci-7-2-v1-2-5884c80ee3b6@chromium.org> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: <20260629-cocci-7-2-v1-2-5884c80ee3b6@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29/06/2026 12:30, Ricardo Ribalda wrote: > The max() macro is simpler to read than the current construction, it > also makes cocci happier, which currently throws these warnings: > > ./platform/qcom/iris/iris_vpu_buffer.c:703:13-15: WARNING opportunity for max() > ./platform/qcom/iris/iris_vpu_buffer.c:583:23-25: WARNING opportunity for max() > > Signed-off-by: Ricardo Ribalda > --- > drivers/media/platform/qcom/iris/iris_vpu_buffer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_vpu_buffer.c b/drivers/media/platform/qcom/iris/iris_vpu_buffer.c > index fb6f1016415e..faebb5472866 100644 > --- a/drivers/media/platform/qcom/iris/iris_vpu_buffer.c > +++ b/drivers/media/platform/qcom/iris/iris_vpu_buffer.c > @@ -580,7 +580,7 @@ static u32 hfi_buffer_line_av1d(u32 frame_width, u32 frame_height, > ALIGN(size_av1d_qp(frame_width, frame_height), DMA_ALIGNMENT); > opbwr8 = size_av1d_lb_opb_wr1_nv12_ubwc(frame_width, frame_height); > opbwr10 = size_av1d_lb_opb_wr1_tp10_ubwc(frame_width, frame_height); > - opbwrbufsize = opbwr8 >= opbwr10 ? opbwr8 : opbwr10; > + opbwrbufsize = max(opbwr8, opbwr10); > size = ALIGN((size + opbwrbufsize), DMA_ALIGNMENT); > if (is_opb) { > vpss_lb_size = size_vpss_lb(frame_width, frame_height); > @@ -700,7 +700,7 @@ static u32 hfi_buffer_ibc_av1d(u32 frame_width, u32 frame_height) > > ibc8 = size_av1d_ibc_nv12_ubwc(frame_width, frame_height); > ibc10 = size_av1d_ibc_tp10_ubwc(frame_width, frame_height); > - size = ibc8 >= ibc10 ? ibc8 : ibc10; > + size = max(ibc8, ibc10); > > return ALIGN(size, DMA_ALIGNMENT); > } > > -- > 2.55.0.rc0.799.gd6f94ed593-goog > Reviewed-by: Bryan O'Donoghue --- bod