From: "Franck Bui-Huu" <vagabon.xyz@gmail.com>
To: "Ralf Baechle" <ralf@linux-mips.org>
Cc: "Adrian Bunk" <bunk@stusta.de>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] include/asm-mips/processor.h: "extern inline" -> "static inline"
Date: Mon, 9 Jul 2007 13:40:40 +0200 [thread overview]
Message-ID: <cda58cb80707090440u1d320fc0u1cc04f95a443e226@mail.gmail.com> (raw)
In-Reply-To: <20070709102754.GB24487@linux-mips.org>
Hi,
On 7/9/07, Ralf Baechle <ralf@linux-mips.org> wrote:
> On Sat, Jul 07, 2007 at 03:03:30AM +0200, Adrian Bunk wrote:
>
> > "extern inline" will have different semantics with gcc 4.3,
> > and "static inline" is correct here.
>
> The idea was to have a linker error in case gcc should deciede for some
> reason not to inline this function which as I understand will continue
> to be the behaviour of gcc 4.3?
>
I don't know for this peculiar case but it usually is a good thing to
let gcc decide if the function needs to be inlined or not.
If we really want this function to be inlined in all cases, maybe we
should use __always_inline attribute instead ?
--
Franck
next prev parent reply other threads:[~2007-07-09 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-07 1:03 Adrian Bunk
2007-07-09 10:27 ` Ralf Baechle
2007-07-09 11:40 ` Franck Bui-Huu [this message]
2007-07-09 12:22 ` Adrian Bunk
2007-07-09 13:06 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cda58cb80707090440u1d320fc0u1cc04f95a443e226@mail.gmail.com \
--to=vagabon.xyz@gmail.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®