From: Shuai Xue <xueshuai@linux.alibaba.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: "baolin.wang@linux.alibaba.com" <baolin.wang@linux.alibaba.com>,
"benjamin.cheatham@amd.com" <benjamin.cheatham@amd.com>,
"bp@alien8.de" <bp@alien8.de>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"jaylu102@amd.com" <jaylu102@amd.com>,
"lenb@kernel.org" <lenb@kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rafael@kernel.org" <rafael@kernel.org>,
"zhuo.song@linux.alibaba.com" <zhuo.song@linux.alibaba.com>
Subject: Re: [PATCH] ACPI: APEI: EINJ: warn on invalid argument when explicitly indicated by platform
Date: Thu, 23 Mar 2023 09:18:16 +0800 [thread overview]
Message-ID: <cda5ce13-78f9-1a00-c792-8421d8f14013@linux.alibaba.com> (raw)
In-Reply-To: <SJ1PR11MB6083FE558641F0E57FF1F5A4FC869@SJ1PR11MB6083.namprd11.prod.outlook.com>
On 2023/3/23 AM12:07, Luck, Tony wrote:
>> Fix to return -EINVAL in the __einj_error_inject() error handling case
>> instead of -EBUSY, when explicitly indicated by the platform in the status
>> of the completed operation.
>
> Needs a bit longer description on the use case based on follow up discussion.
> Key information is the EINVAL is an indicator to the user that the parameters they
> supplied cannot be used for injection.
>
> But for the code:
>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
>
> -Tony
Got, I will rephrase the commit log based on follow up discussion.
Thank you for reviews.
Cheers,
Shuai
next prev parent reply other threads:[~2023-03-23 1:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 7:33 Shuai Xue
2023-03-17 21:24 ` Luck, Tony
2023-03-20 2:25 ` Shuai Xue
2023-03-20 16:32 ` Luck, Tony
2023-03-21 2:00 ` Shuai Xue
2023-03-21 16:09 ` Luck, Tony
2023-03-22 2:37 ` Shuai Xue
2023-03-22 16:07 ` Luck, Tony
2023-03-22 16:52 ` Rafael J. Wysocki
2023-03-23 1:19 ` Shuai Xue
2023-03-23 1:18 ` Shuai Xue [this message]
2023-03-23 1:53 ` [PATCH v2] " Shuai Xue
2023-03-27 18:47 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cda5ce13-78f9-1a00-c792-8421d8f14013@linux.alibaba.com \
--to=xueshuai@linux.alibaba.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=benjamin.cheatham@amd.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=james.morse@arm.com \
--cc=jaylu102@amd.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tony.luck@intel.com \
--cc=zhuo.song@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®