Re: [PATCH 2/4] leds: rgb: qcom-lpg: add qcom,pmk8850-pwm compatible

[Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>]

On 10/19/26 3:34 PM, Lee Jones wrote:
> --- checkpatch.pl (1 issue) ---
> Line 23: WARNING: DT compatible string "qcom,pmk8850-pwm" appears un-documented -- check ./Documentation/devicetree/bindings/
this is in patch 1/4.
> ----------------------------------
> 
> On Thu, 15 Oct 2026, Srinivas Kandagatla wrote:
> 
>> The PMK8850 sleep-clock PMIC on Snapdragon X2 Elite (Mahua) exposes
>> the same two-channel LPG/PWM block as PMK8550 at 0xe800/0xe900, so
>> reuse pmk8550_pwm_data.
>>
>> Used on the Lenovo ThinkPad T14s Gen 7 to drive the eDP backlight
>> (EDP_BL/PWMR_BV_PS).
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
>> ---
>>  drivers/leds/rgb/leds-qcom-lpg.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c
>> index 24ffe079f221..485fa2a7a848 100644
>> --- a/drivers/leds/rgb/leds-qcom-lpg.c
>> +++ b/drivers/leds/rgb/leds-qcom-lpg.c
>> @@ -1837,6 +1837,7 @@ static const struct of_device_id lpg_of_table[] = {
>>  	{ .compatible = "qcom,pmi8998-lpg", .data = &pmi8998_lpg_data },
>>  	{ .compatible = "qcom,pmc8180c-lpg", .data = &pm8150l_lpg_data },
>>  	{ .compatible = "qcom,pmk8550-pwm", .data = &pmk8550_pwm_data },
>> +	{ .compatible = "qcom,pmk8850-pwm", .data = &pmk8550_pwm_data },
> If PMK8850 is completely compatible with PMK8550, why are we adding a
> new match entry here instead of using 'qcom,pmk8550-pwm' as a fallback
> compatible?
Yep, will update dts in v2 and drop this patch.

--srini


>