From: Gabriele Monaco <gmonaco@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Kuan-Wei Chiu <visitorckw@gmail.com>,
Nam Cao <namcao@linutronix.de>
Subject: Re: [GIT PULL] rv: Fixes for 7.3
Date: Thu, 27 Aug 2026 09:10:21 +0200 [thread overview]
Message-ID: <cdb6e6b4f8841e4de6363f50386c14d51606faf9.camel@redhat.com> (raw)
In-Reply-To: <CAHk-=wj9O9CajaEKFuHJ7q1TgNm+5n0WgOWcspDXjxVaWq3HFg@mail.gmail.com>
On Wed, 2026-08-26 at 14:56 -0700, Linus Torvalds wrote:
> On Wed, 26 Aug 2026 at 11:48, Steven Rostedt <rostedt@goodmis.org> wrote:
> > The rvgen kunit command generates .bak backup files and these are
> > checked in for selftests as "golden" files for make check.
>
> What?
>
> What broken tool checks in generated files?
The standard usage of rvgen is to process a specification file (e.g. dot) and
generate code that is then /modified/ to be included in the kernel as working C
code. That's what you can see in kernel/trace/rv/monitors/ .
In this case, the golden directory is used only for rvgen's test suite, the
files needed to validate that the generation works, which has helped
tremendously during the past iterations of the tool.
This approach is similar to what is done in scripts/kconfig/tests/ with
*expected* files.
Thanks,
Gabriele
next prev parent reply other threads:[~2026-08-27 7:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 18:48 Steven Rostedt
2026-08-26 21:56 ` Linus Torvalds
2026-08-27 7:10 ` Gabriele Monaco [this message]
2026-08-26 22:09 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdb6e6b4f8841e4de6363f50386c14d51606faf9.camel@redhat.com \
--to=gmonaco@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®