mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: rkardell <rkardell@mida.se>
To: linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>, linux-kernel@vger.kernel.org
Subject: [PATCH] media: dvb: mt352, change i2c read buffer from stack, to kernel space
Date: Thu, 7 Oct 2021 13:44:06 +0200	[thread overview]
Message-ID: <cdb8ea1d-0bd6-ec1d-e72f-0298f286170a@mida.se> (raw)

Solve problem with initialization of Mega Sky 580 USB DVB (and other 
using mt352), error when reading i2c id.


Signed-off-by: rkl099 <rkardell@mida.se>
---
  drivers/media/dvb-frontends/mt352.c | 9 ++++++---
  1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/media/dvb-frontends/mt352.c 
b/drivers/media/dvb-frontends/mt352.c
index 399d5c519..d7f33558d 100644
--- a/drivers/media/dvb-frontends/mt352.c
+++ b/drivers/media/dvb-frontends/mt352.c
@@ -69,7 +69,7 @@ static int mt352_read_register(struct mt352_state* 
state, u8 reg)
  {
         int ret;
         u8 b0 [] = { reg };
-       u8 b1 [] = { 0 };
+    u8 *b1=kmalloc(1,GFP_KERNEL);
         struct i2c_msg msg [] = { { .addr = state->config.demod_address,
                                     .flags = 0,
                                     .buf = b0, .len = 1 },
@@ -82,12 +82,15 @@ static int mt352_read_register(struct mt352_state* 
state, u8 reg)
         if (ret != 2) {
                 printk("%s: readreg error (reg=%d, ret==%i)\n",
                        __func__, reg, ret);
+               kfree(b1);
                 return ret;
         }
-
-       return b1[0];
+    ret=b1[0];
+    kfree(b1);
+       return ret;
  }

+
  static int mt352_sleep(struct dvb_frontend* fe)
  {
         static u8 mt352_softdown[] = { CLOCK_CTL, 0x20, 0x08 };
-- 
2.30.2



             reply	other threads:[~2021-10-07 11:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 11:44 rkardell [this message]
2021-11-19 16:16 ` Mauro Carvalho Chehab
2021-11-19 16:17   ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdb8ea1d-0bd6-ec1d-e72f-0298f286170a@mida.se \
    --to=rkardell@mida.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome