From: dinghao.liu@zju.edu.cn
To: "Takashi Iwai" <tiwai@suse.de>
Cc: kjlu@umn.edu, "Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>, "Mark Hills" <mark@xwax.org>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
"Giuliano Pochini" <pochini@shiny.it>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: Re: [PATCH] ALSA: echoaudio: Fix memory leak in snd_echo_resume()
Date: Thu, 13 Aug 2020 14:44:05 +0800 (GMT+08:00) [thread overview]
Message-ID: <cdb962d.569f9.173e68fb9e9.Coremail.dinghao.liu@zju.edu.cn> (raw)
In-Reply-To: <s5h7du76lew.wl-tiwai@suse.de>
> On Mon, 10 Aug 2020 08:14:58 +0200,
> Dinghao Liu wrote:
> >
> > When restore_dsp_rettings() fails, chip should be freed
> > just like when init_hw() and request_irq() fails.
> >
> > Fixes: 47b5d028fdce8 ("ALSA: Echoaudio - Add suspend support #2")
> > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
>
> Actually it's rather wrong to call snd_echo_free() in the resume error
> path. This may lead to an Oops at the next time the system goes to
> resume. That said, we should drop snd_echo_free() calls in other
> error paths in snd_echo_resume() instead.
>
Thank you for your advice! I will send a new patch to fix this soon.
Regards,
Dinghao
prev parent reply other threads:[~2020-08-13 6:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 6:14 Dinghao Liu
2020-08-10 6:54 ` Takashi Iwai
2020-08-13 6:44 ` dinghao.liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdb962d.569f9.173e68fb9e9.Coremail.dinghao.liu@zju.edu.cn \
--to=dinghao.liu@zju.edu.cn \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=dan.carpenter@oracle.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@xwax.org \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=pochini@shiny.it \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®