From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACC35C63777 for ; Tue, 17 Nov 2020 09:17:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E3CB24655 for ; Tue, 17 Nov 2020 09:17:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="jCSg/LpM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727232AbgKQJRC (ORCPT ); Tue, 17 Nov 2020 04:17:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726035AbgKQJRB (ORCPT ); Tue, 17 Nov 2020 04:17:01 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC04EC0617A6 for ; Tue, 17 Nov 2020 01:16:59 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id p1so22359672wrf.12 for ; Tue, 17 Nov 2020 01:16:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=MDtk7CaVA2R3o2gPQYkO2PpHsr3cKxkUX8lkMgx4vWk=; b=jCSg/LpM9T3TasQK0pOYLU2PdOBSCJ7rhx2ywbCucbK35JyfPpw4TsIeTKgrQ5K5A4 adeg0g/wSdtS/8A/fTMKmCFoIGMweGqpVivYLpnzjYNuKOV9Kagign9KKHaN2nnyLryK tkbrbWKxXyHq8FevU+rMII3OLsKsFo6FguEHDfhm+bmT0oixa22i29HG5MB4mb+wU0bx OxdN33czTGYhfmqTBm7hvtOUM/UBpVlJSfUzJfMoWZvI0w28g7PZ2K7AMR/B9G+2lH8X mdyKW8Sz/sAi5r9Y1kRfAHPnbR7qs+SurdOIAydwebkFyCl8MTRsEvVDKMcL3n1ztlKS YOeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=MDtk7CaVA2R3o2gPQYkO2PpHsr3cKxkUX8lkMgx4vWk=; b=dxRiiqTpZS8ZY+VjYslhte7MdN1AlnQy9zpVwBcqlZvkt09o8TW82+tZSsOY2TB9Ap oyXu81Asn6DzytENwkqx05nG7ADt/BOODK3Ba4LnbhkmJdRGuh1tG09a+zw8kVcgUUW/ uakBgmd/VQSrSqt3JAp4WjOI28n+xpLRj+fGsIQjc4nMXxMkLNTAgCqsxfC0BBSK85AS Myu81Q1eJqeVVpMfM25h7C8VNw344RG4tyUgAd1qkCMlkxpdoEiRNYcIuXVcSRlp3U5J /krgR0UdVgzSqtJagdbfsGiuRg8rwDf6VNFemOYPnepRcuCpMW5wc3uKfgwjcn7LEpSX j4rA== X-Gm-Message-State: AOAM532AM6ptDSeG2SrQWAEweg9X9NuWIXeUkiGCx9thM+SrqQilDE6l EGKPRScNzwgecDfYmrOHNdQRhpaGpiT6lbKu X-Google-Smtp-Source: ABdhPJycFFxJJ184g8hhJdy18ua9XwfcJ0b61PxrGHf3KdoaD1f5//kMGDhO47wCHXJ23ejf/LCtEA== X-Received: by 2002:adf:9066:: with SMTP id h93mr25171539wrh.166.1605604618486; Tue, 17 Nov 2020 01:16:58 -0800 (PST) Received: from ?IPv6:2001:861:3a84:7260:b09f:f7de:c7af:258b? ([2001:861:3a84:7260:b09f:f7de:c7af:258b]) by smtp.gmail.com with ESMTPSA id 15sm2589534wmg.1.2020.11.17.01.16.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Nov 2020 01:16:57 -0800 (PST) Subject: Re: [PATCH 1/3] phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use To: Martin Blumenstingl Cc: Kevin Hilman , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Philipp Zabel , linux-amlogic@lists.infradead.org, Jerome Brunet References: <20201113000508.14702-1-aouledameur@baylibre.com> <20201113000508.14702-2-aouledameur@baylibre.com> From: Amjad Ouled-Ameur Message-ID: Date: Tue, 17 Nov 2020 10:16:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Martin, On 14/11/2020 20:13, Martin Blumenstingl wrote: > Hi Amjad, > > On Fri, Nov 13, 2020 at 1:06 AM Amjad Ouled-Ameur > wrote: > [...] >> @@ -124,6 +126,7 @@ static int phy_meson_gxl_usb2_exit(struct phy *phy) >> { >> struct phy_meson_gxl_usb2_priv *priv = phy_get_drvdata(phy); >> >> + reset_control_rearm(priv->reset); > please move reset_control_rearm after clk_disable_unprepare as > mentioned on the other patch to clean things up in reverse order of > initialization Agreed, will fix it in next change ! > >> clk_disable_unprepare(priv->clk); > > Thank you > Martin > Thank you for the feedback ! Best, Amjad