From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36046285CA9 for ; Sat, 10 Jan 2026 17:28:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768066087; cv=none; b=QHnGbchidY9tKv/ggkMbhnwbbZKgSUSQ02CxlH+JYjV9G0alGtjXrD5KOSj8E6Yly7H3gx48kcg3QTLRnVf4bgZidQ37qrJd5sNvRdOwNQUmycmfnZJClOa+qsGPK0QdM76qkx6JWGOvtPD7a4kCkHET96z0Di1A//pGMOXBoMk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768066087; c=relaxed/simple; bh=Bm21lO7kzxFVEUxOrX69gehbqX1DwoPdd62omyuA5aE=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=bhz43CPEkFMo8rByl1rZWX90zT+B/MlpT/HrZ2LHItUX/23DfP31MLmtRJlw+Zkriae1CP77ltYs4QSefROQr/dpRS024UkEP0Qccv3qc/OSkzuaCt9qNGYHb0FT/xcolPsVtBd6f2IRltdti4wfPaMHvR2cnnne94w5H1b6tNo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=GAiFdiVy; arc=none smtp.client-ip=209.85.210.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="GAiFdiVy" Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-7c78d30649aso3671965a34.2 for ; Sat, 10 Jan 2026 09:28:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1768066084; x=1768670884; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=TXruW4vZ8ixZMvSdqPOKj/W54NefVRcJvx7qIpkFANo=; b=GAiFdiVyEDIso+JLWVtYNZjhTOjLxOrVOhRc927cG6v9x8kqA7L8ecLCmOyIxRViKg +CSGKWh0JFG5m/o01+27xcWYfi30NptbM8h6NTphWM8QkfE93GeWw88RWedXDReIvvvV /H4KYwWnySclUEzrGn7Ls7VigzrlZAgsirBdvvsPtJlxz1MQ0do9lFoMy1dXpG7Ga1Bb bgwvS18gSc2tx86aT7Ciqq+PRydKHlBOklOaavn+01Ohz2vU0ONLTksKjapx8+/G6/zS N81uI0BlwynGizerk3k5PoA8M0nVlRsczHzQLY7gnb9XKcDk/7AkPLV8QQsFWnjzVv10 Ekpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768066084; x=1768670884; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TXruW4vZ8ixZMvSdqPOKj/W54NefVRcJvx7qIpkFANo=; b=ghgKKHyhvRo42l1vrb8oia5r+3VW4KJgTzCJZ4U0zgbobOi0wZZs9xODj/rRyG2i6o a4dwhoeM1wRkeNB3f2qGd4Yu+ACgTpAwpFOnKfmnhRRNDOiBkf2YwAA4M7xUsSv84Dm7 0xLvZk0piHuWaZRELS+VjEjeqfo3LXxMGj9k3ol9MCbZU1Fw4m5YNdG9J2fp/rWBaNzb lAZwF4ZkmKj47yLPLufLZZu8V6QEJe/TXOEy9YxxmCPHn0YOVEUVy/XA6rWAH24SCvUk BielWBCMTZZtdI2lFnutSwDWptGlNDEpIxhgTx3YQ8ByGr4nE9rV+qILE3Qi0fy90wHq Tqdw== X-Forwarded-Encrypted: i=1; AJvYcCVmxRxl/Q6OanqkOcSkYAl5El2KunmqtSTsJLMyJT819cpi0AZwnUhptZxA8xK+0NE3JkqFJQi6aV9bLQI=@vger.kernel.org X-Gm-Message-State: AOJu0Ywz6DSg08uzhDNXB5wznespu9VXqjMhxhJ2Pe1g0yo7SQ6k+RuM TDFhTDshGV/EmoxjDSrBZERR3z+rfxDz06UTo5g4aW1iAWVZ+GJxY8MqSeAKSoAUrV8= X-Gm-Gg: AY/fxX7KZkRddIdCl0s6ZSwfp9Nsnuckr3x2/1jaAOjdMvHWLWJxAqRFiWcThNwjBFU UhsgNA0YTNH6P4f9EMtLfdDf/yQrDpxxn+cCWzK9G/NEKeFFUQji84OqGhALvmyuCooovTQZxtN e4FUOr/m5a8wWtGJrO6a24+ejg9sT6v+IKEoppw5u1/J3MX6k4RS1zgbrvMDJp3A09/jaXAs78t ++aLuOXoDzPPF1j/0y6cMeogiLNlBr9p/KdGZJH+zJTn/S+Cd6Ab8/h4LFq5pBkql3Ht6vMHHus UiEy7uAcaJLLQyrYNdAWDj4MMycFPipTA1bB/9zBkNGrNMkSjF4VeMlb52DDzExsg2H7bBBVTFz LyiXA8RaRkWnQZk6NoKX3Q1eFM1fujbc91Cbj1EnaOkY4m+igNrDCw9ohblX1Qt9PE5Yqjb0wgA JLv+V5s2O0 X-Google-Smtp-Source: AGHT+IE3j4WuOvoW2sMO5AGZsgxxfm6j57157cp0sDKxph5B/9oRM7JR3Y0F3EFt1bIIVczxw4F4Ew== X-Received: by 2002:a05:6830:3141:b0:7c6:ca62:e258 with SMTP id 46e09a7af769-7ce50a01f56mr7412873a34.21.1768066084124; Sat, 10 Jan 2026 09:28:04 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ce47801d63sm9443098a34.6.2026.01.10.09.28.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Jan 2026 09:28:03 -0800 (PST) Message-ID: Date: Sat, 10 Jan 2026 10:28:02 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/3] block: zero non-PI portion of auto integrity buffer From: Jens Axboe To: Caleb Sander Mateos Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Anuj Gupta , Christoph Hellwig References: <20260108172212.1402119-1-csander@purestorage.com> <176796707483.352942.3630670392140403614.b4-ty@kernel.dk> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/10/26 10:21 AM, Jens Axboe wrote: > On 1/9/26 9:29 AM, Caleb Sander Mateos wrote: >> On Fri, Jan 9, 2026 at 5:57?AM Jens Axboe wrote: >>> >>> >>> On Thu, 08 Jan 2026 10:22:09 -0700, Caleb Sander Mateos wrote: >>>> For block devices capable of storing "opaque" metadata in addition to >>>> protection information, ensure the opaque bytes are initialized by the >>>> block layer's auto integrity generation. Otherwise, the contents of >>>> kernel memory can be leaked via the storage device. >>>> Two follow-on patches simplify the bio_integrity_prep() code a bit. >>>> >>>> v2: >>>> - Clarify commit message (Christoph) >>>> - Split gfp_t cleanup into separate patch (Christoph) >>>> - Add patch simplifying bi_offload_capable() >>>> - Add Reviewed-by tag >>>> >>>> [...] >>> >>> Applied, thanks! >>> >>> [1/3] block: zero non-PI portion of auto integrity buffer >>> commit: eaa33937d509197cd53bfbcd14247d46492297a3 >> >> Hi Jens, >> I see the patches were applied to for-7.0/block. But I would argue the >> first patch makes sense for 6.19, as being able to leak the contents >> of kernel heap memory is pretty concerning. Block devices that support >> metadata_size > pi_tuple_size aren't super widespread, but they do >> exist (looking at a Samsung NVMe device that supports 64-byte metadata >> right now). > > Good point, let me see if I can reshuffle it a bit. In the future, would > be nice with these split, particularly if they don't have any real > dependencies. I'll shift 1/3 to block-6.19. Done - 1/3 is now in block-6.19. I dropped 2/3 as it's mostly useless and will now through a conflict in for-7.0/block. 3/3 still in there. -- Jens Axboe