Re: [PATCH v4 14/14] RDMA/ionic: Add Makefile/Kconfig to kernel build environment

[Abhijit Gangurde <abhijit.gangurde@amd.com>]

On 7/23/25 23:43, Shannon Nelson wrote:
> On 7/23/25 10:31 AM, Abhijit Gangurde wrote:
>> Add ionic to the kernel build environment.
>>
>> Co-developed-by: Allen Hubbe <allen.hubbe@amd.com>
>> Signed-off-by: Allen Hubbe <allen.hubbe@amd.com>
>> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
>> ---
>> v2->v3
>>    - Removed select of ethernet driver
>>    - Fixed make htmldocs error
>>
>>   .../device_drivers/ethernet/index.rst         |  1 +
>>   .../ethernet/pensando/ionic_rdma.rst          | 43 +++++++++++++++++++
>>   MAINTAINERS                                   |  9 ++++
>>   drivers/infiniband/Kconfig                    |  1 +
>>   drivers/infiniband/hw/Makefile                |  1 +
>>   drivers/infiniband/hw/ionic/Kconfig           | 15 +++++++
>>   drivers/infiniband/hw/ionic/Makefile          |  9 ++++
>>   7 files changed, 79 insertions(+)
>>   create mode 100644 
>> Documentation/networking/device_drivers/ethernet/pensando/ionic_rdma.rst
>>   create mode 100644 drivers/infiniband/hw/ionic/Kconfig
>>   create mode 100644 drivers/infiniband/hw/ionic/Makefile
>>
>> diff --git 
>> a/Documentation/networking/device_drivers/ethernet/index.rst 
>> b/Documentation/networking/device_drivers/ethernet/index.rst
>> index 139b4c75a191..4b16ecd289da 100644
>> --- a/Documentation/networking/device_drivers/ethernet/index.rst
>> +++ b/Documentation/networking/device_drivers/ethernet/index.rst
>> @@ -50,6 +50,7 @@ Contents:
>>      neterion/s2io
>>      netronome/nfp
>>      pensando/ionic
>> +   pensando/ionic_rdma
>>      smsc/smc9
>>      stmicro/stmmac
>>      ti/cpsw
>> diff --git 
>> a/Documentation/networking/device_drivers/ethernet/pensando/ionic_rdma.rst 
>> b/Documentation/networking/device_drivers/ethernet/pensando/ionic_rdma.rst 
>>
>> new file mode 100644
>> index 000000000000..80c4d9876d3e
>> --- /dev/null
>> +++ 
>> b/Documentation/networking/device_drivers/ethernet/pensando/ionic_rdma.rst
>> @@ -0,0 +1,43 @@
>> +.. SPDX-License-Identifier: GPL-2.0+
>> +
>> +============================================================
>> +Linux Driver for the AMD Pensando(R) Ethernet adapter family
>> +============================================================
>> +
>> +AMD Pensando RDMA driver.
>> +Copyright (C) 2018-2025, Advanced Micro Devices, Inc.
>> +
>> +Contents
>> +========
>> +
>> +- Identifying the Adapter
>> +- Enabling the driver
>> +- Support
>> +
>> +Identifying the Adapter
>> +=======================
>> +
>> +See Documentation/networking/device_drivers/ethernet/pensando/ionic.rst
>> +for more information on identifying the adapter.
>> +
>> +Enabling the driver
>> +===================
>> +
>> +The driver is enabled via the standard kernel configuration system,
>> +using the make command::
>> +
>> +  make oldconfig/menuconfig/etc.
>> +
>> +The driver is located in the menu structure at:
>> +
>> +  -> Device Drivers
>> +    -> InfiniBand support
>> +      -> AMD Pensando DSC RDMA/RoCE Support
>
> Please add some verbage about this being an auxiliary_device dependent 
> on the ionic driver, and that it can be disabled/enab led with a 
> devlink command.
>
> sln
>
Sure. I'll add verbiage explaining that this is an auxiliary device 
dependent on the ionic driver. Although this series doesn't include the 
devlink changes for enabling/disabling functionality, I'll make sure to 
mention this aspect when the devlink changes are submitted.

Thanks,
Abhijit