From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C58335504D for ; Tue, 17 Feb 2026 12:51:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771332690; cv=none; b=jWBI0GxeX9I8dBRVuXoPTa93KS86HxpTfotdozKmImw8SlEGpsQrOeDPB/AGaSmJnxItaNNltdtJQYRz/8lb5VZ8fUcOKuuDCHRVM/t3aYq9+YbmU40ZgGSvbOw5v812UQXs7FVHZr1un7NSU6tGDR92uYSSaI9cC02FtRa22Xk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771332690; c=relaxed/simple; bh=Ca3zSXt8QGtVOUGGIoxDeLx7u9+fOCOqDTWoTo2FmJA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TvjAhvWsAkn5TagHDRErBt8aO/m2vR61vWCwokfPGSniivEEuJuSp9ooe8UhOnlqhheueQUPpVkja5Dbuu0Idtm1BpHJBAqqCzd7pWdIERMVpB635CfthAmls/lmbgPxYf8duIWBIA/V7+t8ib1ndXOg3kTsB3r6I8RokJg0xUs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Feb49PJs; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kH85NwAH; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Feb49PJs"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kH85NwAH" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61H8TOYP048843 for ; Tue, 17 Feb 2026 12:51:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= asaSuZLFZGJBkgVGIsOK4VggmZQuyypXqKdUggUVJh4=; b=Feb49PJsHWiHVOed tqFLfjMEJqVsssCzoNDvHM49DwOnTQrFcnXTwDvCrTMpcHr2awSOlfdT7s5YJRyo aEg5/f6TaX0mpHFY3i5NIJBC0LnWjv2sc2eJ5ASzdY0IhocssV1Ha+JJQozZRhLL DPmss3aPZt+oWJ/wOs1GNBOIHKt4hVY5GI3FiZ6l5SS/VCoJ6PdTAgEippwQeSvS efzaY6j78PyH7cuRvY069ZZA0RDMLu3w1SpdyAc/UY8CSfLzYilDuNZTKl2LXwoE YaeqwG+wCE++kDohWncstcmwu1Q4ROsFt2TWI0LlWy160CEpfRIGlVVz63k90rW9 tfSY+w== Received: from mail-dl1-f71.google.com (mail-dl1-f71.google.com [74.125.82.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cc6d82duj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Feb 2026 12:51:28 +0000 (GMT) Received: by mail-dl1-f71.google.com with SMTP id a92af1059eb24-1270be4d176so14888992c88.1 for ; Tue, 17 Feb 2026 04:51:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771332688; x=1771937488; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=asaSuZLFZGJBkgVGIsOK4VggmZQuyypXqKdUggUVJh4=; b=kH85NwAHZvk5rSI59fZsSBM5JBJfPEMpc2dcQM+QuL1aKiZUvhTCS0PZk1wUe9ll6q +KopGukydeZtbBat8ef2ufEdijZX8ksQ3REtNIQXwthgMZUbgSN2+YR9dWHE1IYUeDLa syrYDTu/EtuqHfB9lERGgWwrDyj1YZ16sepZuqAMIN9LkksRFRsFza8X+Wd8u0L4uy+l FTp4JpDe0QPfu0kajKa2bivSiN5zB7Jb2B0bmmDyf5eGrFVsKJjmT9Erf7/ZyV+yY+Zd 37brRn64p4Vj1bLNyXY1SJvarUkJMloJSsiI2btIxL7HNYI1SnoazOWYLTDFCHGbdZpq SNUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771332688; x=1771937488; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=asaSuZLFZGJBkgVGIsOK4VggmZQuyypXqKdUggUVJh4=; b=RXjQzj8QgzdLh3KIP26BJ//dvZIgOhqIyk5uvdMP6CW3lZ76MqQixB9rmQMqIIHAUo TU9KFgjS+tl7hf2FGj344F6SZdjeT4hdFrUolXXO8SsOC/0/YMhS7Wc026Adh48dtJu4 WU+HtOQjcLdqbRnDyMdVPcEUWikVePLl+DTyX0VcpdqCXwc6UEPBEgpoRkZ8juuFliaB Xs2Xe+ad/twup9C+gOOXZsnaYxZtDp5+/Wa6S2zIBvrTH2LANIJB/gqNUrBS0OQzVAOk P4GfamZtjxuP+5JrGq3Cz3zDG8HzkOX9WZxmDO/zdBsdrxquwuQHigHYu3vYKqqIzcjr RLoA== X-Forwarded-Encrypted: i=1; AJvYcCXpBJR6MCUix7mlH3zlAwSqXsUpcygrOAyMZj8LeeJVIOOM7S/Geaae4DNzF4HlxHqxgtPwtBVzE+BQBgo=@vger.kernel.org X-Gm-Message-State: AOJu0YyGFlF8wrBpbmMzdWLIU0mIwMHInEAoaq415s4ozhmvlcPbso2I DyMmmi9AK6K3OXVA7iZbS773dSX2jSwpjVeoUreE5K3v08ho+3a9q2uKqTMKKx6w4XajIachIUT cOrP16m/cZDr0Ztzi7S9iMEmwvlJMgppDovh7Fpzulh5NcwroEEyZs555TeT1x75/qiU= X-Gm-Gg: AZuq6aK8sMpyM5/hK4TifpAYvbbfby63DWQ/cPxco5ptiIiPhTbmCQTWGYUwkX/kJM6 GF/9iX4rGhLnTE/fKH/vnP/PADD0VAIEa1TxQaYxPh5emwTJrgI4RJSTpXl62YbmWQUAfkQpFwR kfWC4s+3WJcALstmibpj3jtKYh1kcYfH2kqsH61JHAD+tPQpyWh8mSc82g7DAhHnojGXeaf6WMC Xb+2fE8KFThf8Uy73LeN4i8Hw/dMg0u+EX3FT60MXAD7B70OhBQ7lw0vioc/7QVPznyJ+HCqWbX DOAZIrM8InqKiTEb6/5mtJZ2vWNfHGCazCHkyz5P7F/Qcx/9CvjQVMfBpnMiV1lyXeXmqywglyx QvC3TiWcrxjva6K0zLs+clv17shzteHr7RBG5slko7Cwi7rg0 X-Received: by 2002:a05:7022:439b:b0:11b:9386:a3c5 with SMTP id a92af1059eb24-12741bebf03mr5406389c88.48.1771332687825; Tue, 17 Feb 2026 04:51:27 -0800 (PST) X-Received: by 2002:a05:7022:439b:b0:11b:9386:a3c5 with SMTP id a92af1059eb24-12741bebf03mr5406377c88.48.1771332687205; Tue, 17 Feb 2026 04:51:27 -0800 (PST) Received: from [10.218.16.122] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12742c64282sm17876010c88.5.2026.02.17.04.51.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Feb 2026 04:51:26 -0800 (PST) Message-ID: Date: Tue, 17 Feb 2026 18:21:19 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/2] Bluetooth: qca: add QCC2072 support To: Krzysztof Kozlowski Cc: Dmitry Baryshkov , Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Balakrishna Godavarthi , Rocky Liao , quic_mohamull@quicinc.com, quic_hbandi@quicinc.com, janaki.thota@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260217054731.3058567-1-vivek.sahu@oss.qualcomm.com> <20260217054731.3058567-3-vivek.sahu@oss.qualcomm.com> <19d3cced-f630-4a6b-853e-3798487fd769@oss.qualcomm.com> <20260217-mighty-organic-oxpecker-2ed848@quoll> Content-Language: en-US From: Vivek Sahu In-Reply-To: <20260217-mighty-organic-oxpecker-2ed848@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=bqVBxUai c=1 sm=1 tr=0 ts=69946450 cx=c_pps a=JYo30EpNSr/tUYqK9jHPoA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=IBWEejItevxuk87JBWgA:9 a=QEXdDO2ut3YA:10 a=Fk4IpSoW4aLDllm1B1p-:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjE3MDEwNiBTYWx0ZWRfX8CzhgNWYiADt jO3ljpUEW/JNSxDiYu3x3/WJGc2uryu1sn3NiWpXJVnLB0Q4qRLfKrVFMpQWxIhf2W9eDKm5LsM szj9grtMMNWXc4purxmWcaIeQZFeQa6mcs2cY8MEKzCKaGkmFX8i9MO9XaTAZm0tuCnHkRU8Caw Bi7Phv7P32HZglBe+aeXhjJFsGhRB67tW/5534eAEis995M6lBrOayBOXcHDVc6W2lda/JnFD/I akN3oMoKrNknQSeH5w+fzMgZg2BLg2KFf1/X4VsNXugHSNfj24TZNx+qOH0sKFwyTg0KDfzErYG 925w93JQyUXwd70MUXA62f7tiLcry7ro0yS4eAYM05c/9w9j8AlzC0RaB+zqVrHVXprsvi3EMhk pZZiwCEPhQprYc1EM2+gC1mGDv9XEhmFVtMxH4NBUgemARfYv63bDodZGJMwRBAdKyw7LrpAtFK VYd8SB8hYfT+qaf7duQ== X-Proofpoint-GUID: c4ul5fCozN_JqwYgZF3XhLIhxXoLnbLU X-Proofpoint-ORIG-GUID: c4ul5fCozN_JqwYgZF3XhLIhxXoLnbLU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-17_01,2026-02-16_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 spamscore=0 adultscore=0 phishscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602170106 On 2/17/2026 1:23 PM, Krzysztof Kozlowski wrote: > On Tue, Feb 17, 2026 at 01:17:29PM +0530, Vivek Sahu wrote: >>>> + case QCA_QCC2072: >>>> + snprintf(config.fwname, sizeof(config.fwname), >>>> + "qca/ornnv%02x.bin", rom_ver); >>>> + break; >>>> case QCA_WCN3950: >>>> if (le32_to_cpu(ver.soc_id) == QCA_WCN3950_SOC_ID_T) >>>> variant = "t"; >>>> diff --git a/drivers/bluetooth/btqca.h b/drivers/bluetooth/btqca.h >>>> index 8f3c1b1c77b3..a175ac31e7b2 100644 >>>> --- a/drivers/bluetooth/btqca.h >>>> +++ b/drivers/bluetooth/btqca.h >>>> @@ -158,6 +158,7 @@ enum qca_btsoc_type { >>>> QCA_WCN6750, >>>> QCA_WCN6855, >>>> QCA_WCN7850, >>>> + QCA_QCC2072, >>> >>> Why not keep it sorted? >>> >> As mentioned in the cover letter "qca_btsoc_type" enum in >> drivers/bluetooth/btqca.h contains all the soc type which need to be enabled >> for BT enablement on the target device. There are few places where logic of >> framing packets transferring between SoC and Host depends on the which >> generation of the chip it is, refer api "qca_read_soc_version". So It is not >> sorted in btqca.h file. > > Neither in previous patch comments nor here you respond to actual > comment. You just write something completely irrelevant. > > I don't think any of this should be considered if you are not > responding to actual comments. > > > Best regards, > Krzysztof > There is high impact on the existing design if i make this enum sorted. We are considering your comments regarding sorting for next commit not for this commit. Can we have approval for this commit if all other changes looks fine.