From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 16F821EA71 for ; Mon, 18 Dec 2023 15:59:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E17D82F4; Mon, 18 Dec 2023 08:00:31 -0800 (PST) Received: from [10.57.75.230] (unknown [10.57.75.230]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AE9893F5A1; Mon, 18 Dec 2023 07:59:45 -0800 (PST) Message-ID: Date: Mon, 18 Dec 2023 15:59:45 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 11/39] mm/userfaultfd: page_add_file_rmap() -> folio_add_file_rmap_pte() Content-Language: en-GB To: David Hildenbrand , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu References: <20231211155652.131054-1-david@redhat.com> <20231211155652.131054-12-david@redhat.com> From: Ryan Roberts In-Reply-To: <20231211155652.131054-12-david@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/12/2023 15:56, David Hildenbrand wrote: > Let's convert mfill_atomic_install_pte(). > > Reviewed-by: Yin Fengwei > Signed-off-by: David Hildenbrand Reviewed-by: Ryan Roberts > --- > mm/userfaultfd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c > index 9ec814e47e99..330a481a1654 100644 > --- a/mm/userfaultfd.c > +++ b/mm/userfaultfd.c > @@ -114,7 +114,7 @@ int mfill_atomic_install_pte(pmd_t *dst_pmd, > /* Usually, cache pages are already added to LRU */ > if (newly_allocated) > folio_add_lru(folio); > - page_add_file_rmap(page, dst_vma, false); > + folio_add_file_rmap_pte(folio, page, dst_vma); > } else { > page_add_new_anon_rmap(page, dst_vma, dst_addr); > folio_add_lru_vma(folio, dst_vma);