From: Johannes Berg <johannes@sipsolutions.net>
To: Remi Pommarel <repk@triplefau.lt>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 wireless-next 2/3] wifi: mac80211: Correctly init MLO link in ieee80211_8023_xmit()
Date: Tue, 22 Jul 2025 14:25:33 +0200 [thread overview]
Message-ID: <cdc17da890c87dc2dd6e521197594f1be1eb0a03.camel@sipsolutions.net> (raw)
In-Reply-To: <a62f4c066c967c954648a409e5e1fa185d6edeb6.1752225123.git.repk@triplefau.lt>
On Fri, 2025-07-11 at 12:03 +0200, Remi Pommarel wrote:
> The IEEE80211_TX_CTRL_MLO_LINK info is the only part of
> ieee80211_tx_control where a 0 value has a specific meaning. Thus this
> should always be initialized with IEEE80211_LINK_UNSPECIFIED if there is
> no MLO link information associated with the skb, even using when 802.11
> hw encap offloading.
I'm not against this and the patch looks fine, but I guess I'm surprised
it even matters to anyone. The encap offloading fundamentally requires
that the driver do more work to identify the destination STA, and then
anyway the link is picked by driver/FW? Or is there a case of encap
offload with _multicast_?
Anyway, looks OK and just sets a few bits that I feel like it's weird
that they're even used, so doesn't matter :)
johannes
next prev parent reply other threads:[~2025-07-22 12:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 10:03 [RFC PATCH v2 wireless-next 0/3] Allow non-MLD sta to roam between MLD AP links Remi Pommarel
2025-07-11 10:03 ` [RFC PACTH v2 wireless-next 1/3] wifi: mac80211: Get link_id from freq for received management frame Remi Pommarel
2025-07-22 12:22 ` Johannes Berg
2025-07-11 10:03 ` [RFC PATCH v2 wireless-next 2/3] wifi: mac80211: Correctly init MLO link in ieee80211_8023_xmit() Remi Pommarel
2025-07-22 12:25 ` Johannes Berg [this message]
2025-07-11 10:03 ` [RFC PATCH v2 wireless-next 3/3] wifi: mac80211: Check link id at station removal Remi Pommarel
2025-07-22 12:26 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdc17da890c87dc2dd6e521197594f1be1eb0a03.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=repk@triplefau.lt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®