From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C414C433DF for ; Wed, 19 Aug 2020 01:49:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 82BF320772 for ; Wed, 19 Aug 2020 01:49:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726879AbgHSBtq convert rfc822-to-8bit (ORCPT ); Tue, 18 Aug 2020 21:49:46 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:46284 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726372AbgHSBtp (ORCPT ); Tue, 18 Aug 2020 21:49:45 -0400 Received: from dggeme751-chm.china.huawei.com (unknown [172.30.72.53]) by Forcepoint Email with ESMTP id A45ED5EB70E9F5F51687; Wed, 19 Aug 2020 09:49:43 +0800 (CST) Received: from dggeme753-chm.china.huawei.com (10.3.19.99) by dggeme751-chm.china.huawei.com (10.3.19.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1913.5; Wed, 19 Aug 2020 09:49:42 +0800 Received: from dggeme753-chm.china.huawei.com ([10.7.64.70]) by dggeme753-chm.china.huawei.com ([10.7.64.70]) with mapi id 15.01.1913.007; Wed, 19 Aug 2020 09:49:43 +0800 From: linmiaohe To: David Miller CC: "kuba@kernel.org" , "edumazet@google.com" , "kafai@fb.com" , "ast@kernel.org" , "jakub@cloudflare.com" , "zhang.lin16@zte.com.cn" , "keescook@chromium.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] net: Avoid strcmp current->comm with warncomm when warned >= 5 Thread-Topic: [PATCH] net: Avoid strcmp current->comm with warncomm when warned >= 5 Thread-Index: AdZ1ytv+wdP6UYOgWUmWGFIMW1oMuA== Date: Wed, 19 Aug 2020 01:49:43 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.174.176.142] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Miller wrote: >From: Miaohe Lin >Date: Tue, 18 Aug 2020 07:41:32 -0400 > >> @@ -417,7 +417,7 @@ static void sock_warn_obsolete_bsdism(const char >> *name) { >> static int warned; >> static char warncomm[TASK_COMM_LEN]; >> - if (strcmp(warncomm, current->comm) && warned < 5) { >> + if (warned < 5 && strcmp(warncomm, current->comm)) { >> strcpy(warncomm, current->comm); >> pr_warn("process `%s' is using obsolete %s SO_BSDCOMPAT\n", >> warncomm, name); > >We've been warning about SO_BSDCOMPAT usage for almost 20 years, I think we can remove this code completely now. Looks sane. Will do. Many thanks.