mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jie Luo <quic_luoj@quicinc.com>
To: Christian Marangi <ansuelsmth@gmail.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Andrew Lunn <andrew@lunn.ch>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Robert Marko <robert.marko@sartura.hr>,
	<linux-arm-msm@vger.kernel.org>, <netdev@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Sergey Ryazanov <ryazanov.s.a@gmail.com>
Subject: Re: [net-next PATCH 0/3] net: mdio-ipq4019: fix wrong default MDC rate
Date: Mon, 29 Jan 2024 21:59:03 +0800	[thread overview]
Message-ID: <cdd0e481-2738-465b-9ef8-b7ab79981fbe@quicinc.com> (raw)
In-Reply-To: <65b3ecd7.050a0220.9e26c.0d9e@mx.google.com>



On 1/27/2024 1:33 AM, Christian Marangi wrote:
> On Fri, Jan 26, 2024 at 07:20:03PM +0200, Dmitry Baryshkov wrote:
>> On Fri, 26 Jan 2024 at 18:03, Jie Luo <quic_luoj@quicinc.com> wrote:
>>>
>>>
>>>
>>> On 1/26/2024 1:18 AM, Andrew Lunn wrote:
>>>>> Hi Christian,
>>>>> Just a gentle reminder.
>>>>>
>>>>> The MDIO frequency config is already added by the following patch series.
>>>>> https://lore.kernel.org/netdev/28c8b31c-8dcb-4a19-9084-22c77a74b9a1@linaro.org/T/#m840cb8d269dca133c3ad3da3d112c63382ec2058
>>>>
>>>> I admit this version was posted first. However, its embedded in a
>>>> patch series which is not making much progress, and i doubt will make
>>>> progress any time soon.
>>>>
>>>> If you really want your version to be used, please split it out into a
>>>> standalone patch series adding just MDIO clock-frequency support, with
>>>> its binding, and nothing else.
>>>>
>>>>       Andrew
>>>
>>> Hi Andrew,
>>> We will rework the patch series to include only MDIO frequency related
>>> function and frequency dt binding, and post the updated patch series
>>> on th/Tuesdae Mondayy of next week. We will work with Christian to
>>> ensure he can re-use this patch as well.
>>
>> Can you do the other way around: rebase your patches on top of Chritian's work?

Hi Dmitry,
Sure, we can take this approach if fine by Andrew as well.

>>
> 
> Would be ideal, also I have to send v2 that handle the 802.3 suggested
> MDC rate (ready I just need to send after this has been handled).
> 
> Also I can see some problem with Lui patch where thse divior
> value is not reapplied after MDIO reset effectively reverting to the
> default value.

Hi Christian,
In my version, the divisor is programmed in every MDIO operation and 
hence I did not add the code to revert to configured value in reset 
function. But sure. we can program it once during the probe/reset and 
avoid doing it during read/write ops.

In addition, the MDIO divisor 1, 2 and 4 are not supported by the MDIO
hardware block, maybe we can remove these macros to avoid confusion, or 
add a comment mentioning that these are not supported.

> 
> If it's a credits problem I can totally change the from or add
> Co-devloped, I just need the feature since the thing is broken from a
> looong time on ipq40xx and ipq807x.
> 

  reply	other threads:[~2024-01-29 13:59 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24 21:36 Christian Marangi
2024-01-24 21:36 ` [net-next PATCH 1/3] dt-bindings: net: ipq4019-mdio: document now supported clock-frequency Christian Marangi
2024-01-24 22:23   ` Andrew Lunn
2024-01-24 22:27     ` Christian Marangi
2024-01-24 22:38       ` Andrew Lunn
2024-01-26 11:47   ` Krzysztof Kozlowski
2024-01-24 21:36 ` [net-next PATCH 2/3] net: mdio: ipq4019: add support for clock-frequency property Christian Marangi
2024-01-24 21:36 ` [net-next PATCH 3/3] arm64: dts: qcom: ipq8074: add clock-frequency to MDIO node Christian Marangi
2024-01-25  5:57 ` [net-next PATCH 0/3] net: mdio-ipq4019: fix wrong default MDC rate Jie Luo
2024-01-25 11:36   ` Christian Marangi
2024-01-25 17:18   ` Andrew Lunn
2024-01-26 16:03     ` Jie Luo
2024-01-26 17:20       ` Dmitry Baryshkov
2024-01-26 17:33         ` Christian Marangi
2024-01-29 13:59           ` Jie Luo [this message]
2024-01-29 14:25             ` Christian Marangi
2024-01-29 15:29               ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdd0e481-2738-465b-9ef8-b7ab79981fbe@quicinc.com \
    --to=quic_luoj@quicinc.com \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=ansuelsmth@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robert.marko@sartura.hr \
    --cc=robh+dt@kernel.org \
    --cc=ryazanov.s.a@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®