From: Jens Axboe <axboe@kernel.dk>
To: Shaohua Li <shli@fb.com>, LKML <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>, Tejun Heo <tj@kernel.org>,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH V2] kthread: zero the kthread data structure
Date: Tue, 7 Nov 2017 12:45:38 -0700 [thread overview]
Message-ID: <cdd1e91b-941f-728d-6be0-34d4886e8d31@kernel.dk> (raw)
In-Reply-To: <e00c78e6161ef7759a7e5f6abd2db84b9bcc8cf4.1510081552.git.shli@fb.com>
On 11/07/2017 12:09 PM, Shaohua Li wrote:
> kthread() could bail out early before we initialize blkcg_css (if the
> kthread is killed very early. Please see xchg() statement in kthread()),
> which confuses free_kthread_struct. Instead of moving the blkcg_css
> initialization early, we simply zero the whole 'self' data structure,
> which doesn't sound much overhead.
Applied, thanks Shaohua.
--
Jens Axboe
prev parent reply other threads:[~2017-11-07 19:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-07 19:09 Shaohua Li
2017-11-07 19:32 ` Tejun Heo
2017-11-07 19:45 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdd1e91b-941f-728d-6be0-34d4886e8d31@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=shli@fb.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®