From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754000AbcHZSMm (ORCPT ); Fri, 26 Aug 2016 14:12:42 -0400 Received: from mout.web.de ([212.227.17.12]:53395 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751449AbcHZSMk (ORCPT ); Fri, 26 Aug 2016 14:12:40 -0400 Subject: [PATCH 4/5] ia64/mm/tlb: Use kmalloc_array() in ia64_itr_entry() To: linux-ia64@vger.kernel.org, Fenghua Yu , Tony Luck References: <349bbfb4-bada-628e-2981-ca2a315299fc@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: Date: Fri, 26 Aug 2016 20:05:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <349bbfb4-bada-628e-2981-ca2a315299fc@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:SlVTxtQyEpNCq0yXnib/79C/QGjPtG9MLdQPYP6k15tfMu3dQ34 hWlAu5H8pyU+HUo1Eltq7sEU2fYBxvbKVFi35dHW/enxolLqwcvwwS3GUFzG16t1wYD8QAp LdNDLCX2Ct9486VG5hr7hemrieeIMZs/KkHYmrlFM4qBS0iAE3+o6MFVTlOhVhHm4CeT/lK 3TCfAaJodI17g8ityYpfA== X-UI-Out-Filterresults: notjunk:1;V01:K0:5AJvbEIht0I=:NusuIrd+h/M7EuIMyX+94X Q1teBTiScmXg4kRIHA1VAH3WtKRyaNj/QJHz9ohHVOZ1gIbkEnslXEXqn5tI91hLPFqdUE6bl 47cb9ub8Ix6YtVHADUxfjcrrS0L5xDEwEZ8QvTNfCXcduRUpNLn6aawaMynMnL8va+BovYd/G rdz5SQI25FSSZL+bXm80VmSjmE5al2ROAogMwsCOk917wz+Yd60s3ts2DeimQGrZ5nqC95jik 5XrSjFgjwFq7hRRrJaqDeZoOZ36+EwvkMHoXynrGJaQS9a9VybLYP65LVfLPp+9dfBIfRMpmG aIykWWcfYDG++r9aM2r/LXJV4O8lu8pZCoh4uDvoEXgaKRb/q3b/+G32CVj+c+clvqCsrh8ea x/BMRzFkj6Of6/jePDqhbhwWaQPjqThkqVt8s/JDh0Q1yVGGipSK6cUZocvLzdRcnd7fpLqDj dBFDQ1A/vMhFL3k2vvD38I9IcdI+uvSxdcPvajBONFkuYAkKz55s7aHYHmbB9DECSsnrXymVb AD/2ZHyigiaBl06dPWso1bE2kHtghNGpExt/mfOpSGS812U7kS3k9AQ2vCEJDaCJn0HP14o+3 upB4KurAkzCRLTxFHNDsKc7e2m1HpA/97JDcJA+Ft4ybbG1p20QtIM+mEIH+XTgLypoL9RFlW tcl+0WoQn/JyIQcrO/qysaPKOdu55YT+1Ps7gKCPPn4H64+Uhav8YDXfafdMUp7G5ST15XYqj UKdx/JMlFc58aebXzJOBB3MB9FQ0KCkKk5eY+M5zEBSLgDltI38S8wi4p6mFUtWu9wkyeJfPX kpWjA7G Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 26 Aug 2016 19:43:34 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/ia64/mm/tlb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/ia64/mm/tlb.c b/arch/ia64/mm/tlb.c index 6d2f83d..30870d1 100644 --- a/arch/ia64/mm/tlb.c +++ b/arch/ia64/mm/tlb.c @@ -429,8 +429,9 @@ int ia64_itr_entry(u64 target_mask, u64 va, u64 pte, u64 log_size) int cpu = smp_processor_id(); if (!ia64_idtrs[cpu]) { - ia64_idtrs[cpu] = kmalloc(2 * IA64_TR_ALLOC_MAX * - sizeof (struct ia64_tr_entry), GFP_KERNEL); + ia64_idtrs[cpu] = kmalloc_array(2 * IA64_TR_ALLOC_MAX, + sizeof(*ia64_idtrs[cpu]), + GFP_KERNEL); if (!ia64_idtrs[cpu]) return -ENOMEM; } -- 2.9.3