From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753073AbdBCXHR (ORCPT ); Fri, 3 Feb 2017 18:07:17 -0500 Received: from 14.mo7.mail-out.ovh.net ([178.33.251.19]:32924 "EHLO 14.mo7.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753009AbdBCXHP (ORCPT ); Fri, 3 Feb 2017 18:07:15 -0500 X-Greylist: delayed 5046 seconds by postgrey-1.27 at vger.kernel.org; Fri, 03 Feb 2017 18:07:15 EST MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 03 Feb 2017 22:48:15 +0100 From: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= To: Jon Mason Cc: David Miller , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] net: ethernet: bgmac: unify code of the same family In-Reply-To: <1486157970-6315-3-git-send-email-jon.mason@broadcom.com> References: <1486157970-6315-1-git-send-email-jon.mason@broadcom.com> <1486157970-6315-3-git-send-email-jon.mason@broadcom.com> Message-ID: User-Agent: Roundcube Webmail/1.2.3 X-Originating-IP: 194.187.74.233 X-Webmail-UserID: rafal@milecki.pl X-Ovh-Tracer-Id: 18060560409599708903 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeelgedrjedugdduheduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddm Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-02-03 22:39, Jon Mason wrote: > BCM471X and BCM535X are of the same family (from what I can derive from > internal documents). Group them into the case statement together, > which > results in more code reuse. > > Also, use existing helper variables to make the code a little more > readable too. > > Signed-off-by: Jon Mason I'd like to review it / test it on few devices. Please give me weekend for that.