From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CB5C38BF9A for ; Mon, 8 Jun 2026 10:40:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780915229; cv=none; b=OfPjY9Fcwb8kOAcy7cjgsuNtsz3JQebM38qpsaeqK/3hHx/dEa0CKcIlFbM4t8Y9ShXAoMRMt9PMues7YVPO8yEn43RlhMQIhr1BCC5f7/QvKl8LVa+1Hbaxr2D756iezmB0IDs0AJBJng9CD4XXj04SQdVrbEHyIzIf6+xKn7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780915229; c=relaxed/simple; bh=mVvTmTFwOrEZPN7LSlVxRMK7dPOvMgDe6crr2ypA51s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KrKZsVy5E+IgMtQzgAPO8LNZwbIX+dDZHcdob8g6+tPwftBviJmjtLSGTrVaptQmKdvOPKwB/vadxptLs/9eein52D/Fjb8MnnUFwdKwQ3a1dtSRTZZeuAA6ExO9ocEaCqxczr9AMmcb1KKTOgp22Z21u+02Qa2VDDICZtVY8iA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Xh/NHPl8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HV5Tx1xU; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Xh/NHPl8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HV5Tx1xU" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6586Ro2Z2834269 for ; Mon, 8 Jun 2026 10:40:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tveSNRQ+h6fN2eRH75FNEmJTO0yYAeUsEKQ0M1WDmbc=; b=Xh/NHPl8SuBYxP6X caNzrzGEU4RACsw9uhw+2TwPnuajGd9102JDEiZeiZ7bucvwXPV1rRBsQ3CzdHUf n5RFO7d3CvX3uTOIqyVgWNQEVCwDDkJ9JeGeI9Xc/oU0wr3eehmyRA+k5ssidZS9 UmzCA5I1RCChgGLmbFMoXEbvWNmZKgHzVFlGCHaO3owwK+fTGK4Yaz8HqyXP6V9p KIpvWBLYn7cdfz5oeWOqlxuMLiqPO/ADJC17v1NE//qGiBWfIMjcmFue2G1+FMf6 T+c2uMliiCR+aqePeDyJHfPJerRlUFyEWdd0rJNla5wX6P1IRU4XqpwOu6OTEs+C UoWB5Q== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4emaj4ypvb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Jun 2026 10:40:27 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-915a4ca0a4aso135476985a.1 for ; Mon, 08 Jun 2026 03:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780915226; x=1781520026; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tveSNRQ+h6fN2eRH75FNEmJTO0yYAeUsEKQ0M1WDmbc=; b=HV5Tx1xUYzWg7SG3VpMih8AOqgUbJuqIymxWZl4omPPcH9w7+ys36mSKnnFypS4NZ+ ujzZPtvwFf6B2o/WKrWiIhJdx6y69sBUzks9b4AtkBmYe//r1M6VHAzWjNMUx9xHXFgt qU6R6KpgWFcqf5db3ceihkBVNXsdsrLjMA9FmDgqBe342w58enNjdChGaZgI1cUOx47E mP0ZgxsdX2mURPcyDZUbRXhUPBNP6RcsTKXbz0HnyCAFLRPNbVwOaGrzk1t0OtbrCz5j o+8UuRidi/sZJcrrYAG75cI8D5pXY+dEm/6wbhIxbTQEszsELwoQvO06ct7F0qSBDXJY 8RNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780915226; x=1781520026; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tveSNRQ+h6fN2eRH75FNEmJTO0yYAeUsEKQ0M1WDmbc=; b=J/vFo6ZqbWZaVqK2noa/F/XjNAG8MdpjrioeaTSUJKuRRfumkpCghtX5kZEIdMQ/4c xb6qV8OypDjLuqvyFQcO9cp9dFdwmuDM1GE0gaP8hTCDxyTg8kr8OnpwPN4Eo0Me2feX r3HPqSNbhKwX2ZlDb60W9z+MLkKR1lMBi2CKz2Xe9qyJBMUtN8Lfg33s1VarhF3vs/iz IjK+HOV+QlCTyGnwAU33cFI2YneqxYzV3jUgAYj0jPHATWCKBEypH2DQ34LBpf09/LoG moE72X9VfIEMM2S3v7GKvTI1kbnhSAeJd/JkwawJ/i/oX2mcE6DgEiwV4dsoWwDFERci NTTg== X-Forwarded-Encrypted: i=1; AFNElJ/JNviunDzgxSpYmWjR/5yB0tU8P7LNw83TaqWBfnsO6M2asn1irlECgACviy+7oBFksudNQl4g7chZIlY=@vger.kernel.org X-Gm-Message-State: AOJu0YywIsJFIsf8j4gjA/eG0PMMkjM440W8vk9dd6fQtPy2JWDmXQn5 sdUkiF19TXri/c33kLtFUzKn2gn7bYkkoHdDkHa22xf5QHEo3muMhGD2+cbiePF9XtP3v7+Ugck q+FpDSE0CGVA62aR56ZJNKhOesvF6/NZycEaaioflu4hgtRJ85sRsL+j5eIiS1V3MfZVn6FUtTb o= X-Gm-Gg: Acq92OF2dK0nEzVah2ftrD6HH/moX/GakgDpjD2xztKlcV2Jbf+c6uykt7yxOjqmWSY dTZtMN6ny07jhMtOwf+PBUEIY9Qmuz3qU1mHWQ000TDrGfgr7D+nLrtCpMQtsJjk+ewmT8hJybe RmA5iL4wUCxV4FpxmfN7AfDSKY0wvxLdKWgF9a8egxeqvaqhTSNrk1sztyXXQFa1Z/knwMgd64A T4Oqq60TN6B8eLH+32GUGDBQvEeOHpQ+bEKG4Y3BehFFCm8qXKCUp6stGp81/qYPYqc7Yjc8Bpj 0WKGM0jejHc6qVcjT5o2D2ZhT/Vkuh4Y6hLADzSd8TW+cBG9K8ZLfCtupY7XcRRxP5JK4IzmuX2 lcuseYdpNdIzKM3FZ9j9KhLpSAC/SQ++6gEr6EyTqG0xVA6+8ZG4JtvC+ X-Received: by 2002:a05:620a:28cc:b0:915:4ca0:1210 with SMTP id af79cd13be357-915a9d9a69emr1477146185a.3.1780915226537; Mon, 08 Jun 2026 03:40:26 -0700 (PDT) X-Received: by 2002:a05:620a:28cc:b0:915:4ca0:1210 with SMTP id af79cd13be357-915a9d9a69emr1477142585a.3.1780915226033; Mon, 08 Jun 2026 03:40:26 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68e65868049sm6890844a12.24.2026.06.08.03.40.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jun 2026 03:40:24 -0700 (PDT) Message-ID: Date: Mon, 8 Jun 2026 12:40:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/6] soc: qcom: rpmh-rsc: Skip TCS init when RSC is managed by firmware To: Gekko , linux-arm-msm@vger.kernel.org, Maulik Shah Cc: andersson@kernel.org, konradybcio@kernel.org, robin.clark@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260522060645.4399-1-graham.oconnor@gmail.com> <20260522060645.4399-2-graham.oconnor@gmail.com> <934e6039-4639-49bd-8cf9-a1674f86b8c8@oss.qualcomm.com> <4b911ed0-64b1-48aa-a00f-e2ade66afa1c@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <4b911ed0-64b1-48aa-a00f-e2ade66afa1c@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: djozWHxM5Sf4AI234zGYfHWZ89GYFlqN X-Proofpoint-GUID: djozWHxM5Sf4AI234zGYfHWZ89GYFlqN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA4MDEwMCBTYWx0ZWRfXxFWDO2utWvZO Cj5vHL/0EeHZ+l/7+UWA5YVPHgurYnqjGPPbvfGdxpCCjLGZ/6Qb/Vb6uYEItUbm3+m2A4uo2vB 4cjHdFHvksk4wZrXwBNgDsFUFwcePkYAmuFeq0caCF9RNQwul58jbL8ATInXs2EYnuR0e6NeLI6 9xwu4pRuuEe6Y5DbnYWPzc5mR2daDptPRYS17Gek4Ax9Po2x2hqc1csx+xEwXSfiyqFJOIFabp3 /lM4g5GlTxEPvEF+N01hbn4XEq8NKZ1GYkfkACszl4hXf0aaFS/gHZ2IhNWb3M9g4xTj30bIi8g W9gxZdU9QXAQonncWkRMajbBB6aV+e18d12VSI0MLDEsvhwJojNB2UyJJszbCd+mK7Y/V5UvVAg E/HQFAr38GkFJNDq+we6PB7YtoQUhl4v9xv2RZ3GArWyNtPHosmYWoeRwSWd3AzhLps+xrP3mzU JWEKigd12Oe/oGFK70Q== X-Authority-Analysis: v=2.4 cv=TLh1jVla c=1 sm=1 tr=0 ts=6a269c1b cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=dIxFNMqCpUz1sDLjZpAA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-08_02,2026-06-05_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 spamscore=0 adultscore=0 clxscore=1015 phishscore=0 malwarescore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606080100 On 5/27/26 10:30 PM, Gekko wrote: > Hi Konrad, > > This one is confusing. > > I started the bring-up on this board on gentoo-sources 6.18.18 but the board would not boot. After an almost subliminal flash of tux the board would lock every time.I found the solution from PostmarketOS who obviously faced the same issue which formed the genesis of this patch. With this patch applied the board booted fine so I've applied it ever since. > > However, as a result of your response here I tried booting my current kernel (gentoo-sources 7.0.10) without the patch and to my surprise it booted just fine. This leaves a few options, including: > 1) the kernel source has changed > 2) this is a firmware issue and a firmware update fixed it > 3) It's a timing issue. > > To eliminate 2 I would have to test 6.18.18 with the current firmware, then regress the firmware and test again. The do the same with 7.0.10. I can't honestly recall whether the firmware upgrade was before or after this issue first appeared. > > If it's a timing issue it's a bit more concerning. If the kernel is taking slightly longer to initialise before calling rpmh_probe_tcs_config() then it may just be missing the solver activation, everything appears to work and nobody is any the wiser. If the existing solver code doesn't deal with early firmware TCS initialisation then it could, under some circumstances, lead to the security reset that I was seeing. This patch specifically tests for that case. > > Based on the AI review feedback I've also modified the patch to not simply return early but to just skip the sensitive parts of the code to allow any other setup to complete normally. > > My current objective evidence is that the board boots without this patch and it's quite possible this patch is unnecessary if the above is incorrect. I would skew towards this being a firmware issue. But I'm interested in any findings you encounter. Maybe +Maulik could know more Konrad