From: Michal Simek <michal.simek@amd.com>
To: <linux-kernel@vger.kernel.org>, <monstr@monstr.eu>,
<michal.simek@xilinx.com>, <git@xilinx.com>
Cc: David Heidelberg <david@ixit.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Harini Katakam <harini.katakam@amd.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michael Grzeschik <m.grzeschik@pengutronix.de>,
Michael Tretter <m.tretter@pengutronix.de>,
Piyush Mehta <piyush.mehta@xilinx.com>,
Rob Herring <robh+dt@kernel.org>,
Robert Hancock <robert.hancock@calian.com>,
Sean Anderson <sean.anderson@seco.com>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: zynqmp: Remove clock-names from GEM in zynqmp-clk-ccf.dtsi
Date: Thu, 5 Jan 2023 09:52:38 +0100 [thread overview]
Message-ID: <cdd7e3ca-0837-c3c1-e5f8-751909d687a3@amd.com> (raw)
In-Reply-To: <24ce27f91a55ed04ca7ee2ff7db0c674702ef722.1670594284.git.michal.simek@amd.com>
On 12/9/22 14:58, Michal Simek wrote:
> Remove clock-names from GEM nodes from clk-ccf because they should be only
> present in zynqmp.dtsi. And as is visible both clock-names defined didn't
> really match.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
>
> arch/arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi | 4 ----
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 8 ++++----
> 2 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi
> index e172fa05c9a0..3e9979ab60bb 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi
> @@ -135,28 +135,24 @@ &gem0 {
> clocks = <&zynqmp_clk LPD_LSBUS>, <&zynqmp_clk GEM0_REF>,
> <&zynqmp_clk GEM0_TX>, <&zynqmp_clk GEM0_RX>,
> <&zynqmp_clk GEM_TSU>;
> - clock-names = "pclk", "hclk", "tx_clk", "rx_clk", "tsu_clk";
> };
>
> &gem1 {
> clocks = <&zynqmp_clk LPD_LSBUS>, <&zynqmp_clk GEM1_REF>,
> <&zynqmp_clk GEM1_TX>, <&zynqmp_clk GEM1_RX>,
> <&zynqmp_clk GEM_TSU>;
> - clock-names = "pclk", "hclk", "tx_clk", "rx_clk", "tsu_clk";
> };
>
> &gem2 {
> clocks = <&zynqmp_clk LPD_LSBUS>, <&zynqmp_clk GEM2_REF>,
> <&zynqmp_clk GEM2_TX>, <&zynqmp_clk GEM2_RX>,
> <&zynqmp_clk GEM_TSU>;
> - clock-names = "pclk", "hclk", "tx_clk", "rx_clk", "tsu_clk";
> };
>
> &gem3 {
> clocks = <&zynqmp_clk LPD_LSBUS>, <&zynqmp_clk GEM3_REF>,
> <&zynqmp_clk GEM3_TX>, <&zynqmp_clk GEM3_RX>,
> <&zynqmp_clk GEM_TSU>;
> - clock-names = "pclk", "hclk", "tx_clk", "rx_clk", "tsu_clk";
> };
>
> &gpio {
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 233127d94204..518a3d98b4b9 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -512,7 +512,7 @@ gem0: ethernet@ff0b0000 {
> interrupt-parent = <&gic>;
> interrupts = <0 57 4>, <0 57 4>;
> reg = <0x0 0xff0b0000 0x0 0x1000>;
> - clock-names = "pclk", "hclk", "tx_clk";
> + clock-names = "pclk", "hclk", "tx_clk", "rx_clk", "tsu_clk";
> #address-cells = <1>;
> #size-cells = <0>;
> iommus = <&smmu 0x874>;
> @@ -527,7 +527,7 @@ gem1: ethernet@ff0c0000 {
> interrupt-parent = <&gic>;
> interrupts = <0 59 4>, <0 59 4>;
> reg = <0x0 0xff0c0000 0x0 0x1000>;
> - clock-names = "pclk", "hclk", "tx_clk";
> + clock-names = "pclk", "hclk", "tx_clk", "rx_clk", "tsu_clk";
> #address-cells = <1>;
> #size-cells = <0>;
> iommus = <&smmu 0x875>;
> @@ -542,7 +542,7 @@ gem2: ethernet@ff0d0000 {
> interrupt-parent = <&gic>;
> interrupts = <0 61 4>, <0 61 4>;
> reg = <0x0 0xff0d0000 0x0 0x1000>;
> - clock-names = "pclk", "hclk", "tx_clk";
> + clock-names = "pclk", "hclk", "tx_clk", "rx_clk", "tsu_clk";
> #address-cells = <1>;
> #size-cells = <0>;
> iommus = <&smmu 0x876>;
> @@ -557,7 +557,7 @@ gem3: ethernet@ff0e0000 {
> interrupt-parent = <&gic>;
> interrupts = <0 63 4>, <0 63 4>;
> reg = <0x0 0xff0e0000 0x0 0x1000>;
> - clock-names = "pclk", "hclk", "tx_clk";
> + clock-names = "pclk", "hclk", "tx_clk", "rx_clk", "tsu_clk";
> #address-cells = <1>;
> #size-cells = <0>;
> iommus = <&smmu 0x877>;
Applied.
M
prev parent reply other threads:[~2023-01-05 8:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 13:58 Michal Simek
2023-01-05 8:52 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdd7e3ca-0837-c3c1-e5f8-751909d687a3@amd.com \
--to=michal.simek@amd.com \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=harini.katakam@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=m.tretter@pengutronix.de \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=piyush.mehta@xilinx.com \
--cc=robert.hancock@calian.com \
--cc=robh+dt@kernel.org \
--cc=sean.anderson@seco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®