From: Damien Le Moal <dlemoal@kernel.org>
To: Haoqian He <haoqian.he@smartx.com>,
Christoph Hellwig <hch@infradead.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
open list <linux-kernel@vger.kernel.org>,
"open list:SCSI SUBSYSTEM" <linux-scsi@vger.kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: fengli@smartx.com
Subject: Re: [PATCH 3/3] scsi: sd: remove some redundant initialization code
Date: Tue, 2 Jul 2024 12:33:52 +0900 [thread overview]
Message-ID: <cde0a2da-fae1-4f9f-b67f-f3906fc5cce6@kernel.org> (raw)
In-Reply-To: <20240702030118.2198570-4-haoqian.he@smartx.com>
On 7/2/24 12:01, Haoqian He wrote:
> Since the memory allocated by kzalloc for sdkp has been
> initialized to 0, the code that initializes some sdkp
> fields to 0 is no longer needed.
>
> Signed-off-by: Haoqian He <haoqian.he@smartx.com>
> Signed-off-by: Li Feng <fengli@smartx.com>
Looks OK to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2024-07-02 3:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 3:01 [PATCH 0/3] scsi: disable discard when set target full provisioning Haoqian He
2024-07-02 3:01 ` [PATCH 1/3] scsi: sd: " Haoqian He
2024-07-03 2:31 ` Martin K. Petersen
2024-07-02 3:01 ` [PATCH 2/3] scsi: sd: remove scsi_disk field lbpvpd Haoqian He
2024-07-02 3:30 ` Damien Le Moal
2024-07-02 3:01 ` [PATCH 3/3] scsi: sd: remove some redundant initialization code Haoqian He
2024-07-02 3:33 ` Damien Le Moal [this message]
2024-07-04 3:01 ` Haoqian He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cde0a2da-fae1-4f9f-b67f-f3906fc5cce6@kernel.org \
--to=dlemoal@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=fengli@smartx.com \
--cc=haoqian.he@smartx.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®