From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f51.google.com (mail-oa1-f51.google.com [209.85.160.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7A8B2836A0 for ; Fri, 22 May 2026 00:46:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779410803; cv=none; b=NjSHuXMA0WgpQkJ73voSG+HPhouIye/R0iaCJNXWXXE20XjWNcUYyOBmN2C9YZxtP6hOIoPFrafQ0E4pZNJcJv9Ic5l4CAbn6M9QchfL+NIwOGpjVXIXvFnkKroScrFiv32HhyNlkdjAqR07XFSaUbrl3TLtVQQWbnUCNg+aQN0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779410803; c=relaxed/simple; bh=4x7czOHP5J9Ubq78cdVef2P2g554A5FhbETYuc7w7SY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Np8rbPJHHKqKGehM78yiIOWQRg1laompReveYDh0lgp8sWPRXbNcxbgcpCZ6iUGLWo2Vrb9y/cW4jUiayQSw4Nb/vu+by453471EpqNvaYA3rMJYX9qNfvWHleLi08DLBhKBWJWgmkPw6MRgKSetuxR/oNIJP9/Ico3SA+kHkRw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=CvpqnL0g; arc=none smtp.client-ip=209.85.160.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="CvpqnL0g" Received: by mail-oa1-f51.google.com with SMTP id 586e51a60fabf-439c00ed7e0so6099260fac.0 for ; Thu, 21 May 2026 17:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1779410800; x=1780015600; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2kf2+EVW5FlP8qaF46nLBgeyzaD5UQgSJrYwMDiOrt4=; b=CvpqnL0gCYP7340jWPS+BwonqpLoajboOYlmq3Vg+yPIHLU1asQWQkiV98ra0D0tq0 8243e9FIScwgFFze1ZSiDSVTSNZPc/f2SKFHVNQMLiNp7ABfat+K65xxEN2yS8K0Zw4n 59BIxRuyUYflfOTnsYBND2HYdliqXRUZsEQ1tZ7YtLIdIIY9RRbUioLTOXxlIbIC36mp H5RDMzANnaCfTDe3Mkm41fqZWZOptQ8M6/BJ7MwczSxQ6phCa1d45xjxaBSmOsAalbKt cYeIhzMvVb4hi6ks+QQ+FwP0c4Bv0p3TVAYJ4PbmQw5f6PGzkOKZv3aaf7b2oiZEHPPy PwKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779410800; x=1780015600; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2kf2+EVW5FlP8qaF46nLBgeyzaD5UQgSJrYwMDiOrt4=; b=KEbwFD0juDLlzJ1qLOqB1e2NTZNcCI1JC/FpSXMhi5XndkZ3pczyKOAAskRFXm2WZs F1klv+A5LMs3wDAP4jivlQ3Css5sIM6VV5vEj2R+66cJ01TGa1LZcgJPu4/qtkSv+Mnb 6MnuxugiT2vlqG2s82PIK4/cC1KkLduo6mVO6Ytn1bbBuHC6HoMcDCnhnktBdaHZGeQc a/GSEpAbPRjFbpzgUo6aoXFOPMA7JUiBeXcYrv10EDKoWMOFp50HxYdTnGGSnQ3GvrC9 gDw7arZRVLuFgI6NDLHcT2Txy/BiBhXcsaC2rsNf+faeZJvu5iHfppsFZWydpuoZvwKQ f/1Q== X-Forwarded-Encrypted: i=1; AFNElJ8GVDXKTcuOccmTevfNUC8p5uLKyIvP+6x2GQg5TRzj2NoLtK2DhRGlpMwV27t7y5dh3n7gw/NmSt94x50=@vger.kernel.org X-Gm-Message-State: AOJu0YxffPZXb8Q33hg51N1JsAd8A91saIV5GiHcZiIWVJNQVtdQ9USJ VMTQ+eiXv4J9GYJKE4cwkzHRm2nCPo7aSlnuTZgNnbihjlcDoTyGaFYppfq308NesQY= X-Gm-Gg: Acq92OF9sKYkouDs6cyDU+RpPvGg5Yon0xkLM21xpSmYugG4wCrjaLU+rgX6miTBNb0 y4hlm6bQiqo8OSWxMbq/F4YP47ynVmTgJ3+ENlQcQqtxu6RPJ0Zel5P7dfZERsYIQqIp/VZazI0 F1OcyzvuAneF8/hnC1WbmBT2MPB0qIYDmg603G8UKXKyL4LGWtgP6gMTU+2GxvCrewkxUmZcR+N 1T2rC1h96kvi8c+Qfj3yOF/GVqA9403QCQsgSHQmEbm5UUHfJorct0h31WqdByLniTvOoI+BlvX /+mtxQ+cPP9hwOYtU9YKCiJ/u7LSpsxTGpyN2rAXxqoyMYMTykHB27IF18G7NY9ooisNvpPevE3 XfFlpPoaAn1go3YW/WATM1tl9XDjuXM98UcI12Z9CfRUYGZO8pfI1cM7qrHzOfUwl2COKLpI6Bp bAj1my4f8BLrlV8vRjhAj+EfGCFgina7Etx1Q+ujpPTh8JviEm1pnuxEeKbB7fiI7V+X47R69+v Q== X-Received: by 2002:a05:6870:c85:b0:43b:4f9c:8916 with SMTP id 586e51a60fabf-43b5aa8f2c8mr961740fac.11.1779410799700; Thu, 21 May 2026 17:46:39 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:569b:86c6:c367:5139? ([2600:8803:e7e4:500:569b:86c6:c367:5139]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43b635e373fsm314368fac.8.2026.05.21.17.46.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2026 17:46:39 -0700 (PDT) Message-ID: Date: Thu, 21 May 2026 19:46:37 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] gpio: adnp: use lock guards for the I2C lock To: Bartosz Golaszewski , Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski References: <20250306-gpiochip-set-conversion-v2-0-a76e72e21425@linaro.org> <20250306-gpiochip-set-conversion-v2-1-a76e72e21425@linaro.org> Content-Language: en-US From: David Lechner In-Reply-To: <20250306-gpiochip-set-conversion-v2-1-a76e72e21425@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/6/25 11:19 AM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Reduce the code complexity by using automatic lock guards with the I2C > mutex. > > Signed-off-by: Bartosz Golaszewski > --- ... > @@ -248,32 +232,24 @@ static irqreturn_t adnp_irq(int irq, void *data) > > for (i = 0; i < num_regs; i++) { > unsigned int base = i << adnp->reg_shift, bit; > - u8 changed, level, isr, ier; > + u8 changed, level = 0, isr = 0, ier = 0; > unsigned long pending; > int err; > > - mutex_lock(&adnp->i2c_lock); > + scoped_guard(mutex, &adnp->i2c_lock) { > + err = adnp_read(adnp, GPIO_PLR(adnp) + i, &level); > + if (err < 0) > + continue; I think this unintentionally changes the flow here. scoped_guard() is a for loop, so the continue now breaks out of the scoped_guard() rather than the outer for loop. > > - err = adnp_read(adnp, GPIO_PLR(adnp) + i, &level); > - if (err < 0) { > - mutex_unlock(&adnp->i2c_lock); > - continue; > + err = adnp_read(adnp, GPIO_ISR(adnp) + i, &isr); > + if (err < 0) > + continue; > + > + err = adnp_read(adnp, GPIO_IER(adnp) + i, &ier); > + if (err < 0) > + continue; > } > > - err = adnp_read(adnp, GPIO_ISR(adnp) + i, &isr); > - if (err < 0) { > - mutex_unlock(&adnp->i2c_lock); > - continue; > - } > - > - err = adnp_read(adnp, GPIO_IER(adnp) + i, &ier); > - if (err < 0) { > - mutex_unlock(&adnp->i2c_lock); > - continue; > - } > - > - mutex_unlock(&adnp->i2c_lock); > - > /* determine pins that changed levels */ > changed = level ^ adnp->irq_level[i]; >