mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-mips@vger.kernel.org,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
	Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	Ethan Nelson-Moore <enelsonmoore@gmail.com>,
	Eric Biggers <ebiggers@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mingyu Wang <25181214217@stu.xidian.edu.cn>,
	Robert Marko <robert.marko@sartura.hr>,
	"open list:WATCHDOG DEVICE DRIVERS"
	<linux-watchdog@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	manuel.lauss@gmail.com
Subject: Re: [PATCH 3/5] watchdog: gpio: Support watchdogs with a minimum heartbeat interval
Date: Mon, 19 Oct 2026 18:39:45 -0700	[thread overview]
Message-ID: <cde332c2-3628-4bac-9a4e-55d85fe06628@roeck-us.net> (raw)
In-Reply-To: <20261016221617.2223004-4-f.fainelli@gmail.com>

On Fri, Oct 16, 2026 at 03:16:15PM -0700, Florian Fainelli wrote:
> Read the optional hw-min-interval-ms property into min_hw_heartbeat_ms so
> the watchdog core defers keepalives that would toggle the GPIO too soon.
> Reject zero intervals and intervals at or above the hardware margin.
> Devices without the property retain their existing behavior.
> 
> Remove the arbitrary 65535 ms upper bound on hw_margin_ms as well. There
> is no register width to constrain this software interval, and the MTX-1
> watchdog needs a larger margin with a 1600 ms minimum ping interval.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Applied.

Thanks,
Guenter

  parent reply	other threads:[~2026-10-20  1:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 22:16 [PATCH 0/5] MTX-1 watchdog driver removal Florian Fainelli
2026-10-16 22:16 ` [PATCH 1/5] watchdog: gpio: Allow devices described by software nodes Florian Fainelli
2026-10-20  1:01   ` Guenter Roeck
2026-10-20  1:38   ` Guenter Roeck
2026-10-16 22:16 ` [PATCH 2/5] dt-bindings: watchdog: gpio: Describe minimum heartbeat intervals Florian Fainelli
2026-10-18 19:07   ` Conor Dooley
2026-10-20  1:01   ` Guenter Roeck
2026-10-20  1:38   ` Guenter Roeck
2026-10-16 22:16 ` [PATCH 3/5] watchdog: gpio: Support watchdogs with a minimum heartbeat interval Florian Fainelli
2026-10-20  1:01   ` Guenter Roeck
2026-10-20  1:39   ` Guenter Roeck [this message]
2026-10-16 22:16 ` [PATCH 4/5] MIPS: Alchemy: Use the GPIO watchdog driver on MTX-1 Florian Fainelli
2026-10-16 22:16 ` [PATCH 5/5] watchdog: Remove the MTX-1 watchdog driver Florian Fainelli
2026-10-20  1:01   ` Guenter Roeck
2026-10-20  1:00 ` [PATCH 0/5] MTX-1 watchdog driver removal Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cde332c2-3628-4bac-9a4e-55d85fe06628@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=25181214217@stu.xidian.edu.cn \
    --cc=andrew@lunn.ch \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=ebiggers@kernel.org \
    --cc=enelsonmoore@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=manuel.lauss@gmail.com \
    --cc=robert.marko@sartura.hr \
    --cc=robh@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®