From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD80AC61D9B for ; Wed, 22 Nov 2023 17:11:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232824AbjKVRLo (ORCPT ); Wed, 22 Nov 2023 12:11:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229806AbjKVRLm (ORCPT ); Wed, 22 Nov 2023 12:11:42 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35B871B5; Wed, 22 Nov 2023 09:11:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=kxp/djjLC0Lw510VoCfRhRGSsD7Q8L/T6M4GAU7G0KI=; b=oMN6zoRjxFSEdgndPqgumoztyZ FT0q49I6WX1MeJHViyYdKyK74chUDYr98xtin2diFhAtYR0FvNp62kHN5Wpe3YrYLeusmTecaKh61 59cPGWCNC9YIG5WlO+HgyeRgVqBNo4CWQeSIt6zIarTKpqsDoGk8iINd19zoAT7KEu4c=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1r5ql3-000tZx-6y; Wed, 22 Nov 2023 18:11:25 +0100 Date: Wed, 22 Nov 2023 18:11:25 +0100 From: Andrew Lunn To: =?iso-8859-1?Q?K=F6ry?= Maincent Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Luis Chamberlain , Russ Weight , Greg Kroah-Hartman , "Rafael J. Wysocki" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH net-next 9/9] net: pse-pd: Add PD692x0 PSE controller driver Message-ID: References: <20231116-feature_poe-v1-0-be48044bf249@bootlin.com> <20231116-feature_poe-v1-9-be48044bf249@bootlin.com> <45694d77-bcf8-4377-9aa0-046796de8d74@lunn.ch> <20231122174828.7625d7f4@kmaincent-XPS-13-7390> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231122174828.7625d7f4@kmaincent-XPS-13-7390> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Is the firmware in Motorola SREC format? I thought the kernel had a > > helper for that, but a quick search did not find it. So maybe i'm > > remembering wrongly. But it seems silly for every driver to implement > > an SREC parser. > > Oh, I didn't know this format. Its often used in small deeply embedded systems. Microcontrollers, rather than something which can run Linux. > The firmware seems indeed to match this format > specification. > I found two reference of this Firmware format in the kernel: > https://elixir.bootlin.com/linux/v6.5.7/source/sound/soc/codecs/zl38060.c#L178 > https://elixir.bootlin.com/linux/v6.5.7/source/drivers/staging/wlan-ng/prism2fw.c Ah, all inside a header file. Probably why i missed it. But ihex is not SREC. ihex came from Intel. SREC from Motorola. So i would follow the basic flow in include/linux/ihex.h, add an include/linux/srec.h but adapt it for SREC. Andrew