From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38A1837F73C for ; Sat, 14 Mar 2026 19:51:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773517915; cv=none; b=I/uNDJcqc+iczpJZdEZzWd9Gs+45214WKTqN90yo9ekPq8MquWetil1cQCcV8J3r30/MlnJPSaVE6QBBuOIbWkazIts0DIF6hRqadiutREYnqwAndNQK48k1atx0uZVjpbqusxXDFa6zCgdA8rF+rBzQF8G9OyPY+L1VfFVqT1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773517915; c=relaxed/simple; bh=PN/ebOVkl3Ch2oEl48DSbiQkNWOJst/IpNNfFU9a8WU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IrmpXRTlh4fwSAOmdFuRHix+EaGRri9hx69KKiWHUTzURbB374f5hbRaH9t3TpkHeZBreLAzQZpmUNc479kS9N3RP3YSAvOLkWow4Wa21JpVTkThm6OIzo7bDJWovv9L3Z7IzMfGvJLILL6AzIlLvQZKuwrtcjFiVaimODBGIdQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=flEhqgR4; arc=none smtp.client-ip=209.85.210.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="flEhqgR4" Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-7d7422b4ff1so1454352a34.3 for ; Sat, 14 Mar 2026 12:51:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1773517912; x=1774122712; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=D8F1aqi6Qy869M29EukxOGNGMVc3+0t8hXdBRfmiktU=; b=flEhqgR4mKUaS/olngJFGDWd7v8oKAo/r6t+CEfnMQiKnG5qCpDOL995SiGRCr0zBK sKxyTS3Ub3Iv7xo3TC7eHJa/MAR9afA9ED0Tglx2nhiyoXafAS4Cihpk0mccsb35QWo4 LFfkpEmMu3X1qPnNXkgUvkm1zYqgmvEjWZB9ADQWnXaf49MCtBYJdMCjntroQJ5+83Av djvi2uf/U2gZGvAHigYZGPYafgsofKJZ34BsgR+blnB71FYqZNonOWFdpmuhd1IdvxLC 6JKOTTTUNrwp6H6br5xZcdhMmLBgL+nF5TWXAoHdkzrjRQ01oqtPS6J0Hz5Fj4EO9a9L A4Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773517912; x=1774122712; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=D8F1aqi6Qy869M29EukxOGNGMVc3+0t8hXdBRfmiktU=; b=VlpZvS2NhmcMByyZjXpGpedLvSur8IoIkU0HLVxL0LdkfGsXy7/qmC/M/zSfmtcP0/ c9PpG/+uitRmvIwTLNZyZgLStprnB983kWBydLNOLKQdm1gEqEAkoTIDyn03Q/hGLbG+ S03sGpMYS266sWTnVxzmhpx91q6NE4dUl0S43tO+8WcncM/Q08EU9sCDQbDhU2LN5hci 62Kw1xMilhRvaZ4nnmLpEzWaSi1j2YiU9PAN9lQPukm9n+bMzuYVhpY74FgEiO4TX6Cs OtcfoME5/D2XwyfB1s21bRom/RG8Gi0VM5H1tXQBGUytvnHKpZKHnUoU8rDwRtu6Ojl9 iAqg== X-Forwarded-Encrypted: i=1; AJvYcCUtphMdIu5gSylCHd3ib5HBq4Wa1CQMunGdF2tslohOMDp7JdE1rIxp+ZrTzedGhSNl9GtAzKF3Y8vhnk0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+/0Yk5xffZCJZMkDJQY+jpY8PUhmRE7Iuqyu60InWDtHtFD4v 9Rw4y9Ve+OrbarMN7nRLnCzNSMkjN9KvBgh0O8rCdzuZkUGZIrok6sSAMNlGGUiU3/8= X-Gm-Gg: ATEYQzw3plXr/A6zDC2GSoO2Cj52qxdddpDV/OdBkELDtE4SB+EfYrERMSlZzKX5m0w tD3dQR1+H2HcW7F2ZB9acKH/CG8yADi/eiW13D5foMz39KpzPQzRdXjcwpwOlfoiXcidwYqMmGG iZADrcO+IPuIvaz6uKiy4PH34RzKCanXRBwWLsB7cWt6JIp08Z6WBs/SWod8gLwLgmq0AlTD6ko QVokx88vPo2oZhbT+joKN8LPDGOCrpcnMfIwB/yG0dQtROTHWP6Atn/Zlm30kJt5KXlu8qn7hCW TSVoV6jKWWvNbdZ++i2lJBeSeZQy2BBj8w4uyQF9FjzP7AXzW0DfWZnY8045gXTk3aNBg9pqgA6 zgXjpnvUdITGebOm5S+kaTh8XBfOhIByu9UExF7R38igiwI8eB3732aELxVxPwEfHI1YdLAWf8Z P3okDLgBGH8qrrrRODVDerVDu4elWhQqFNBR9jr3c7oTJJq97Jlgr/DB/bc+tnP1y+/NPxrJ5mB A== X-Received: by 2002:a05:6830:828d:b0:7c7:63b6:89d3 with SMTP id 46e09a7af769-7d782510f72mr5089963a34.19.1773517912188; Sat, 14 Mar 2026 12:51:52 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:14a9:db6c:e65a:4287? ([2600:8803:e7e4:500:14a9:db6c:e65a:4287]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d76aebc9d3sm9157746a34.24.2026.03.14.12.51.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Mar 2026 12:51:51 -0700 (PDT) Message-ID: Date: Sat, 14 Mar 2026 14:51:50 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/6] iio: light: vcnl4000: replace mutex_init with devm_mutex_init To: Erikas Bitovtas , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260314-vcnl4000-regulators-v3-0-3c4a48d30676@gmail.com> <20260314-vcnl4000-regulators-v3-3-3c4a48d30676@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260314-vcnl4000-regulators-v3-3-3c4a48d30676@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/14/26 11:06 AM, Erikas Bitovtas wrote: > Replace mutex_init used across driver with its device-managed > counterpart, so all assigned mutexes get destroyed. > ... > @@ -1985,6 +1993,7 @@ static int vcnl4000_probe(struct i2c_client *client) > const struct i2c_device_id *id = i2c_client_get_device_id(client); > struct vcnl4000_data *data; > struct iio_dev *indio_dev; > + struct device *dev = &client->dev; Purely cosmetic, but I would have put this two lines up (right after *id) to keep assignments and longer lines together. No need to v4 though, everything else look good. > int ret; > > indio_dev = devm_iio_device_alloc(&client->dev, sizeof(*data));