From: Mark Brown <broonie@kernel.org>
To: Igor Artemiev <Igor.A.Artemiev@mcst.ru>
Cc: "Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>,
"Herve Codina" <herve.codina@bootlin.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [lvc-project] [PATCH] ASoC: simple-card-utils: Fix error handling in simple_util_init_jack()
Date: Wed, 19 Jun 2024 16:06:36 +0100 [thread overview]
Message-ID: <cdeb8451-8a72-473f-812e-6c21a96cecb9@sirena.org.uk> (raw)
In-Reply-To: <20240619142432.573338-1-Igor.A.Artemiev@mcst.ru>
[-- Attachment #1: Type: text/plain, Size: 476 bytes --]
On Wed, Jun 19, 2024 at 05:24:32PM +0300, Igor Artemiev wrote:
> Currently, if snd_soc_card_jack_new_pins() or snd_soc_jack_add_gpios()
> fails, the function continues execution without handling the error.
> This can lead to unexpected behavior and potential crashes.
This just looks like some static checker thing, I'm just seeing a bald
assertation about issues and crashes with no analysis about what those
might be. TBH I'd expect this to make things worse not better.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2024-06-19 15:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 14:24 Igor Artemiev
2024-06-19 14:56 ` Herve Codina
2024-06-19 15:06 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdeb8451-8a72-473f-812e-6c21a96cecb9@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Igor.A.Artemiev@mcst.ru \
--cc=herve.codina@bootlin.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®