mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Yihao Han <hanyihao@vivo.com>, Jingoo Han <jingoohan1@gmail.com>,
	linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Cc: kernel@vivo.com
Subject: Re: [PATCH] video: fbdev: s3c-fb: fix platform_get_irq.cocci warning
Date: Thu, 3 Mar 2022 11:15:20 +0100	[thread overview]
Message-ID: <cdeb8c40-1861-ac1e-338f-6ffdd6ddddb9@gmx.de> (raw)
In-Reply-To: <20220302034408.5990-1-hanyihao@vivo.com>

On 3/2/22 04:44, Yihao Han wrote:
> Remove dev_err() messages after platform_get_irq*() failures.
> platform_get_irq() already prints an error.
>
> Generated by: scripts/coccinelle/api/platform_get_irq.cocci
>
> Signed-off-by: Yihao Han <hanyihao@vivo.com>

applied to the fbdev for-next git tree.

Thanks!
Helge

> ---
>  drivers/video/fbdev/s3c-fb.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/s3c-fb.c b/drivers/video/fbdev/s3c-fb.c
> index 208514054c23..3abbc5737c3b 100644
> --- a/drivers/video/fbdev/s3c-fb.c
> +++ b/drivers/video/fbdev/s3c-fb.c
> @@ -1418,7 +1418,6 @@ static int s3c_fb_probe(struct platform_device *pdev)
>
>  	sfb->irq_no = platform_get_irq(pdev, 0);
>  	if (sfb->irq_no < 0) {
> -		dev_err(dev, "failed to acquire irq resource\n");
>  		ret = -ENOENT;
>  		goto err_lcd_clk;
>  	}


      reply	other threads:[~2022-03-03 10:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-02  3:44 Yihao Han
2022-03-03 10:15 ` Helge Deller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdeb8c40-1861-ac1e-338f-6ffdd6ddddb9@gmx.de \
    --to=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hanyihao@vivo.com \
    --cc=jingoohan1@gmail.com \
    --cc=kernel@vivo.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®