From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5133CC43603 for ; Tue, 10 Dec 2019 20:30:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 266A620652 for ; Tue, 10 Dec 2019 20:30:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="QIL3h0O4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726908AbfLJUa3 (ORCPT ); Tue, 10 Dec 2019 15:30:29 -0500 Received: from mail-eopbgr760041.outbound.protection.outlook.com ([40.107.76.41]:43374 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726364AbfLJUa2 (ORCPT ); Tue, 10 Dec 2019 15:30:28 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ixkWlwjs5SaChlehXYg0ZhubwqjE54XeFJywMvSB5gLONFvgVh8yrWgsvalgUQl/hOF/RSTtZgsIXAK447TBDpot4NzUlKB0Z21ef5aeIJRkpxW3Dv0VXQrkbe9BfX2EgoE3PG6XFC0sawDpfRckfOv170NAklI4AhdSGAUp1+XqLkpI0L6+/Z0tKGyV1P8NM4toKibJpYc892oI624uCylAEuWLyqj/OQpxwmmYDeclSI6DI940EZAxv6N/NsA1i2XxOQ8UU7w+oiwi8ne8UjeSvfpT5HdqPPRCArbhHyRmd1dMBPMDhjtcQ1+Ob9O4G8u9S3fvDGAMu5vF9YnBkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dCyvppKbKI0qwsCNf/PsfxLZC0SBZCyE6Yrsf7k+GlE=; b=Ndbk4+J8k3HSQ5sj6RaP1Sk7fz2PQ7PkXLf8Akhc8s4Z8Dm7txx2B50lX80ik9bYlNeQfMM6hLzz/w430IPCcgKf/XwL1a2GZkjkASG1R8j2QV9USIpPKzP94Hikt7Urky8bclv0/QcXctXrXeuqFGw27sBOi4PkLaw73N3ss7Xo8MZCIEkme4xvmt4ALAsjTfsOqxdJV8C+F9LsyYAfeMGEdbd2a/OryicicXMAQNt6xcqGIA5r/5a8TbKcwmy1hx7NBAcjIV9D1FtwlfgPC/iK+IUewgfRBM2EKvZBKfpV8lWY5xZXVptHWD1fl82mweGEGww3USou6bg69g/bTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dCyvppKbKI0qwsCNf/PsfxLZC0SBZCyE6Yrsf7k+GlE=; b=QIL3h0O4IfO75c5n5V7YQsQq2GKzcqm4qAPtpsZc13iFLLK1R6R7RPjwu9udm5SmTz1EnfiVgzfe8z1nEPC5QFJLKKqITu3oiMtjJJKF5PCgFssDjPjAIZcFb0YIZY/CNztIZ6z9gEmeYCENEGHPhs+nuwuVlaLRrTpQJPHEKUU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Nicholas.Kazlauskas@amd.com; Received: from BYAPR12MB3560.namprd12.prod.outlook.com (20.178.197.10) by BYAPR12MB2744.namprd12.prod.outlook.com (20.176.255.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2495.20; Tue, 10 Dec 2019 20:30:26 +0000 Received: from BYAPR12MB3560.namprd12.prod.outlook.com ([fe80::81f8:ed8a:e30e:adb0]) by BYAPR12MB3560.namprd12.prod.outlook.com ([fe80::81f8:ed8a:e30e:adb0%7]) with mapi id 15.20.2516.018; Tue, 10 Dec 2019 20:30:25 +0000 Subject: Re: [PATCH] drm/amd/display: include linux/slab.h where needed To: Arnd Bergmann , Harry Wentland , Leo Li , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , "David (ChunMing) Zhou" , David Airlie , Daniel Vetter Cc: Eric Yang , Roman Li , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Michael Strauss , dri-devel@lists.freedesktop.org, Bhawanpreet Lakha References: <20191210195941.931745-1-arnd@arndb.de> From: "Kazlauskas, Nicholas" Message-ID: Date: Tue, 10 Dec 2019 15:30:21 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 In-Reply-To: <20191210195941.931745-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YTBPR01CA0015.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:14::28) To BYAPR12MB3560.namprd12.prod.outlook.com (2603:10b6:a03:ae::10) MIME-Version: 1.0 X-Originating-IP: [165.204.55.250] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 887df509-16fd-41ff-be5d-08d77dafc9bc X-MS-TrafficTypeDiagnostic: BYAPR12MB2744:|BYAPR12MB2744: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-Forefront-PRVS: 02475B2A01 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(396003)(346002)(366004)(136003)(376002)(39860400002)(199004)(189003)(2906002)(36756003)(4001150100001)(54906003)(52116002)(2616005)(26005)(53546011)(316002)(6506007)(81166006)(81156014)(110136005)(8676002)(66476007)(31686004)(8936002)(478600001)(31696002)(86362001)(4326008)(186003)(6666004)(66946007)(66556008)(6512007)(5660300002)(6486002);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR12MB2744;H:BYAPR12MB3560.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PhVw+sDhY+X6TWmj8G1oWP3GlXom8fireg8F24HBnvkORYa2m0LfHN+W0Q2a0uWZlweH4xl/RD9zvfRgy3XLwqnybfqyCMiQt4sXUqyaTnC9Q92t4bQJgzMldt+YpciPR03Mvrbl9DcJPHYaWEJzLtNkiN2BvJIzlXdQwbxdYyzOPNHPs4pAqeqFOL6pRHyTCjpSqoviCSUvScPnlDUq3VYyOgFDi7njzMQY4eNooLoq0DCH/QV5C0BwtQO/3HgEqRw7AX4rZNSYRCN7Y+8Zx2THzdMYM9Sfjn4Zs7PecZwqIZrDrdQO7XlGfpMWolLooG8brtZmaP96gyDB4X/bdkf5peP/1fkUGN5eLky21B+mDZr4C7qYOjBAqxowyfr3yjg77Bc1UPNCO4BCm2b/B8n2LqjayhL7t5FndfRJw7l/mDGPGKDYn55gbofF4qtH X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 887df509-16fd-41ff-be5d-08d77dafc9bc X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2019 20:30:25.7041 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MvmUZm89pFyTxanMR3yIaoqnIf1ESN7jQ8YpEzDim+l3hT8wtlMNquy8zLj76sVrDiVeIHGvqArYva5QDjgipA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2744 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-12-10 2:59 p.m., Arnd Bergmann wrote: > Calling kzalloc() and related functions requires the > linux/slab.h header to be included: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.c: In function 'dcn21_ipp_create': > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn21/dcn21_resource.c:679:3: error: implicit declaration of function 'kzalloc'; did you mean 'd_alloc'? [-Werror=implicit-function-declaration] > kzalloc(sizeof(struct dcn10_ipp), GFP_KERNEL); > > A lot of other headers also miss a direct include in this file, > but this is the only one that causes a problem for now. > > Signed-off-by: Arnd Bergmann What version of the kernel are you building? We have: #include in os_types.h which gets included as part of this file: #include -> #include -> #include Nicholas Kazlauskas > --- > drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c > index 906c84e6b49b..af57885bbff2 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c > @@ -23,6 +23,8 @@ > * > */ > > +#include > + > #include "dm_services.h" > #include "dc.h" > >