From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f226.google.com (mail-qt1-f226.google.com [209.85.160.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D52791BD9C9 for ; Mon, 6 Apr 2026 16:44:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.226 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775493845; cv=none; b=RoA+H+PdOgclkyWa3rNSErsabg6CEA/NiYZCezc+5dfHqJhVKP3s0P0mSuI70IoqyevtZePB3D4+Z4T0IP8AISEXkeW1VAXErgCf5iiad8vgJ7aSrI8XMiGzNbpGXHLn2Yzs57AEtsmdEC2id6kfkWG590xc0z3uQwPIQSsI9tI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775493845; c=relaxed/simple; bh=REc/vRgYW4cmwtP9hav5H1QyEg1NfxHK7rgjynKWbZ0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cOE+eJOk5+KE0Wm0JfJI4DttsbG/0k3O1Nx6UGEDR0pXZ3AqejhPE409ZYf619MDoxZ5DjH3pShCMG8gVXSHxIsdLsW6w2VFv+pGklWboBvh6H/oRA+LhhbSDx/SyNFQ28NbUy2+wheK4xjJDp5ZfycplzS1J5QK5CQ810dlQ6M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Oc3zTf6o; arc=none smtp.client-ip=209.85.160.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Oc3zTf6o" Received: by mail-qt1-f226.google.com with SMTP id d75a77b69052e-50d58c513dbso33337361cf.2 for ; Mon, 06 Apr 2026 09:44:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775493842; x=1776098642; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YaGqfE5XR7b6uHH8ytXdqGCyL58z+YbazBoW6b8pwfs=; b=chCVXSeOQI0cAMwcBk0F5ue6e+sLwdSqNg6zM6ivOvHWQc8rnyWprbycw1Q985mTrp BtwRLU8731aCYm+O9qEQJKz+Z/l5tBQHZ1t3oJHMS4uxHvrWSntPEtZFX36EoKJEaX7b hImlVZ2whWTajT8z/B2tVRNaLaljWiquPzaloMR13TBRxnmwLU+6qDVT2yIvP4P2S5As IKylefXE9y5ZCMiV0TG0tZdyM2RoPVBeJdKVh3gU8RKBoukTGAHblUWKEp5Acbn0GNGi mu6Uld3C4P/KqoKg/hBddyoXOGZZ0whXCh2TBXzhszo0/FinR3CkYOm0tnPdN+z9VPfV XcUA== X-Forwarded-Encrypted: i=1; AJvYcCV6CitrutIqujon0grBehIXxAxwc9TloKaB8hC+3VIhgmv6F5i8uJA5+cnXhESKLo2nW4rajPoUitgnVFc=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8hfA+ThD9cWznSmd5OUjuiakAbugMmIw3m8FBcABhTXRyF+6F ZKcaZfZsy+ehuSNLnfF5UwvzWOVtMQAwG32bM7v5cyihhx2q1kg54FGY5SbmNdO79n7DQWowiya Lj49biPSFJ3cl7s6yA8Zhx0HaaFz3ZNHahlx7GYJ3gUZdfZvjLnSuvJfiJ7i8m7BdzETVG0uV2r 1XyrUi+XEkC8K47NhlnS/YICU/NWT16bmR5M0uqdvV7TfQYa0eA+3kJdyFAYhsZ0KM7zH8jKv84 0LiSaLYYU+iVi4MEyK5tFJN X-Gm-Gg: AeBDiesoIzgklhefnDQKoGkpccHwzE6/zWj2WzHLoqlF5CIStRG9MJzTTMx6phtKPal HOAo8f58Sk/KGPD3jVYMkYbXIeKp0J/vDvqET0EOyiJSSNGYVCSd6+qfPL1K0vj/EcWCvGxA0Uf zxHtoYqKI9CzOfpiUsbkpapepjeuEqNfuCbIe3p2zb0JxNoFR9NSHvoFLMnvacnDqcAZyTXZflF EXMDRid0r3nAT3M74BHQd81yaQYqLSIO57K1aFKXZnC5eJ+v5kMnGebu6gFbHaSbfxdJYK52EZy 2jTBgh2hNjOLttTEE8kcio4wVUsUNK86PkJ5u8wZCzR5bnFjEbaVLEpuqM0w3hkIAB/L6Ofy8zs xf3B90qO3HcKmjROqDOctA0gkrIE8+3VagbbZYV+zukOolwaPpR7v126psVaZLYJNGtJzW760Ph essg+4jaUp/f8t+vIfDqb6tHW8CrxJDj4KVjruH+k9OpyXl2+a8PhyHrD0lah3Bw== X-Received: by 2002:a05:622a:4e09:b0:509:3d06:96a with SMTP id d75a77b69052e-50d62b12664mr197551541cf.53.1775493842466; Mon, 06 Apr 2026 09:44:02 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-15.dlp.protect.broadcom.com. [144.49.247.15]) by smtp-relay.gmail.com with ESMTPS id d75a77b69052e-50d8b2357b0sm2754561cf.15.2026.04.06.09.44.02 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Apr 2026 09:44:02 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4837bfcfe0dso49044015e9.1 for ; Mon, 06 Apr 2026 09:44:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1775493841; x=1776098641; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=YaGqfE5XR7b6uHH8ytXdqGCyL58z+YbazBoW6b8pwfs=; b=Oc3zTf6omkmTzs/Db85ph2X7ZpAdz6LLTw+tuK8/ldYVRmXLQHHE0ebJSh2RJzyCD/ 5MNugBpRU73Ww1PL5B//9ykkQLBmrPLDZ1UJbl9vL+J+Uvh0RYV++hhbZAEMx2AViCJZ 6l9WtBXhcsXLnA+3bKyStXIz8N0G6s2d9o2sY= X-Forwarded-Encrypted: i=1; AJvYcCXE9pPmJm1dty8AAC8h38TM4tMT4RkZ/xhWll9qFdPjenjToaOjw5qhqehDP4b+oys4jzxk2WpCybONllg=@vger.kernel.org X-Received: by 2002:a05:600c:4593:b0:485:3423:727d with SMTP id 5b1f17b1804b1-488997dec19mr206968875e9.26.1775493840868; Mon, 06 Apr 2026 09:44:00 -0700 (PDT) X-Received: by 2002:a05:600c:4593:b0:485:3423:727d with SMTP id 5b1f17b1804b1-488997dec19mr206968305e9.26.1775493840375; Mon, 06 Apr 2026 09:44:00 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48899d3a4e9sm192703635e9.6.2026.04.06.09.43.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Apr 2026 09:43:59 -0700 (PDT) Message-ID: Date: Mon, 6 Apr 2026 09:43:55 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 0/3] net: phy: add support for disabling autonomous EEE To: Andrew Lunn , Nicolai Buchwitz Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Broadcom internal kernel review list , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260406-devel-autonomous-eee-v1-0-b335e7143711@tipi-net.de> <9272c5dd653039b3def8caaea3e631c5@tipi-net.de> <5298959c-12de-4992-a896-3d1371cba111@lunn.ch> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <5298959c-12de-4992-a896-3d1371cba111@lunn.ch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 4/6/26 06:56, Andrew Lunn wrote: >> "Autonomous EEE" works for me (obviously). It kinda describes what >> happens (the PHY acts autonomously) without being tied to a specific >> vendor's marketing name. >> >> That said, I feel Russell's argument that it doesn't type well. But >> even after some walks in the woods I wasn't able to come up with a >> better name yet. > > Yes, naming is hard. > >> I don't think there's a meaningful use case for letting users choose >> between the two. Or is there? > > This has come up before, in other context. PTP is one example, where > both the MAC and the PHY can implement it. Ideally, you want it to > happen at the PHY, it gives higher accuracy. But there are systems > where the PHY implementation is somewhat broken, and the MAC PTP gives > better results. So defaulting to PHY PTP is not always the best > option. > > I would expect IEEE 802.3 EEE, with both the MAC and PHY cooperating > is better than just PHY level EEE, the system as a whole has a better > picture of what is going on, so using 802.3 EEE should be the > preference/default. But are we going to run into oddball systems where > autonomous EEE is actually better than using a somewhat broke MAC? That is almost a guarantee given, there will be a broken MAC, and there will be a need for enabling EEE at the PHY level because the power savings can be significant. Until that happens however, I would agree with using the global "--set-eee" without differentiating, and if we need to disable MAC-level EEE and switch to PHY-level EEE then we cross that bridge when necessary. -- Florian