From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 462B343B4B9 for ; Fri, 10 Jul 2026 16:01:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783699302; cv=none; b=t5LKVMK0cr9KXsvDag2GAAmtnoavrUH/f5G7Zz2vKWjEDGRnsOfmoA8PTpN7qU0IbH7oxI1IfH08p2lpEGvZO8U3O/cMToCHTBYhuDq96fvLIPzw8SuON9lluv2O+jyZRmwHipsrVVPmXLns/YjhYqqVErBo3nCyd6Qj4mI53oQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783699302; c=relaxed/simple; bh=X+CM6CcZvtG3xrXzA+E7vFdnehcFp/XJxB85EcmWIbw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R7G8jgLZKuD46rDnXJpFLiJWheudi/10x2qwq86Kp373y5/Qf4/f+NVNDXu6zb+3Jny+rRCHY+j0MPE01IEKF9vyAivCJ9+pEbdiVEovyUcV2BYYXDdXeqculNvFMIQ7Im1yiq5MMJFg1p1Fl4yhyXKh9w/ZL44C01+FOhONwrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=V20EhwOl; arc=none smtp.client-ip=209.85.219.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="V20EhwOl" Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-90004d2f7b7so16323446d6.1 for ; Fri, 10 Jul 2026 09:01:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1783699294; x=1784304094; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BJ1o73BxjtDCU3tES64jvElPh2pTfJj5ck4Dt4zpj7w=; b=V20EhwOl/eMXIJLYmaVemob+mNOMJKQLnDKN19M/Iz9vCwrBr6tzsKttk+gSmyntLT VUtHivmhudKH19TE84ks8ZYoHBSCoiEw6+Fbb1zNL0X+HWClWJSTD9hNS3SJph3aQGYQ Qd+DxtajUZdSW645jUdIrUWA18rdoyWzDNBfd+N1LJDu1Ka/eEEm0FkYKD+tLFfiG9LH xPHr2bVOHLIdEkp5Gm6vYpaII76+MViGyheOKR7E2OJkYRNzwoF+NWSkQJVaQK8Rft1j m/GqVliME115NivtsJ5U7XFVjmqblJAWRIO+FrEVf5u5Sy2xD8es6FCQXObrb8ElkiEE Tg+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783699294; x=1784304094; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BJ1o73BxjtDCU3tES64jvElPh2pTfJj5ck4Dt4zpj7w=; b=rA/5s96njK83aKEGsSnA3YM9aPLVK8NwUQhBvcl31nrrpBIrZFZb3KO3odkxPetkHJ iuKW24qJXxPIOqbnrvuIaGLZxzObPilBdKsC0H/aDfwAJ7d19HK6auoLF8v+cVtyUMJX 5dfSIaMSIMXgOI/GIX7yf6YA2VU2afW5HM20lc3tEKx5gGd08SBp+McxWzn6JLA4OfPC kF5lEz5dk4Zfm4ilSzXJXhJ3kzLyP3RkP9SVHSVZL9yhwaEH81AeD7FsvPUoiIiUzFfx 90aY+39pilRuE/rd+6hQxhN5DfiZUm+Lyweg5Vws0XoqMf5GaMYaA9VC6QAeCuhJJ/+R DitA== X-Forwarded-Encrypted: i=1; AHgh+RrRuzh2oISuNpp553hdH1/MisgdCmIgvXVvouII1jYMT+Q54Ixx9BcK62oeHUrSbmUPxy/SXjtzHuPAdhc=@vger.kernel.org X-Gm-Message-State: AOJu0YxXR3ew3WAxTlM1i9t2Qv9rZaqkYTHuTN4mZBkqq/WpOGq81p1d wUK6905bZ80I9O96YO+A53yZhwux9gc3uXSP3K5Za8OUm29fMOBYupnV32W7VO1zVtQ= X-Gm-Gg: AfdE7cmnDeiP7kNis2xHPh9YnBKcns2uUbxxLFddP4LW9fqoxlultPTGGdmGVjSkZBd fuqO0TaCuQkmlzGmC5r6Tf/9fLs6BWWMf3EbjT+EtbyFz34i8pEZoRpPlqzva/zAETlt3T+0u/s pOD2COZ/xLSkahyMW4jGTF99ZvgMV/7Oz/RsH5FwneUIeu33Fls+RrLCaalUQF2l+DFYpwem1yj lsXptctDn868pFNDKs8OvKZ5IwYfQosFdwn/nvpZV13gjk1OXlv5PgWkU6uObko8NflEVA2WepY 19FxHfgDibGIznsS/Xo1O1c97RoYnFnIO7ObUpS+aS25K7t0BvqMbT8rANYZqirl6ZgHkti3L6k lH8kT77N/1qDOAJK0yc9al2Qpeag5GBY4qVYyW2CovKNfH4Wpn0pREbk2cf4V869af51nLih/tt I72Xc7NDzUGDwa X-Received: by 2002:ad4:5f86:0:b0:8f0:f35c:23ab with SMTP id 6a1803df08f44-8fec189aed8mr127228496d6.16.1783699290317; Fri, 10 Jul 2026 09:01:30 -0700 (PDT) Received: from [172.22.22.28] ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9036e27f765sm8965376d6.11.2026.07.10.09.01.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 09:01:29 -0700 (PDT) Message-ID: Date: Fri, 10 Jul 2026 11:01:27 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/6] PCI: spacemit-k1: Add device id update helper To: Inochi Amaoto , Jingoo Han , Manivannan Sadhasivam , Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Christian Bruel , Frank Li , Nam Cao , Qiang Yu , Krishna Chaitanya Chundru , Xincheng Zhang , Siddharth Vadapalli , Andy Shevchenko , Vidya Sagar , Neil Armstrong , Gustavo Pimentel Cc: linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, Yixun Lan , Longbin Li References: <20260709040027.958400-1-inochiama@gmail.com> <20260709040027.958400-4-inochiama@gmail.com> Content-Language: en-US From: Alex Elder In-Reply-To: <20260709040027.958400-4-inochiama@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/8/26 11:00 PM, Inochi Amaoto wrote: > Both K1 and K3 needs to set vendor id and device id, add a helper function s/needs/need/ > to simplify this. I think someone might have commented on this, but I expected to find that the next patch would fill in the code that's needed to support K3, but that patch is at the end of your series. The reason I say it here is that I wondered while looking at this one why it was needed to create this helper function. I now know that k3_pcie_init() will call it (but I had to find that in the last patch, which was later than I expected). Your series should start with DT binding changes, then code changes, and (often) end with DTS changes. Anyway, this looks good. Reviewed-by: Alex Elder > Signed-off-by: Inochi Amaoto > --- > drivers/pci/controller/dwc/pcie-spacemit-k1.c | 17 +++++++++++++---- > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-spacemit-k1.c b/drivers/pci/controller/dwc/pcie-spacemit-k1.c > index e22ecbd09579..31aac056b68e 100644 > --- a/drivers/pci/controller/dwc/pcie-spacemit-k1.c > +++ b/drivers/pci/controller/dwc/pcie-spacemit-k1.c > @@ -56,6 +56,7 @@ struct k1_pcie_device_data { > const struct dw_pcie_ops *ops; > int (*parse_port)(struct k1_pcie *k1); > unsigned int max_phy_count; > + unsigned int device_id; > }; > > struct k1_pcie { > @@ -186,6 +187,16 @@ static void k1_pcie_disable_aspm_l1(struct k1_pcie *k1) > dw_pcie_dbi_ro_wr_dis(pci); > } > > +static void k1_pcie_set_device_id(struct k1_pcie *k1) > +{ > + struct dw_pcie *pci = &k1->pci; > + > + dw_pcie_dbi_ro_wr_en(pci); > + dw_pcie_writew_dbi(pci, PCI_VENDOR_ID, PCI_VENDOR_ID_SPACEMIT); > + dw_pcie_writew_dbi(pci, PCI_DEVICE_ID, k1->data->device_id); > + dw_pcie_dbi_ro_wr_dis(pci); > +} > + > static int k1_pcie_init(struct dw_pcie_rp *pp) > { > struct dw_pcie *pci = to_dw_pcie_from_pp(pp); > @@ -201,10 +212,7 @@ static int k1_pcie_init(struct dw_pcie_rp *pp) > return ret; > > /* Set the PCI vendor and device ID */ > - dw_pcie_dbi_ro_wr_en(pci); > - dw_pcie_writew_dbi(pci, PCI_VENDOR_ID, PCI_VENDOR_ID_SPACEMIT); > - dw_pcie_writew_dbi(pci, PCI_DEVICE_ID, PCI_DEVICE_ID_SPACEMIT_K1); > - dw_pcie_dbi_ro_wr_dis(pci); > + k1_pcie_set_device_id(k1); > > /* > * Start by asserting fundamental reset (drive PERST# low). The > @@ -406,6 +414,7 @@ static const struct k1_pcie_device_data k1_pcie_device_data = { > .ops = &k1_pcie_ops, > .parse_port = k1_pcie_parse_port, > .max_phy_count = 1, > + .device_id = PCI_DEVICE_ID_SPACEMIT_K1, > }; > > static const struct of_device_id k1_pcie_of_match_table[] = {