From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 886E9C46470 for ; Wed, 8 Aug 2018 21:41:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36D8521A8E for ; Wed, 8 Aug 2018 21:41:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="AkxI1X+n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36D8521A8E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730502AbeHIADD (ORCPT ); Wed, 8 Aug 2018 20:03:03 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:35304 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727706AbeHIADD (ORCPT ); Wed, 8 Aug 2018 20:03:03 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id w78LfQav016131; Wed, 8 Aug 2018 16:41:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1533764486; bh=0shRxbx7l+I3iO4Xj6f7GCOaX/R0zYtUnsVawuMowCE=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=AkxI1X+n7cUmL9nZonD1xyJ8lSxqUtB5MlsNLkY1pDIsSN1uQ0YGsHiRos5cq8gPL 702za863TfnUUVKRUPi7aDCOFbo+JqsiMPfK5tRhYAkPFZ/1L39Xn5xD2fXrzHR3e9 lyVk1O/lJHEuMOZ0zW9m3jwbAC/cp3YlU/CAR9tk= Received: from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id w78LfQjH029254; Wed, 8 Aug 2018 16:41:26 -0500 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 8 Aug 2018 16:41:26 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Wed, 8 Aug 2018 16:41:25 -0500 Received: from [172.22.156.167] (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id w78LfP6K006393; Wed, 8 Aug 2018 16:41:25 -0500 Subject: Re: [PATCH v2 1/2] dt: bindings: lm3697: Add bindings for lm3697 driver To: Pavel Machek CC: , , , , References: <20180807160442.8937-1-dmurphy@ti.com> <20180808195903.GB20912@amd> <20180808210215.GA15831@amd> <20180808210926.GC15831@amd> From: Dan Murphy Message-ID: Date: Wed, 8 Aug 2018 16:41:16 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180808210926.GC15831@amd> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/08/2018 04:09 PM, Pavel Machek wrote: > On Wed 2018-08-08 16:04:43, Dan Murphy wrote: >> On 08/08/2018 04:02 PM, Pavel Machek wrote: >>> Hi! >>> >>>>>> + - #size-cells : 0 >>>>>> + - control-bank-cfg - : Indicates which sink is connected to which control bank >>>>>> + 0 - All HVLED outputs are controlled by bank A >>>>>> + 1 - HVLED1 is controlled bank B, HVLED2/3 are controlled by bank A >>>>>> + 2 - HVLED2 is controlled bank B, HVLED1/3 are controlled by bank A >>>>>> + 3 - HVLED1/2 are controlled by bank B, HVLED3 is controlled by bank A >>>>>> + 4 - HVLED3 is controlled by bank B, HVLED1/2 are controlled by bank A >>>>>> + 5 - HVLED1/3 is controlled by bank B, HVLED2 is controlled by bank A >>>>>> + 6 - (default) HVLED1 is controlled by bank A, HVLED2/3 are controlled by bank B >>>>>> + 7 - All HVLED outputs are controlled by bank B >>>>> >>>>> This is quite long way to describe a bitmask, no? Could we make >>>>> it so that control-bank-cfg is not needed? >>>> >>>> The problem we have here is there is a potential to control >>>> 3 different LED string but only 2 sinks. So control bank A can control 2 LED strings and control >>>> bank b can control 1 LED string. >>>> >>> >>> Can we forget about the LED strings, and just expose the sinks as >>> Linux LED devices? >> >> 2 sinks 3 LED strings. How do you know which LED string is which and what bank it belongs >> to when setting the brightness. Each Bank has a separate register for brightness control. > > Yes, and LED strings are statically assigned to banks, right? > > So why not simply forget about LED strings for sake of hw > abstractions, and work just with banks? How would you set the control bank register for the correct LED string configuration? Dan > Pavel > -- ------------------ Dan Murphy