From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 082C1371068 for ; Thu, 3 Sep 2026 20:30:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788467427; cv=none; b=OqZw4LX/AIUrOfRFvIRA/Tzf4nWzoBV2nladwjx1mXDmCoubVAR9DWNIBRrlpLMIVfxlyKb8ooH44iKoJbXyJTkzoQKq2zZXCmrwYaiFucn0y7YKDwnR0R8D4jdYTmd6bTDKBWlN9JYb4kFk2mhMma9RA9YE7NeFrOD213gG4Dg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788467427; c=relaxed/simple; bh=2E9w1aqzF66RZURnTfgMHXRSpmJeluzd3kwgBHEa5DY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=JBpNHjVZTP02ZqeNEYI/RV1xDDaiKOkaRzGOAUe5YIwgTLY0Ek+WjMABVwPUkG36TK0MrEbCbQD99RTvlnhixh1FXz+EljvqToQ04DhBI3Du5LuSCOgqP1wqgvzJkmrmCqHzx1fa+Ie2dUNblrot0RGhJRMbJwJ9yOQXHlkT568= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dubeyko.com; spf=pass smtp.mailfrom=dubeyko.com; dkim=pass (2048-bit key) header.d=dubeyko-com.20251104.gappssmtp.com header.i=@dubeyko-com.20251104.gappssmtp.com header.b=jLaL570o; arc=none smtp.client-ip=209.85.128.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dubeyko.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dubeyko.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dubeyko-com.20251104.gappssmtp.com header.i=@dubeyko-com.20251104.gappssmtp.com header.b="jLaL570o" Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-86162c086f8so3761107b3.1 for ; Thu, 03 Sep 2026 13:30:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dubeyko-com.20251104.gappssmtp.com; s=20251104; t=1788467415; x=1789072215; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :from:to:cc:subject:date:message-id:reply-to:content-type; bh=rwkmZsQHsgzSLObYQT2/MFZyLzJswR6lF4jrfX1emmg=; b=jLaL570o9mEf3zE8vj6f8PZS4J1Hs0T79g+vlPM5W/9K580ot2iABJb6JcmMd017Zf OvfhsCWPUvN6I7R+QVjT9XkY8v/FP9lUrLJrza9JcwXA/dx7jV6q4vKN81fLZM1cTGq2 ANlZQocDyqHY62zVsmV9v82MQ8/ojjWTa3qPDK+TvDmFJzj1G6R55cyaLq/OxMyE7YxS QgYPnHW0AjSN4AXrXYtn1Sl7J8mlfBIavf3SIEbTOogkj5FjaurjF0SeKpDvG0cIgZGF w+bSSYEw3VuIfK9aZdVv6/eNi5xBIU5H7CKGzYsqfX4YSsGdgmnvcl3ckKQfb/PEx3YE CKqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788467415; x=1789072215; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=rwkmZsQHsgzSLObYQT2/MFZyLzJswR6lF4jrfX1emmg=; b=mAIqhjxlTZhCdeQutpQDFjwP/KOiPnEstze5ygtNwD1Y9PrN1RMpS9DECu3CXBHzgd eBJhUu/e8idCR3LeF9VfKCMZ5/0jImp93GXk1jLzgs0fGvU6zSg0OEeu+RmxBffON7lh cIQL0OiYK8d5rAT9y2xG5oJRel9EC6Y7dvoZuy1pUYy5q1kTcuo61DSbqcGoM4yFG6jn lGAavXWk7LmF/Gr+QY4bFvnAfj9JLLRd/jv70B37m7YLfGHsBcJQZh7Hrmg/VRCSme5n 1KoLqEGaCSfm5YSoSdvAXrjHO3Ju+CJ+JdBDxj4IF5KFxMV+sW5WBhgWXgSpXabAtL8T 8aMg== X-Forwarded-Encrypted: i=1; AKwUvBxtu1Vr38SBW5cuoCkSU8e/sPVM0ReTGvpc6+dmVhaJsgWY/feDQ41f614iSq7GFERuBL2HcHcsKi/4DrY=@vger.kernel.org X-Gm-Message-State: AFuF++kkXay1xyc9HVMt9nK2HoK+0n8+G+GHAJBcwxve9p7QUe/yRfQq JlIWSkTEN4aje61xK1azd1cR+MlvLTYoJVwL4pqojmxE7waXyxWCYoEyDutq6jTtB2rlQJ4l5ag JWdJywQs= X-Gm-Gg: AYBFou2odrhTqn+ywNQGXLDoqlADNQgpd+3bdQIz0trDSfBGdIqUDBRJRp0m+LOQ+40 KsN86WJd2i5q0XuHFEfFF0wSO4IjHbVyFex8ULIeyyGqLRww0yxy+R8X5WnVLIJiqlegcfVwbLs X26AIq3ArtWbcLapwvbgtBcRU/5NaINDc9eUhG9+PRUSwJRKp0eKNw/14yfexF7dZ9D6HVuPaB1 rFGQZTGdH1UkOpSLn2vL1p0zlX1atRelh3zoBJfKLCu8oQ85nHFr1xZaEAEeka1n6b5WhcI32z7 X4WN1tE0fnM/mcv3VyggOB0EmDSLNRTsyBtOy+ND8cHVjWJxY4gqcR9T3lzuuL9+9xw1HRcRwRf 2NQbq/az3PovqV5CcXe+TOwOod2rzv4zu5RtjKIjvcJb4MgqsPpmqgQpSQm3wVRhGUV+fVQQaoO UEgJFz9uRwAzBudEAyZ3S91+yLt+E1vLSER+5QDc7VD7hiJZoiTstQDfU8iio+lwHfK3AnylwWC yhSoB8vJ/s1hjofuQd2roHFf3nykloX0CtzEj/GvS1appoOrKvyiiDBHQjEfPm5d4ujuQgHcsBv yGJrHNyunM+s7bUV6ajbiC7cfiorPLTbh+uNV3+9G1JuESGQqrY7pwTolW5qHDHa5A== X-Received: by 2002:a05:690c:4aa6:b0:80e:dc2:873b with SMTP id 00721157ae682-871a04e7ffemr214507b3.16.1788467414578; Thu, 03 Sep 2026 13:30:14 -0700 (PDT) Received: from ?IPv6:2600:1700:6476:1430:afbb:9d16:d2da:18a9? ([2600:1700:6476:1430:afbb:9d16:d2da:18a9]) by smtp.gmail.com with ESMTPSA id 00721157ae682-8714c1e1eacsm3714937b3.49.2026.09.03.13.30.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Sep 2026 13:30:14 -0700 (PDT) Message-ID: Subject: Re: [PATCH] nilfs2: strengthen consistency checks in nilfs_direct_propagate() From: Viacheslav Dubeyko To: Ryusuke Konishi Cc: linux-nilfs , LKML Date: Thu, 03 Sep 2026 13:30:12 -0700 In-Reply-To: <20260903172557.9446-1-konishi.ryusuke@gmail.com> References: <20260903172557.9446-1-konishi.ryusuke@gmail.com> Autocrypt: addr=slava@dubeyko.com; prefer-encrypt=mutual; keydata=mQINBGgaTLYBEADaJc/WqWTeunGetXyyGJ5Za7b23M/ozuDCWCp+yWUa2GqQKH40dxRIR zshgOmAue7t9RQJU9lxZ4ZHWbi1Hzz85+0omefEdAKFmxTO6+CYV0g/sapU0wPJws3sC2Pbda9/eJ ZcvScAX2n/PlhpTnzJKf3JkHh3nM1ACO3jzSe2/muSQJvqMLG2D71ccekr1RyUh8V+OZdrPtfkDam V6GOT6IvyE+d+55fzmo20nJKecvbyvdikWwZvjjCENsG9qOf3TcCJ9DDYwjyYe1To8b+mQM9nHcxp jUsUuH074BhISFwt99/htZdSgp4csiGeXr8f9BEotRB6+kjMBHaiJ6B7BIlDmlffyR4f3oR/5hxgy dvIxMocqyc03xVyM6tA4ZrshKkwDgZIFEKkx37ec22ZJczNwGywKQW2TGXUTZVbdooiG4tXbRBLxe ga/NTZ52ZdEkSxAUGw/l0y0InTtdDIWvfUT+WXtQcEPRBE6HHhoeFehLzWL/o7w5Hog+0hXhNjqte fzKpI2fWmYzoIb6ueNmE/8sP9fWXo6Av9m8B5hRvF/hVWfEysr/2LSqN+xjt9NEbg8WNRMLy/Y0MS p5fgf9pmGF78waFiBvgZIQNuQnHrM+0BmYOhR0JKoHjt7r5wLyNiKFc8b7xXndyCDYfniO3ljbr0j tXWRGxx4to6FwARAQABtCZWaWFjaGVzbGF2IER1YmV5a28gPHNsYXZhQGR1YmV5a28uY29tPokCVw QTAQoAQQIbAQUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBFXDC2tnzsoLQtrbBDlc2cL fhEB1BQJoGl5PAhkBAAoJEDlc2cLfhEB17DsP/jy/Dx19MtxWOniPqpQf2s65enkDZuMIQ94jSg7B F2qTKIbNR9SmsczjyjC+/J7m7WZRmcqnwFYMOyNfh12aF2WhjT7p5xEAbvfGVYwUpUrg/lcacdT0D Yk61GGc5ZB89OAWHLr0FJjI54bd7kn7E/JRQF4dqNsxU8qcPXQ0wLHxTHUPZu/w5Zu/cO+lQ3H0Pj pSEGaTAh+tBYGSvQ4YPYBcV8+qjTxzeNwkw4ARza8EjTwWKP2jWAfA/ay4VobRfqNQ2zLoo84qDtN Uxe0zPE2wobIXELWkbuW/6hoQFPpMlJWz+mbvVms57NAA1HO8F5c1SLFaJ6dN0AQbxrHi45/cQXla 9hSEOJjxcEnJG/ZmcomYHFneM9K1p1K6HcGajiY2BFWkVet9vuHygkLWXVYZ0lr1paLFR52S7T+cf 6dkxOqu1ZiRegvFoyzBUzlLh/elgp3tWUfG2VmJD3lGpB3m5ZhwQ3rFpK8A7cKzgKjwPp61Me0o9z HX53THoG+QG+o0nnIKK7M8+coToTSyznYoq9C3eKeM/J97x9+h9tbizaeUQvWzQOgG8myUJ5u5Dr4 6tv9KXrOJy0iy/dcyreMYV5lwODaFfOeA4Lbnn5vRn9OjuMg1PFhCi3yMI4lA4umXFw0V2/OI5rgW BQELhfvW6mxkihkl6KLZX8m1zcHitCpWaWFjaGVzbGF2IER1YmV5a28gPFNsYXZhLkR1YmV5a29Aa WJtLmNvbT6JAlQEEwEKAD4WIQRVwwtrZ87KC0La2wQ5XNnC34RAdQUCaBpd7AIbAQUJA8JnAAULCQ gHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRA5XNnC34RAdYjFEACiWBEybMt1xjRbEgaZ3UP5i2bSway DwYDvgWW5EbRP7JcqOcZ2vkJwrK3gsqC3FKpjOPh7ecE0I4vrabH1Qobe2N8B2Y396z24mGnkTBbb 16Uz3PC93nFN1BA0wuOjlr1/oOTy5gBY563vybhnXPfSEUcXRd28jI7z8tRyzXh2tL8ZLdv1u4vQ8 E0O7lVJ55p9yGxbwgb5vXU4T2irqRKLxRvU80rZIXoEM7zLf5r7RaRxgwjTKdu6rYMUOfoyEQQZTD 4Xg9YE/X8pZzcbYFs4IlscyK6cXU0pjwr2ssjearOLLDJ7ygvfOiOuCZL+6zHRunLwq2JH/RmwuLV mWWSbgosZD6c5+wu6DxV15y7zZaR3NFPOR5ErpCFUorKzBO1nA4dwOAbNym9OGkhRgLAyxwpea0V0 ZlStfp0kfVaSZYo7PXd8Bbtyjali0niBjPpEVZdgtVUpBlPr97jBYZ+L5GF3hd6WJFbEYgj+5Af7C UjbX9DHweGQ/tdXWRnJHRzorxzjOS3003ddRnPtQDDN3Z/XzdAZwQAs0RqqXrTeeJrLppFUbAP+HZ TyOLVJcAAlVQROoq8PbM3ZKIaOygjj6Yw0emJi1D9OsN2UKjoe4W185vamFWX4Ba41jmCPrYJWAWH fAMjjkInIPg7RLGs8FiwxfcpkILP0YbVWHiNAabQoVmlhY2hlc2xhdiBEdWJleWtvIDx2ZHViZXlr b0BrZXJuZWwub3JnPokCVAQTAQoAPhYhBFXDC2tnzsoLQtrbBDlc2cLfhEB1BQJoVemuAhsBBQkDw mcABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEDlc2cLfhEB1GRwP/1scX5HO9Sk7dRicLD/fxo ipwEs+UbeA0/TM8OQfdRI4C/tFBYbQCR7lD05dfq8VsYLEyrgeLqP/iRhabLky8LTaEdwoAqPDc/O 9HRffx/faJZqkKc1dZryjqS6b8NExhKOVWmDqN357+Cl/H4hT9wnvjCj1YEqXIxSd/2Pc8+yw/KRC AP7jtRzXHcc/49Lpz/NU5irScusxy2GLKa5o/13jFK3F1fWX1wsOJF8NlTx3rLtBy4GWHITwkBmu8 zI4qcJGp7eudI0l4xmIKKQWanEhVdzBm5UnfyLIa7gQ2T48UbxJlWnMhLxMPrxgtC4Kos1G3zovEy Ep+fJN7D1pwN9aR36jVKvRsX7V4leIDWGzCdfw1FGWkMUfrRwgIl6i3wgqcCP6r9YSWVQYXdmwdMu 1RFLC44iF9340S0hw9+30yGP8TWwd1mm8V/+zsdDAFAoAwisi5QLLkQnEsJSgLzJ9daAsE8KjMthv hUWHdpiUSjyCpigT+KPl9YunZhyrC1jZXERCDPCQVYgaPt+Xbhdjcem/ykv8UVIDAGVXjuk4OW8la nf8SP+uxkTTDKcPHOa5rYRaeNj7T/NClRSd4z6aV3F6pKEJnEGvv/DFMXtSHlbylhyiGKN2Amd0b4 9jg+DW85oNN7q2UYzYuPwkHsFFq5iyF1QggiwYYTpoVXsw Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.1 (by Flathub.org) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2026-09-04 at 02:23 +0900, Ryusuke Konishi wrote: > nilfs_direct_propagate() is responsible for updating the virtual > block > number associated with a dirty data block in the direct mapping. >=20 > It is not designed to handle intermediate node blocks.=C2=A0 Furthermore, > it > assumes that the block offset of the passed buffer head is within the > range of NILFS_DIRECT_KEY_MAX; otherwise, an out-of-bounds memory > access > could occur within the inode containing the bmap root. >=20 > While such inconsistencies stem from bugs, they can cause silent, > harmful side effects unless a debug kernel is used - as was the case > with a recent slab out-of-bounds access issue found in this function. >=20 > Therefore, issue a kernel warning via WARN_ON_ONCE() and return - > EINVAL > for these anomalies, allowing the bmap layer to handle the situation > as > a filesystem error. >=20 > Signed-off-by: Ryusuke Konishi > --- > Hi Viacheslav, >=20 > Please queue this for the next cycle. >=20 > While the recent out-of-bounds memory access issue in > nilfs_direct_propagate() has already been fixed, this adds extra > checks > to catch and gracefully handle similar potential bugs. >=20 > Thanks, > Ryusuke Konishi >=20 > =C2=A0fs/nilfs2/direct.c | 6 ++++++ > =C2=A01 file changed, 6 insertions(+) >=20 > diff --git a/fs/nilfs2/direct.c b/fs/nilfs2/direct.c > index b8643d3aa2f8..64da677dc8d4 100644 > --- a/fs/nilfs2/direct.c > +++ b/fs/nilfs2/direct.c > @@ -270,8 +270,14 @@ static int nilfs_direct_propagate(struct > nilfs_bmap *bmap, > =C2=A0 if (!NILFS_BMAP_USE_VBN(bmap)) > =C2=A0 return 0; > =C2=A0 > + if (WARN_ON_ONCE(buffer_nilfs_node(bh))) > + return -EINVAL; > + > =C2=A0 dat =3D nilfs_bmap_get_dat(bmap); > =C2=A0 key =3D nilfs_bmap_data_get_key(bmap, bh); > + if (WARN_ON_ONCE(key > NILFS_DIRECT_KEY_MAX)) > + return -EINVAL; > + > =C2=A0 ptr =3D nilfs_direct_get_ptr(bmap, key); > =C2=A0 if (ptr =3D=3D NILFS_BMAP_INVALID_PTR) > =C2=A0 return -EINVAL; Applied. Thanks, Slava.