From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4CEDECDE20 for ; Wed, 11 Sep 2019 17:56:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9627E206A1 for ; Wed, 11 Sep 2019 17:56:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="HMQSTGXv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729816AbfIKR4i (ORCPT ); Wed, 11 Sep 2019 13:56:38 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:44426 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729699AbfIKR4g (ORCPT ); Wed, 11 Sep 2019 13:56:36 -0400 Received: by mail-pl1-f193.google.com with SMTP id k1so10484068pls.11 for ; Wed, 11 Sep 2019 10:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9UDE7fGt18+1cBH1BDzpFJT4FbsQW05ecK8AZmM/NuA=; b=HMQSTGXvm3TbYLM+4OX5mmxZ3apw+mmeOz9yn6qO0J32o5VsrBER96caw3agnpU24E fJiMK8/+dWCToVQL4PSvhpP6QPJjivQyX7crT31ZH5JTfdMhiirFKVmH92nHhcJ609Z3 WtNp2MutVPfrX9FhJqovRAO9Cp8zIwc8J2AlE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9UDE7fGt18+1cBH1BDzpFJT4FbsQW05ecK8AZmM/NuA=; b=Uf38YBDgnYkj3tTNMf8iXEiEPoY5wzWXr3/tH9bUGh6EUMVYwItD5PAMJTHk1GV5JI KPEkyW9kfNb8t9gt8co86b+uopBF48VGi3gj6nj8uhvaPq7LCcimP/cVQOu7w0K/bG06 ZMlz+6wRdUJ2a3QAvIFSOC3sJEnL3f2nHkjJeOkmfcbsJ7ROGAn4dzU7zRZBwT2vVX/I eBjwT92iWeyCgRZp0Hq9TBRKNYwL4fC8/B5WzU9ekZDREM8h2wINqR5Xda97259wVsOM GG7RTyoowVTYpz6pNXQxo5yXSI7MMWlF2vihZu5jB/D0zmXICqdkEXJMekQdOPLhxuNw HxSw== X-Gm-Message-State: APjAAAWwRp6vG0EuZzel2uAgLdkkxl6WFLxWX6zYENARmDKvOeVqZSlQ IbHHxT9cQV5ipuQ1Ug2ARwbjRg== X-Google-Smtp-Source: APXvYqz61t4znS782zVi8rUTsjPxf6eB2RreSFzX5GFLSzM65LFj+KZvioGkJPVyXINo+2vFEokfWw== X-Received: by 2002:a17:902:fe93:: with SMTP id x19mr37602186plm.337.1568224594911; Wed, 11 Sep 2019 10:56:34 -0700 (PDT) Received: from rj-aorus.ric.broadcom.com ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id 143sm19361751pgc.6.2019.09.11.10.56.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Sep 2019 10:56:34 -0700 (PDT) Subject: Re: [PATCH] firmware: broadcom: add OP-TEE based BNXT f/w manager To: Sheetal Tigadoli , Greg Kroah-Hartman Cc: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Ard Biesheuvel , Ingo Molnar , Thomas Gleixner , Michal Simek , Rajan Vaja , Scott Branden , Vikram Prakash , tee-dev@lists.linaro.org, BCM Kernel Feedback , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, Vikas Gupta References: <1568128624-2902-1-git-send-email-sheetal.tigadoli@broadcom.com> <20190910171601.GA12665@kroah.com> From: Ray Jui Message-ID: Date: Wed, 11 Sep 2019 10:56:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/11/19 10:53 AM, Sheetal Tigadoli wrote: > Thanks for the review and comments. > > On Tue, Sep 10, 2019 at 10:46 PM Greg Kroah-Hartman > wrote: >> >> On Tue, Sep 10, 2019 at 08:47:04PM +0530, Sheetal Tigadoli wrote: >>> From: Vikas Gupta >>> >>> This driver registers on TEE bus to interact with OP-TEE based >>> BNXT firmware management modules >>> >>> Signed-off-by: Vikas Gupta >>> Signed-off-by: Sheetal Tigadoli >>> --- >>> drivers/firmware/broadcom/Kconfig | 8 + >>> drivers/firmware/broadcom/Makefile | 1 + >>> drivers/firmware/broadcom/tee_bnxt_fw.c | 447 ++++++++++++++++++++++++++ >>> include/linux/firmware/broadcom/tee_bnxt_fw.h | 17 + >>> 4 files changed, 473 insertions(+) >>> create mode 100644 drivers/firmware/broadcom/tee_bnxt_fw.c >>> create mode 100644 include/linux/firmware/broadcom/tee_bnxt_fw.h >>> >>> diff --git a/drivers/firmware/broadcom/Kconfig b/drivers/firmware/broadcom/Kconfig >>> index 6468082..a846a21 100644 >>> --- a/drivers/firmware/broadcom/Kconfig >>> +++ b/drivers/firmware/broadcom/Kconfig >>> @@ -22,3 +22,11 @@ config BCM47XX_SPROM >>> In case of SoC devices SPROM content is stored on a flash used by >>> bootloader firmware CFE. This driver provides method to ssb and bcma >>> drivers to read SPROM on SoC. >>> + >>> +config TEE_BNXT_FW >>> + bool "Broadcom BNXT firmware manager" >>> + depends on ARCH_BCM_IPROC && OPTEE >> >> No ability to build with compile testing? > Will add "|| COMPILE_TEST" >> >>> + default ARCH_BCM_IPROC >>> + help >>> + This module help to manage firmware on Broadcom BNXT device. The module >>> + registers on tee bus and invoke calls to manage firmware on BNXT device. >>> diff --git a/drivers/firmware/broadcom/Makefile b/drivers/firmware/broadcom/Makefile >>> index 72c7fdc..17c5061 100644 >>> --- a/drivers/firmware/broadcom/Makefile >>> +++ b/drivers/firmware/broadcom/Makefile >>> @@ -1,3 +1,4 @@ >>> # SPDX-License-Identifier: GPL-2.0-only >>> obj-$(CONFIG_BCM47XX_NVRAM) += bcm47xx_nvram.o >>> obj-$(CONFIG_BCM47XX_SPROM) += bcm47xx_sprom.o >>> +obj-$(CONFIG_TEE_BNXT_FW) += tee_bnxt_fw.o >>> diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c >>> new file mode 100644 >>> index 00000000..89a48fd >>> --- /dev/null >>> +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c >>> @@ -0,0 +1,447 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * Copyright 2019 Broadcom. >>> + */ >>> + >>> +#include >>> +#include >>> +#include >>> +#include >>> +#include >>> + >>> +#include >>> + >>> +#define DRIVER_NAME "tee-bnxt-fw" >> >> KBUILD_MODNAME? > Will remove DRIVER_NAME macro and use KBUILD_MODNAME instead. >> >>> +#define MAX_SHM_MEM_SZ SZ_4M >> >> Why? > Limiting max data buffer size per request to optee to 4MB. >> >>> + >>> +#define MAX_TEE_PARAM_ARRY_MEMB 4 >>> + >>> +enum ta_cmd { >>> +/* >>> + * TA_CMD_BNXT_FASTBOOT - boot bnxt device by copying f/w into sram >>> + * >>> + * param[0] unused >>> + * param[1] unused >>> + * param[2] unused >>> + * param[3] unused >>> + * >>> + * Result: >>> + * TEE_SUCCESS - Invoke command success >>> + * TEE_ERROR_ITEM_NOT_FOUND - Corrupt f/w image found on memory >>> + */ >>> + TA_CMD_BNXT_FASTBOOT = 0, >>> + >> >> Please indent the comments too. As-is this is hard to read. > Will do >> >> >>> +/* >>> + * TA_CMD_BNXT_HEALTH_STATUS - to check health of bnxt device >>> + * >>> + * param[0] (out value) - value.a: health status >>> + * param[1] unused >>> + * param[2] unused >>> + * param[3] unused >>> + * >>> + * Result: >>> + * TEE_SUCCESS - Invoke command success >>> + * TEE_ERROR_BAD_PARAMETERS - Incorrect input param >>> + */ >>> + TA_CMD_BNXT_HEALTH_STATUS, >> >> Should all of these have explicit values? > Will initialize each cmd (TA_CMD_BNXT_*) explicitly >> >>> + >>> +/* >>> + * TA_CMD_BNXT_HANDSHAKE - to check bnxt device is booted >>> + * >>> + * param[0] (in value) - value.a: max timeout value >>> + * param[0] (out value) - value.a: boot status >>> + * param[1] unused >>> + * param[2] unused >>> + * param[3] unused >>> + * >>> + * Result: >>> + * TEE_SUCCESS - Invoke command success >>> + * TEE_ERROR_BAD_PARAMETERS - Incorrect input param >>> + */ >>> + TA_CMD_BNXT_HANDSHAKE, >>> + >>> +/* >>> + * TA_CMD_BNXT_COPY_COREDUMP - copy the core dump into shm >>> + * >>> + * param[0] (in value) - value.a: offset at which data to be copied from >>> + * value.b: size of the data >>> + * param[1] unused >>> + * param[2] unused >>> + * param[3] unused >>> + * >>> + * Result: >>> + * TEE_SUCCESS - Invoke command success >>> + * TEE_ERROR_BAD_PARAMETERS - Incorrect input param >>> + * TEE_ERROR_ITEM_NOT_FOUND - Corrupt core dump >>> + */ >>> + TA_CMD_BNXT_COPY_COREDUMP, >>> + >>> +/* >>> + * TA_CMD_BNXT_FW_UPGRADE - upgrade the bnxt firmware >>> + * >>> + * param[0] (in value) - value.a: size of the f/w image >>> + * param[1] unused >>> + * param[2] unused >>> + * param[3] unused >>> + * >>> + * Result: >>> + * TEE_SUCCESS - Invoke command success >>> + * TEE_ERROR_BAD_PARAMETERS - Incorrect input param >>> + */ >>> + TA_CMD_BNXT_FW_UPGRADE, >>> +}; >>> + >>> +/** >>> + * struct tee_bnxt_fw_private - OP-TEE bnxt private data >>> + * @dev: OP-TEE based bnxt device. >>> + * @ctx: OP-TEE context handler. >>> + * @session_id: TA session identifier. >>> + */ >>> +struct tee_bnxt_fw_private { >>> + struct device *dev; >> >> Why is the pointer back needed? > the dev pointer is used in "dev_err()" >> >>> + struct tee_context *ctx; >>> + u32 session_id; >>> + struct tee_shm *fw_shm_pool; >>> +}; >>> + >>> +static struct tee_bnxt_fw_private pvt_data; >>> + >>> +static inline void prepare_args(int cmd, >>> + struct tee_ioctl_invoke_arg *inv_arg, >>> + struct tee_param *param) >>> +{ >>> + memset(inv_arg, 0, sizeof(*inv_arg)); >>> + memset(param, 0, (MAX_TEE_PARAM_ARRY_MEMB * sizeof(*param))); >>> + >>> + inv_arg->func = cmd; >>> + inv_arg->session = pvt_data.session_id; >>> + inv_arg->num_params = MAX_TEE_PARAM_ARRY_MEMB; >>> + >>> + /* Fill invoke cmd params */ >>> + switch (cmd) { >>> + case TA_CMD_BNXT_HEALTH_STATUS: >>> + param[0].attr = TEE_IOCTL_PARAM_ATTR_TYPE_VALUE_OUTPUT; >>> + break; >>> + case TA_CMD_BNXT_HANDSHAKE: >>> + param[0].attr = TEE_IOCTL_PARAM_ATTR_TYPE_VALUE_INOUT; >>> + break; >>> + case TA_CMD_BNXT_COPY_COREDUMP: >>> + case TA_CMD_BNXT_FW_UPGRADE: >>> + param[0].attr = TEE_IOCTL_PARAM_ATTR_TYPE_MEMREF_INOUT; >>> + param[0].u.memref.shm = pvt_data.fw_shm_pool; >>> + param[0].u.memref.size = MAX_SHM_MEM_SZ; >>> + param[0].u.memref.shm_offs = 0; >>> + param[1].attr = TEE_IOCTL_PARAM_ATTR_TYPE_VALUE_INPUT; >>> + break; >>> + case TA_CMD_BNXT_FASTBOOT: >>> + default: >>> + /* Nothing to do */ >>> + break; >>> + } >>> +} >>> + >>> +/** >>> + * tee_bnxt_fw_load() - Load the bnxt firmware >>> + * Uses an OP-TEE call to start a secure >>> + * boot process. >>> + * Returns 0 on success, negative errno otherwise. >>> + */ >>> +int tee_bnxt_fw_load(void) >>> +{ >>> + int ret = 0; >>> + struct tee_ioctl_invoke_arg inv_arg; >>> + struct tee_param param[MAX_TEE_PARAM_ARRY_MEMB]; >>> + >>> + if (!pvt_data.ctx) >>> + return -ENODEV; >>> + >>> + prepare_args(TA_CMD_BNXT_FASTBOOT, &inv_arg, param); >>> + >>> + ret = tee_client_invoke_func(pvt_data.ctx, &inv_arg, param); >>> + if ((ret < 0) || (inv_arg.ret != 0)) { >>> + dev_err(pvt_data.dev, "TA_CMD_BNXT_LOAD invoke err: %x\n", >>> + (ret < 0) ? ret : inv_arg.ret); >>> + return -EINVAL; >>> + } >>> + >>> + return 0; >>> +} >>> +EXPORT_SYMBOL(tee_bnxt_fw_load); >> >> Why are you exporting symbols for a single file? What uses these? > These apis will be used by bnxt driver, still working on open sourcing changes > Hi Greg, The above API is used by the bnxt_en Ethernet driver to load firmware that is stored in the secure region of DDR that can only be accessed through secure calls via TEE. EXPORT_SYMBOL is needed given that bnxt_en driver (the client that uses this API) is usually loaded as a module. >> This feels really wrong, are you sure this all is correct? Is there anything specific that looks wrong? Please help to point out and we'll fix it. Thanks, Ray >> >> I stopped reading here :) >> >> thanks, >> >> greg k-h