From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10392C7EE2F for ; Sat, 10 Jun 2023 17:10:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229637AbjFJRKb convert rfc822-to-8bit (ORCPT ); Sat, 10 Jun 2023 13:10:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbjFJRK1 (ORCPT ); Sat, 10 Jun 2023 13:10:27 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 461922D68 for ; Sat, 10 Jun 2023 10:10:26 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-170-etAEtKpgMd2HFWTUOuLzjA-1; Sat, 10 Jun 2023 18:10:23 +0100 X-MC-Unique: etAEtKpgMd2HFWTUOuLzjA-1 Received: from AcuMS.Aculab.com (10.202.163.6) by AcuMS.aculab.com (10.202.163.6) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Sat, 10 Jun 2023 18:10:19 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Sat, 10 Jun 2023 18:10:19 +0100 From: David Laight To: 'Chen-Yu Tsai' , Mark Brown , "Liam Girdwood" , Manivannan Sadhasivam , Cristian Ciocaltea , Matti Vaittinen CC: "linux-actions@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH] regulator: Use bitfield values for range selectors Thread-Topic: [PATCH] regulator: Use bitfield values for range selectors Thread-Index: AQHZmd7Pe+BdgVqXZ0e5XsPeombenK+ER+4A Date: Sat, 10 Jun 2023 17:10:19 +0000 Message-ID: References: <20230608075651.3214540-1-wenst@chromium.org> In-Reply-To: <20230608075651.3214540-1-wenst@chromium.org> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chen-Yu Tsai > Sent: 08 June 2023 08:57 > > Right now the regulator helpers expect raw register values for the range > selectors. This is different from the voltage selectors, which are > normalized as bitfield values. This leads to a bit of confusion. Also, > raw values are harder to copy from datasheets or match up with them, > as datasheets will typically have bitfield values. > > Make the helpers expect bitfield values, and convert existing users. > Include bitops.h explicitly for ffs(), and reorder the header include > statements. While at it, also replace module.h with export.h, since the > only use is EXPORT_SYMBOL_GPL. > ... > static const unsigned int atc260x_ldo_voltage_range_sel[] = { > - 0x0, 0x20, > + 0x0, 0x1, > }; Is there any way the change can be done so that un-edited modules fail to compile? Otherwise the whole thing is an accident waiting to happen. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)