From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 746EDC61D85 for ; Fri, 24 Nov 2023 01:05:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230075AbjKXBFK (ORCPT ); Thu, 23 Nov 2023 20:05:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjKXBFH (ORCPT ); Thu, 23 Nov 2023 20:05:07 -0500 Received: from bedivere.hansenpartnership.com (bedivere.hansenpartnership.com [IPv6:2607:fcd0:100:8a00::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4561DD48; Thu, 23 Nov 2023 17:05:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hansenpartnership.com; s=20151216; t=1700787913; bh=s9SKoVd6sdnEnEA2415LDa12idYEiEDjdTjzypXYR+E=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References:From; b=AdqQszBonguXvlEMtiDDg0SoW3MeKa7twOHRGFzgd0tnzfY99la/UrKAgBm+pONsK FhrM++V32eJtqlZZMTa7uCFyPI8Dq41rfAnOwIDWeNVHgqY58eeozKZ7zbVtpjzepf hZajl7u0+CCVi1tjl16Zi1GsQXdMzJoWlfXN9Y6o= Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id 8D2E212869A4; Thu, 23 Nov 2023 20:05:13 -0500 (EST) Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavis, port 10024) with ESMTP id uUK3h_duTxhG; Thu, 23 Nov 2023 20:05:13 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hansenpartnership.com; s=20151216; t=1700787913; bh=s9SKoVd6sdnEnEA2415LDa12idYEiEDjdTjzypXYR+E=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References:From; b=AdqQszBonguXvlEMtiDDg0SoW3MeKa7twOHRGFzgd0tnzfY99la/UrKAgBm+pONsK FhrM++V32eJtqlZZMTa7uCFyPI8Dq41rfAnOwIDWeNVHgqY58eeozKZ7zbVtpjzepf hZajl7u0+CCVi1tjl16Zi1GsQXdMzJoWlfXN9Y6o= Received: from lingrow.int.hansenpartnership.com (unknown [IPv6:2601:5c4:4302:c21::a774]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id 6F3321285F91; Thu, 23 Nov 2023 20:05:12 -0500 (EST) Message-ID: Subject: Re: Fwd: sign-file.c:149:17: warning: implicit declaration of function =?UTF-8?Q?=E2=80=98ENGINE=5Fload=5Fbuiltin=5Fengines=E2=80=99?= From: James Bottomley To: Dennis Clarke , Bagas Sanjaya , Linux Kernel Mailing List , Linux Kernel Build System , Linux Kernel Keyrings Cc: David Howells , David Woodhouse , Masahiro Yamada Date: Thu, 23 Nov 2023 20:05:06 -0500 In-Reply-To: <7fce272f-65f5-9aa8-5f28-aeecb98a8ab4@blastwave.org> References: <1fca50c4-6d7b-4c9b-bcea-4df17e2c2e7e@gmail.com> <164a4d4434e77ba1b65624a081799a073a3aced7.camel@HansenPartnership.com> <7fce272f-65f5-9aa8-5f28-aeecb98a8ab4@blastwave.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2023-11-23 at 18:42 -0500, Dennis Clarke wrote: > On 11/23/23 09:53, James Bottomley wrote: > > On Fri, 2023-11-17 at 00:34 -0500, Dennis Clarke wrote: > > > On 11/16/23 18:41, Bagas Sanjaya wrote: > > > > Hi, > > > > > > > > I notice a bug report on Bugzilla [1]. Quoting from it: > > > > > > > > > > > > Not related to > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=215750 but I > > > > > *feel* that this code needs a hug. > > > > > > > > See Bugzilla for the full thread. > > > > > > > > AFAIK, this looks like a bug when the kernel is compiled > > > > against custom (non-system) version of OpenSSL library. > > > > > > > > > > I do not know what you could possibly mean. There is nothing > > > "custom" about OpenSSL. For that matter the gcc compiler I am > > > using was also built by me. Works fine. The sign-file.c source > > > compiles fine. > > > > This has all the hallmarks of an openssl compiled without engine > > support; is the symbol OPENSSL_NO_ENGINE set?  And which distro did > > you get this library from? > > > > James > > > > I am looking into this. The code will likely age into some deprecated > calls and I think that I may be way out on the edge here. So you did build without engine support ... > However the code will need a pile of ifndef stuff and then call the > correct future looking calls for OpenSSL 3.x etc etc etc ... the > usual stuff Well, not really: openssl is highly configurable and if it gets configured wrongly, stuff like this happens. That's why distros have a fairly inclusive configuration and they stick to it. No-one can cope with the combinatoric explosion of openssl configuration possibilities (even though they have ifdefs for most of them) so the only way is really to fix a standard configuration and assume you're building for it. Openssl has been talking for ages about removing engine support, but they've been unable to do so due to the rather slow pace of conversion of their own engines. I anticipate this code can be removed in favour of the pkcs11 provider long before openssl actually manages to remove engines. James