From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 511B129A33E for ; Mon, 8 Dec 2025 15:18:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765207128; cv=none; b=UL+9TXN/1JlP+sU135/oV/Awj16ChA97Fw/EySyVdjltiGC+ARhrR5uFQfxmoQr3Tw8yK4hIQJYmBnzlfhCLO0CZ9DKk7pfvMYHBI3IY3kGeNmo2bMTiAAlyfapps8SRkltqGz2T5QyJQwIf3zvlkEWtwF6CDtQloPP7Yb5hy1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765207128; c=relaxed/simple; bh=vrMgUbPiviHCE/vtM5qKgmAf1NEAPRzc7KsDqfydLp8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ckTvkvuHlEPrxSQPTJaa2l8gf7Fgry63CmpW9uu8P7fXiWC59qqTdvygUV4d0l7dQCIwY5mMD2A/7UrhW5QxHRC42loxASSf6H4dC4ImIX/fA5GEJK9K17W73REwEDNoZ9r2nBKcH5evKs9cjnqq1ZebNsWFoAwW6uJ9rv1K6WI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=gQ3GbGRi; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="gQ3GbGRi" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-b73161849e1so1087924266b.2 for ; Mon, 08 Dec 2025 07:18:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1765207125; x=1765811925; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EyKkwg9npizIf2XwQV5tQ96E9Oa/5ROifR9l0/m15Fs=; b=gQ3GbGRi6bBY5XJ3DpT25Y1Iv2DDSnRoP0SnxA977BMPC7qQZU+dFXiYYsmElHvEwn GsEynVXOY+hYRsOO5fsXJNr5msrnSRb4gqcPsUkBYOpJJ7CgW/+7v7kzoD7NQAkm3Shn IvAYWVgVDNCrtRDtBpvCYSN3SaHORmUTHXei+JppY1dos2d9IUZF/Cs3YpZDHhv8y2oW AchRk7UV/RIW+Gh7Vr6yxkEvkfMLWEeXVFyGatZcVHP2gL0O43lwDq9nngar+X1tRRH6 FS4+9VRV6ZmCtnQ06Uciwd+DtrTz8m6LM5UoHorqP+w5ZJA3bmZNHesGS56ZyOmIpIVH jkYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765207125; x=1765811925; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=EyKkwg9npizIf2XwQV5tQ96E9Oa/5ROifR9l0/m15Fs=; b=gKbLLPgGIRSsUNTrxNoEZKAi27QPVPKK3+xBZ1xwDayFgh3K9yYp/pBJEx2JSQdIyS /ylHYpXl+Jp8fk1P/FvAjgF3dC3vFlaFjaT0B/hU8mOoyfqk9f/lZerx0V4G/iPLO3Eh kGrbVbUeUX6l2CYD6FJK7cLNJ20C3rBuieeS5kGcklr3VNLNnEFUKOaPnXbZNv3o+3T/ pSFpTLp/u067M9BUYMv9oipy+6X9zPe/qkfCBFEBHWzx5BZSLvjkaYJVeTbsmlJheRQ6 pfos7iz6fzn+YiTCGzy352HEy2suk9G9ORxj7rWiqeNWj5whc4kRZ+EtxJOyBj1IbqGU a/aA== X-Forwarded-Encrypted: i=1; AJvYcCWaFIbUoYUhse/XUmfwqWQxcY1ZYpDnGSiGwgAn3WiJ8aruf78h4nGaLNbTPnF3U0jyOETBWWzTM8mEUoY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7xCysX26y7p8OBrlhfhhkQkwYNTj86qHFt7jrz/UvJIKtiYoC Mbw/UtstiPDBEFJHHrBqywahwcneKZGY8fBEtXO+EukML7OjZAgdVfKRYcjnTp5GN8o= X-Gm-Gg: ASbGncvxaGU/XN99JSdDXRyEOmPQoAbUPwKn6Tl+WrBWg65rRIZADUlNwnkIWsqlXVq 1MzcjR93ewAa0nolKIdb+7IzfI7sqreC+OpZx+A1NWoE1IPk68T8/BMgckmMVzh1p5KDf1JpvEj VZiZhbPUfEm5OivAiZuTAf7+7meg2yjxEqF0fN/o+j1F7Td975cuYjzyRaTMD5AJMkpfr9oWZBd KHIHBplMogY1zdrxQmJ7rP+USN6CATLH/dJ7x62u+ycjV0yvkD1189j5v6DFj9DQ1LZtw10qHLB L3aNH+W/LqjS6W3/II47oKD/5Xsc78dThUoVbFvlK08j+sXHq+sBFtcP1wdOfCjwWJApF3vYFHo P/92PAhWIdUBntJ6hKl08lf5lBk5ci8P96qmD14NPU0//rtJ2fV5TcLO6gbfRSNZZ4xkRaN3aBW R7V9A+FBgqsACcBOcTqBhfPEEn31ycFA== X-Google-Smtp-Source: AGHT+IHmHAEWZzpXs1rtpanOldqfAtwXfDY30WfUvr0qkz0J9ZX8JM3l3XG0gNeJ1TSMmiLgbzx9AA== X-Received: by 2002:a17:907:5cc:b0:b76:25fd:6c26 with SMTP id a640c23a62f3a-b7a243047b5mr747928266b.6.1765207124126; Mon, 08 Dec 2025 07:18:44 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.134]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b79f49c94fbsm1100880866b.53.2025.12.08.07.18.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Dec 2025 07:18:43 -0800 (PST) Message-ID: Date: Mon, 8 Dec 2025 17:18:42 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] PCI: rzg3s-host: Use pci_generic_config_write() for the root bus To: Krishna Chaitanya Chundru , bhelgaas@google.com, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, robh@kernel.org Cc: linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea , Bjorn Helgaas References: <20251205112443.1408518-1-claudiu.beznea.uj@bp.renesas.com> <20251205112443.1408518-2-claudiu.beznea.uj@bp.renesas.com> From: Claudiu Beznea Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Krishna, On 12/6/25 03:29, Krishna Chaitanya Chundru wrote: > > On 12/5/2025 4:54 PM, Claudiu wrote: >> From: Claudiu Beznea >> >> The Renesas RZ/G3S host controller allows writing to read-only PCIe >> configuration registers when the RZG3S_PCI_PERM_CFG_HWINIT_EN bit is set in >> the RZG3S_PCI_PERM register. However, callers of struct pci_ops::write >> expect the semantics defined by the PCIe specification, meaning that writes >> to read-only registers must not be allowed. >> >> The previous custom struct pci_ops::write implementation for the root bus >> temporarily enabled write access before calling pci_generic_config_write(). >> This breaks the expected semantics. >> >> Remove the custom implementation and simply use pci_generic_config_write(). >> >> Along with this change, the updates of the PCI_PRIMARY_BUS, >> PCI_SECONDARY_BUS, and PCI_SUBORDINATE_BUS registers were moved so that >> they no longer depends on the RZG3S_PCI_PERM_CFG_HWINIT_EN bit in the >> RZG3S_PCI_PERM_CFG register, since these registers are R/W. >> > Don't you need fixes tag and back port to stable kernels, this patch looks > like a bug fix. I consider it was not a functional fix. The driver was just accepted for v6.19 and though it will be included before the pull request is issued. Due to this I haven't added it. If any, I'm adding the tag here. Fixes: 7ef502fb35b2 ("PCI: Add Renesas RZ/G3S host controller driver") Thank you, Claudiu