From: Dennis Dalessandro <dennis.dalessandro@intel.com>
To: "Hernán Gonzalez" <hernan@vanguardiasur.com.ar>,
mike.marciniszyn@intel.com, dledford@redhat.com, jgg@ziepe.ca,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] IB/qib: Move char *qib_sdma_state_names[] and constify while there.
Date: Sat, 3 Mar 2018 10:31:48 -0500 [thread overview]
Message-ID: <ce0ddb85-e008-9895-6508-7d721edeb1de@intel.com> (raw)
In-Reply-To: <1519769143-20000-2-git-send-email-hernan@vanguardiasur.com.ar>
On 2/27/2018 5:05 PM, Hernán Gonzalez wrote:
> Note: This is compile only tested as I have no access to the hw.
> This variable was not used in qib_sdma.c but in qib_iba7322.c. Declaring it
> there, as static, saves 56 bytes.
>
> add/remove: 0/2 grow/shrink: 0/0 up/down: 0/-144 (-144)
> Function old new delta
> qib_sdma_state_names 56 - -56
> qib_sdma_event_names 88 - -88
> Total: Before=2874565, After=2874421, chg -0.01%
>
> Signed-off-by: Hernán Gonzalez <hernan@vanguardiasur.com.ar>
Looks OK to me, thanks.
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
next prev parent reply other threads:[~2018-03-03 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 22:05 [PATCH 1/2] IB/qib: Remove unused variable (char *qib_sdma_event_names[]) Hernán Gonzalez
2018-02-27 22:05 ` [PATCH 2/2] IB/qib: Move char *qib_sdma_state_names[] and constify while there Hernán Gonzalez
2018-03-03 15:31 ` Dennis Dalessandro [this message]
2018-02-28 21:16 ` [PATCH 1/2] IB/qib: Remove unused variable (char *qib_sdma_event_names[]) Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce0ddb85-e008-9895-6508-7d721edeb1de@intel.com \
--to=dennis.dalessandro@intel.com \
--cc=dledford@redhat.com \
--cc=hernan@vanguardiasur.com.ar \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®