From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 63AED3546E6 for ; Wed, 20 May 2026 15:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779292564; cv=none; b=YvWjf9z4MfPmze9ulmKf1qTf0+DEEHogAaa0GDSlPt8lmg+XC4GElqe3uRCSY7JDAT3EYRUSIHSZDX1zIJGdUIYUbnJh+wQOzkWlmadHQUWQgJf02wYQl8iFLW3BkPhJ2qYhgcq6aWVYisoMwQHZoV5axYTPeKp+F7rnnUlkcnY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779292564; c=relaxed/simple; bh=9jJ/2cyZOf0QdFtaYu1gq20BFlY5mc2u8vQMeL7Ell0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Qwdr3iYBH2QtS8zQMnHi8g0v2nO5g0f08rRvs/+ACMHK5JxGgain+GdGAHfNLzlki2RWNbtQZ8W2KIoJWE/xdfBpeNIXfRz7XnJacVwbrrHNXvk6hzdJ5Uz9wxNBtWU9KfsYki1f1+1KrYaZE70q/0XmgVmf7Zmb9yFsImxgf5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dx/XWSQ8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eb5xl8t4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dx/XWSQ8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eb5xl8t4" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64KCebe9317554 for ; Wed, 20 May 2026 15:56:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Tcl+WzjjF0BVucHXtbsU//ErzfB4Mp5ZWOa4ul6dHBs=; b=dx/XWSQ82pqivzhP iQ2bkVNV4My91+UqsjGwcCGFWPZU3Bha6i90SkfRaFFd3GFTFCg82l1EkTpM1CfJ xZOF9Ucbhh4bM+brvjTOT7AP6npDk9DzNBaLO6KGdhLhFQvV/SWk+lrU7zLc0Fet C0dE2mlcXw90yK9lMJeA3ivJzCbcapZqbGzQru4YCf4gO9uATAjIWomQNvvCHWyY ODIZB//+JSFrFGuJaqzpo8ZuWraQWoYcZhfl7/ip66d7eNv4Qu1zis6ntzAUsUPn g7VZjQzirHFAxXp5jsWzAoN5hIaQ85YYPUdOISGfTD/iKMdbU3e4OCBJI/rhcg3c ihs5qg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9d5qrsu1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 20 May 2026 15:56:00 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2bc6899bfb1so50232865ad.2 for ; Wed, 20 May 2026 08:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779292560; x=1779897360; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Tcl+WzjjF0BVucHXtbsU//ErzfB4Mp5ZWOa4ul6dHBs=; b=eb5xl8t4JfPD0lScnZcIM9AspoXyJ8N7XIYJnHGMIp3Z8NMHdq6D+x7Yv+x0OIiqwr mbqYofIEE9QcSkQtdDHTPwj498PhVyz4c2abfM5et6i2pXT2GbxiCXtOCezvda7iK2Eh H2LgyZ64EeGYs/LnaQwOfJNp/UHpfN3rh91C5JpwKyq0NbGdWrC6Vk2bVtXBX3Eab4HR fUUj0PzEZ+2/Qjryx2Gfe6K+6QycEaNkA5SrZ98myXrxtht6A4HmUtHQfCZ/SnYtyBre g/DFYiNGmxAa6hhZFTliwNYc7nelc0L8ypBF++XpiVgO2yPwHwy0dythrRxFYcqPoj+B B39A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779292560; x=1779897360; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Tcl+WzjjF0BVucHXtbsU//ErzfB4Mp5ZWOa4ul6dHBs=; b=q0nCp9pJP7WtpiXRlVodXZ/fLH6XUgj5uPBqDblqfuxlioMLcY9eqrKfDzNP0OIzcY +BQN4QYxoBX9w1l9S2rlNhZHBBW3KPIGdM0VL0/TnVHUhbZbJeHPT/FpdFVoVPQXLuHE buylZCqzTtmNvxr/JL5yKKa+C6dvTAaKTNOr1tIpHw/7UEXJM9boR4M//EVll/cw++/U NrcAMQwZR2C8YYpvVH2sg1UO4y8eeGV1CJGrOMmm+vSamOR0U49NU6tPgterY87U48xD 7ypCY6JJhwq3D79DriGPZX7VUhxS+GNmsEfPWi3mLHqoXWPQaMOhEk77h+SGXsq02qCU s6Mg== X-Forwarded-Encrypted: i=1; AFNElJ/dcobTfzbT5bJ9cNnHk7KEwxDfjPGJ5FhxaLiAHtantvH5IdOA/v0BkB/Zlzzmil9WKZNs9SeHfiWuw7A=@vger.kernel.org X-Gm-Message-State: AOJu0Yxr4cO57IJLD3SGTDlyTj7+kc7tHI5Zt8qirOVndssvJ4MvT7uB tc6d1y3iYSIGN+a5tD5IV8HY53UUnQ9zoo67qlXgYZ8s0Kh8fJKwQ8F+bmWR2raIwSuTKPhiTMD nS6gVL74z7lSrl7jXWyXDqrUN5t/loYljRQAe6uzVEUA4copqaLpjOhmj5dMw0++jvvk= X-Gm-Gg: Acq92OEEt22UTv86iyS7HJPWRftI49Z3LECqSuSVXk9Ez8pW7sCUBE50ZIs+AD/q7Fc 0mJGlSxp7SapXzhVN0eqPoiUaE3NPeoQx+FwPtu+K/6FFxHisfVh3cbUAMFQ7MApHgZuFSa7jps 8j/kqeoUzCaY67AtNZ6nj9/kruQe4Ux5N50khTMSYBu+pRBISTHpjEgZUs+J2c1LW7cWKBXX4nn U3M484SliKMY94szJ3+eQmvrTf0NsV5cyzY7ccoNdY9jdHAJ0c2hPvdJL+ARQe5yCpOWP5BWshQ NNZGAoHo31puRCpLoOPHdoRKG2ACx6cKWWb5sf5hXuOFwBNt4Yb1SFtb0vqjjhvvezDJypQPApz PojLtqP5yM4ORl6kZ5pz2fjz8p7EsL7j6eVVcFHe4snkVx9sRtJ8rTvE= X-Received: by 2002:a17:903:24c:b0:2bd:eeb6:ff29 with SMTP id d9443c01a7336-2bdeeb70241mr136544715ad.12.1779292559402; Wed, 20 May 2026 08:55:59 -0700 (PDT) X-Received: by 2002:a17:903:24c:b0:2bd:eeb6:ff29 with SMTP id d9443c01a7336-2bdeeb70241mr136544265ad.12.1779292558882; Wed, 20 May 2026 08:55:58 -0700 (PDT) Received: from [10.204.101.125] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5c16ac4asm211289005ad.33.2026.05.20.08.55.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 May 2026 08:55:58 -0700 (PDT) Message-ID: Date: Wed, 20 May 2026 21:25:54 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/6] media: qcom: iris: vdec: update size and stride calculations for 10bit formats To: Neil Armstrong , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260511-topic-sm8x50-iris-10bit-decoding-v3-0-7fc049b93042@linaro.org> <20260511-topic-sm8x50-iris-10bit-decoding-v3-4-7fc049b93042@linaro.org> <8ee8e01e-fc55-4786-9c28-48fb17bf2a44@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIwMDE1NCBTYWx0ZWRfX0hTrBT+U8x9l mnSHL7qhGSourT+apT+UAs8amCwSrLdQPKXumg53EpOQ3yQdK+dX9W3g+Fq25lzM/IdvZ1IEkrL RDKFF2xtPWRiN2FlLR8zdqpoRxlkqnQkP0aBtQ4kXVALquI+/mo/pcv5zbjKrcA2hfGPO0hHvOO E0ZTMXBKbp3vXEcBCjiYJtq1z4Pz6piUE7sijbtQl3xXnCe8pEMBGJ7YNGV7sG8qaVnRjDO9yjA 72PvftZ09pmBEkVf/Q/d657xEg/rAQs4Dz3oNLWtcHwgXDjU7W8o9DGK46dTCx+M3rSDr16ecAr FIU/ow6tDMf4soZsM63zypQG57YQBTVjuPUuxujdaeDUrsTSSFSX9b3ZfwVTQBOOUdJZRSeSyfL EUICyGHyEB6ZaWyrENTjTNw+CFdDardaiL79Nqb3v4pnSpqLW9BLMT6z7nybbU7DdhuqAtmg4w8 B3UZJcwtVwVQS0MEzXQ== X-Authority-Analysis: v=2.4 cv=QshuG1yd c=1 sm=1 tr=0 ts=6a0dd990 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=KKAkSRfTAAAA:8 a=CJ_M6cvvuiLEDggrW1IA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: c8ni9tDCpr8vUZ8-ZYc3lBsD7zIcUPRA X-Proofpoint-ORIG-GUID: c8ni9tDCpr8vUZ8-ZYc3lBsD7zIcUPRA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 bulkscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605200154 On 5/18/2026 1:03 PM, Neil Armstrong wrote: > On 5/13/26 21:05, Vikash Garodia wrote: >> >> >> On 5/11/2026 2:50 PM, Neil Armstrong wrote: >>> Update the gen2 response and vdec s_fmt code to take in account >>> the P010 and QC010 when calculating the width, height and stride. >>> >>> Signed-off-by: Neil Armstrong >>> --- >>>   .../platform/qcom/iris/iris_hfi_gen2_response.c    | 21 +++++++++++ >>> +++++--- >>>   drivers/media/platform/qcom/iris/iris_vdec.c       | 24 +++++++++++ >>> ++++++++--- >>>   2 files changed, 39 insertions(+), 6 deletions(-) >>> >>> diff --git a/drivers/media/platform/qcom/iris/ >>> iris_hfi_gen2_response.c b/drivers/media/platform/qcom/iris/ >>> iris_hfi_gen2_response.c >>> index 8e19f61bbbf9..0541e02d7507 100644 >>> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c >>> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c >>> @@ -542,9 +542,24 @@ static void >>> iris_hfi_gen2_read_input_subcr_params(struct iris_inst *inst) >>>       pixmp_ip->width = width; >>>       pixmp_ip->height = height; >>> -    pixmp_op->width = ALIGN(width, 128); >>> -    pixmp_op->height = ALIGN(height, 32); >>> -    pixmp_op->plane_fmt[0].bytesperline = ALIGN(width, 128); >>> +    switch (pixmp_op->pixelformat) { >>> +    case V4L2_PIX_FMT_P010: >>> +        pixmp_op->width = ALIGN(width, 128); >>> +        pixmp_op->height = ALIGN(height, 32); >>> +        pixmp_op->plane_fmt[0].bytesperline = ALIGN(width * 2, 256); >>> +        break; >>> +    case V4L2_PIX_FMT_QC10C: >>> +        pixmp_op->width = roundup(width, 192); >>> +        pixmp_op->height = ALIGN(height, 16); >>> +        pixmp_op->plane_fmt[0].bytesperline = ALIGN(pixmp_op->width >>> * 4 / 3, 256); >>> +        break; >>> +    case V4L2_PIX_FMT_NV12: >>> +    case V4L2_PIX_FMT_QC08C: >>> +        pixmp_op->width = ALIGN(width, 128); >>> +        pixmp_op->height = ALIGN(height, 32); >>> +        pixmp_op->plane_fmt[0].bytesperline = pixmp_op->width; >>> +        break; >> >> client facing api, good to have a default here >> >>> +    } >>>       pixmp_op->plane_fmt[0].sizeimage = iris_get_buffer_size(inst, >>> BUF_OUTPUT); >>>       matrix_coeff = subsc_params.color_info & 0xFF; >>> diff --git a/drivers/media/platform/qcom/iris/iris_vdec.c b/drivers/ >>> media/platform/qcom/iris/iris_vdec.c >>> index 99d544e2af4f..eea69f937147 100644 >>> --- a/drivers/media/platform/qcom/iris/iris_vdec.c >>> +++ b/drivers/media/platform/qcom/iris/iris_vdec.c >>> @@ -266,10 +266,28 @@ int iris_vdec_s_fmt(struct iris_inst *inst, >>> struct v4l2_format *f) >>>           fmt = inst->fmt_dst; >>>           fmt->type = V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE; >>>           fmt->fmt.pix_mp.pixelformat = f->fmt.pix_mp.pixelformat; >>> -        fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128); >>> -        fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32); >>>           fmt->fmt.pix_mp.num_planes = 1; >>> -        fmt->fmt.pix_mp.plane_fmt[0].bytesperline = ALIGN(f- >>> >fmt.pix_mp.width, 128); >>> +        switch (f->fmt.pix_mp.pixelformat) { >>> +        case V4L2_PIX_FMT_P010: >>> +            fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128); >>> +            fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32); >>> +            fmt->fmt.pix_mp.plane_fmt[0].bytesperline = >>> +                ALIGN(f->fmt.pix_mp.width * 2, 256); >>> +            break; >>> +        case V4L2_PIX_FMT_QC10C: >>> +            fmt->fmt.pix_mp.width = roundup(f->fmt.pix_mp.width, 192); >> >> ALIGN ? > > ALIGN only works with Power-Of-Two numbers, so we can't use ALIGN here. Ack > >> >>> +            fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 16); >>> +            fmt->fmt.pix_mp.plane_fmt[0].bytesperline = >>> +                ALIGN(f->fmt.pix_mp.width * 4 / 3, 256); >>> +            break; >>> +        case V4L2_PIX_FMT_NV12: >>> +        case V4L2_PIX_FMT_QC08C: >>> +            fmt->fmt.pix_mp.width = ALIGN(f->fmt.pix_mp.width, 128); >>> +            fmt->fmt.pix_mp.height = ALIGN(f->fmt.pix_mp.height, 32); >>> +            fmt->fmt.pix_mp.plane_fmt[0].bytesperline = >>> +                ALIGN(f->fmt.pix_mp.width, 128); >>> +            break; >>> +        } >>>           fmt->fmt.pix_mp.plane_fmt[0].sizeimage = >>> iris_get_buffer_size(inst, BUF_OUTPUT); >>>           inst->buffers[BUF_OUTPUT].min_count = >>> iris_vpu_buf_count(inst, BUF_OUTPUT); >>>           inst->buffers[BUF_OUTPUT].size = fmt- >>> >fmt.pix_mp.plane_fmt[0].sizeimage; >>> >> >