From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Randy Dunlap <rdunlap@infradead.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ludovic Desroches <ludovic.desroches@atmel.com>,
linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: linux-next: Tree for Apr 17 (mmc/host/sdhci-of-at91.c)
Date: Mon, 20 Apr 2020 13:28:21 +0300 [thread overview]
Message-ID: <ce11a0b5-22a6-dd18-f858-5d30f43e1128@intel.com> (raw)
In-Reply-To: <CAPDyKFqE7zfaKSbpBoBbrSCEnx+70dOrWs+=QG_x2G-Fpt6=ng@mail.gmail.com>
On 20/04/20 12:12 pm, Ulf Hansson wrote:
> + Masahiro Yamada, Adrian Hunter
>
> On Fri, 17 Apr 2020 at 16:48, Randy Dunlap <rdunlap@infradead.org> wrote:
>>
>> On 4/16/20 9:50 PM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20200416:
>>>
>>
>> on i386:
>>
>> CC drivers/mmc/host/sdhci-of-at91.o
>> In file included from ../include/linux/build_bug.h:5:0,
>> from ../include/linux/bitfield.h:10,
>> from ../drivers/mmc/host/sdhci-of-at91.c:9:
>> ../drivers/mmc/host/sdhci-of-at91.c: In function ‘sdhci_at91_set_clks_presets’:
>> ../include/linux/compiler.h:394:38: error: call to ‘__compiletime_assert_63’ declared with attribute error: FIELD_PREP: value too large for the field
>> _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>> ^
>> ../include/linux/compiler.h:375:4: note: in definition of macro ‘__compiletime_assert’
>> prefix ## suffix(); \
>> ^~~~~~
>> ../include/linux/compiler.h:394:2: note: in expansion of macro ‘_compiletime_assert’
>> _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>> ^~~~~~~~~~~~~~~~~~~
>> ../include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’
>> #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
>> ^~~~~~~~~~~~~~~~~~
>> ../include/linux/bitfield.h:49:3: note: in expansion of macro ‘BUILD_BUG_ON_MSG’
>> BUILD_BUG_ON_MSG(__builtin_constant_p(_val) ? \
>> ^~~~~~~~~~~~~~~~
>> ../include/linux/bitfield.h:94:3: note: in expansion of macro ‘__BF_FIELD_CHECK’
>> __BF_FIELD_CHECK(_mask, 0ULL, _val, "FIELD_PREP: "); \
>> ^~~~~~~~~~~~~~~~
>> ../drivers/mmc/host/sdhci-of-at91.c:185:11: note: in expansion of macro ‘FIELD_PREP’
>> caps1 |= FIELD_PREP(SDHCI_CLOCK_MUL_MASK, clk_mul);
My guess is the compiler has decided clk_mul is constant (probably (unsigned
int)-1) because there is no CONFIG_COMMON_CLK i.e. clk_get_rate() is 0
So maybe add to config MMC_SDHCI_OF_AT91
depends on COMMON_CLK
>> ^~~~~~~~~~
>>
>>
>> Full randconfig file is attached.
>>
>>
>> --
>> ~Randy
>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>
> Thanks for reporting! I have looped in the relevant people, let's see
> how we move forward with this.
>
> I assume the offending commit is this one:
> Author: Masahiro Yamada <yamada.masahiro@socionext.com>
> Date: Wed Apr 8 16:21:05 2020 +0900
> mmc: sdhci: use FIELD_GET/PREP for capabilities bit masks
>
> Kind regards
> Uffe
>
next prev parent reply other threads:[~2020-04-20 10:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 4:50 linux-next: Tree for Apr 17 Stephen Rothwell
2020-04-17 6:16 ` linux-next: Tree for Apr 17 (pinctrl-mcp23s08) Randy Dunlap
2020-04-17 10:22 ` Linus Walleij
2020-04-17 7:19 ` linux-next: Tree for Apr 17 Christian Borntraeger
2020-04-17 7:27 ` Mauro Carvalho Chehab
2020-04-17 14:48 ` linux-next: Tree for Apr 17 (mmc/host/sdhci-of-at91.c) Randy Dunlap
2020-04-20 9:12 ` Ulf Hansson
2020-04-20 10:28 ` Adrian Hunter [this message]
2020-04-20 12:27 ` Masahiro Yamada
2020-04-20 13:45 ` Adrian Hunter
2020-04-22 10:15 ` Ulf Hansson
2020-04-22 10:54 ` Masahiro Yamada
2020-04-17 15:23 ` linux-next: Tree for Apr 17 (drivers/char/hw_random/cctrng.c) Randy Dunlap
2020-04-17 20:14 ` Hadar Gat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce11a0b5-22a6-dd18-f858-5d30f43e1128@intel.com \
--to=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=ulf.hansson@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®