From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 025ECC433F5 for ; Wed, 13 Oct 2021 09:36:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DCC2460ED4 for ; Wed, 13 Oct 2021 09:36:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239119AbhJMJib (ORCPT ); Wed, 13 Oct 2021 05:38:31 -0400 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:56286 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239166AbhJMJiX (ORCPT ); Wed, 13 Oct 2021 05:38:23 -0400 Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 7496A40015 for ; Wed, 13 Oct 2021 09:36:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1634117779; bh=QJ9OOcKk0SAqcC6odR/kUKnKxAUEab3yB+Cct//JQn0=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=OpbJdOll+aqtFjEFBIERMn3pW8UWSncCDp2cP7B4eMW1U4AfccEyQ5Qep9i4gByRD mt5FdfLIZjS6+pEmlOyAan5wdPszqLN0STSqj32jPU2dXFxT4gi93SDPHpirmewk51 knaT3+uWgdCcgaSRlmw7y5mPcXai2hQM9kOHn+zSL4vReE4RwVr8i0+YH96PUY5rAj QynpaTF2uxKjadiIhpIrt4xKP2uLrAWgUdYWaekedSneZKq406YxmEXRti+3x4txp3 RmMt0+QQ0PpPfGHMUORRlUet9if2XlOFsgm34Id29sduErkhdQTQKOG2bcdZYvIBm1 NgYkG7652URww== Received: by mail-lf1-f69.google.com with SMTP id o5-20020ac24c45000000b003fd932e4642so1531512lfk.14 for ; Wed, 13 Oct 2021 02:36:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=QJ9OOcKk0SAqcC6odR/kUKnKxAUEab3yB+Cct//JQn0=; b=gv3A65h2MiRU2dACTNB5XdOYZGXu5rkVCqdCSmYV1KUGcVtsg6uGKWNc0X2ajo1l9G 7OcIT8yIgD94wh9vCrNZ+c4mUelvYyekDxjsP5dLq4zMaLvn14M7ObMSObPHg8zaTrdJ Hl+hNbtRT8oVB8EcMuLYaSdmVvFTprcj9Bh/Kwz7F+wFQ1QVfHrhMocpR/Ebu0RaTggR vawbFkY2vuzFvPHpdWXbzrw6TozNgaykd6JIjo5TU8FO+5V5ZHeC5xweswO1+LeA2ree 1aU9rR8KpXsuL4M7VkAR++06Um60RqcxSQEmUHv0TwJcBuVzXPb1hZtbt06g9XF6Rc7O t3ZA== X-Gm-Message-State: AOAM533h/bUvjrFkGBYrKqkvMNbM2snC1a/OD/tjtz9MGbG3nz5rIyOi yagKHbKNgCg5VyyCpcrm9/tEbkRuptBlddsQ3y2LlGk7uDl997PStDHQU4HVfpMg2odNUbOUIot yeP1Dqu38hYCny2yovxe0RWPv01NVa6p10IV3Cz8bcA== X-Received: by 2002:a05:6512:3054:: with SMTP id b20mr40337989lfb.316.1634117778611; Wed, 13 Oct 2021 02:36:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhlBGhq00YFwto8tqrsM/9fdr+Ez4zPx7BkVS2CPoWkqy/IentT5VVYEHDNYt3eHr6Up0CGQ== X-Received: by 2002:a05:6512:3054:: with SMTP id b20mr40337972lfb.316.1634117778427; Wed, 13 Oct 2021 02:36:18 -0700 (PDT) Received: from [192.168.0.22] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id t13sm1277182lfc.34.2021.10.13.02.36.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Oct 2021 02:36:17 -0700 (PDT) Subject: Re: [PATCH net 2/2] NFC: digital: fix possible memory leak in digital_in_send_sdd_req() To: Ziyang Xuan Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <56fbe3414c94916d197a1a1b3e438eaa129d5c9f.1634111083.git.william.xuanziyang@huawei.com> From: Krzysztof Kozlowski Message-ID: Date: Wed, 13 Oct 2021 11:36:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <56fbe3414c94916d197a1a1b3e438eaa129d5c9f.1634111083.git.william.xuanziyang@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/10/2021 09:50, Ziyang Xuan wrote: > 'skb' is allocated in digital_in_send_sdd_req(), but not free when > digital_in_send_cmd() failed, which will cause memory leak. Fix it > by freeing 'skb' if digital_in_send_cmd() return failed. > > Fixes: 2c66daecc409 ("NFC Digital: Add NFC-A technology support") > Signed-off-by: Ziyang Xuan > --- > net/nfc/digital_technology.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof