From: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To: Akash Asthana <akashast@codeaurora.org>
Cc: bjorn.andersson@linaro.org, mka@chromium.org,
linux-kernel@vger.kernel.org, saipraka@codeaurora.org,
msavaliy@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH V2] soc: qcom: geni: Fix NULL pointer dereference
Date: Mon, 20 Jul 2020 15:12:19 +0530 [thread overview]
Message-ID: <ce1514ab9b5fbeabcde8ac6a74fd8d81@codeaurora.org> (raw)
In-Reply-To: <1595237762-6776-1-git-send-email-akashast@codeaurora.org>
On 2020-07-20 15:06, Akash Asthana wrote:
> pdev struct doesn't exists for the devices whose status are disabled
> from DT node, in such cases NULL is returned from
> 'of_find_device_by_node'
> Later when we try to get drvdata from pdev struct NULL pointer
> dereference
> is triggered.
>
> Add a NULL check for return values to fix the issue.
>
> We were hitting this issue when one of QUP is disabled.
>
> Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to
> fix earlycon crash")
> Reported-by: Sai Prakash Ranjan <saipraka@codeaurora.org>
> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> Signed-off-by: Akash Asthana <akashast@codeaurora.org>
Nit: my codeaurora mail address is <saiprakash.ranjan@codeaurora.org>.
I don't think you have to resend for this small change, hopefully
maintainers
are ok to fix this when applying.
Reported-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Tested-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
-Sai
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member
of Code Aurora Forum, hosted by The Linux Foundation
prev parent reply other threads:[~2020-07-20 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 9:36 Akash Asthana
2020-07-20 9:42 ` Sai Prakash Ranjan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce1514ab9b5fbeabcde8ac6a74fd8d81@codeaurora.org \
--to=saiprakash.ranjan@codeaurora.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=msavaliy@codeaurora.org \
--cc=saipraka@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome