From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF88A28FFDA for ; Thu, 10 Apr 2025 16:30:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744302636; cv=none; b=SewHjZCqPoLdYq5vuNe6ZQOroUx0Cqk7MAYfKxdtIJ04a608eU2Od/mZmug0XF5yUJVpb7tdGhsTkI2REdaozSmVrwfHHgG7n0BICZB8kbALX4tFDObzsYPyV2rlmQmkaPZozl8XjkhZwQZFmUAb5GUnOXVyzB737WPAn1uZeuc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744302636; c=relaxed/simple; bh=tQZEVPFGd/IhK5JfxVM/1YUszNe7A98ZpZMk51mvK3M=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=bxqSXApS+ka5f82yYN7L+uvJ9/Zd3Vc79YqkkWD4qPaqX37CTKSOI6VXxdjCkz5gME7qQpIfwAg0OIqbkzowyigRN+ZiZssWwWVTphRSqLs2yGytsCs/wHf7q2BatokAKyUF7lho2aMSxImG/D6XcQzLzKu58K7jzLkpjassAHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=W8ky0ZkL; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="W8ky0ZkL" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-39ac9aea656so947925f8f.3 for ; Thu, 10 Apr 2025 09:30:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744302632; x=1744907432; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=ZGXdAXzE75aiHOYRUP+ixvYu9TMT8nEfmus3x76N89w=; b=W8ky0ZkLEFC0IZoP+dYZyyZb09yHBcG4woVCcf5UM0gRQEehlqcXwD5wyijaoo1YbJ VDkE7ui5KWTJsXpJ0fMT6hnsNGgaNE++JOwlmlILxxaAgpfuJhMdlNKrEHz0T4Fj5rIv N7KsCT7QAJZ2lAQ9AWirI4fdQE3Taz0k49iVd/DstGCzwJTduxCfKcLp/31mz35l9rCo hoiLYBOz4uoz5ZS0vxTdtkOU3XLSXKc4BLR2aXckndH4S+6j0VLiYzFUy5LDYUs4zqxb LynoPfupdg3x4EY5najlEXcQG6tx7C0q1aQT9zeB0UXoD26BFzRbxpHNEtDMBYZKjEO6 QOnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744302632; x=1744907432; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZGXdAXzE75aiHOYRUP+ixvYu9TMT8nEfmus3x76N89w=; b=YN5McW0VK2HzSS5I4wiqyQJlsTZ3dIYT3+94vE0RjGR6LuuxbAYyS/XqICIY0xZJ/L ylFzABlD+DKSa/wdqQs2iqHKAj8P/Q1Qf/LWzsO1bEUu49yAGdt4a5ju9XzIXGrbOU4e s7ELq2pf2fuR57X2G/6km5dtSf3f1Hu+vElC3cv5eAJvbNIkEhxrQf91qRYrYtGT8+FP XzV+o37iI0NCqfUdMFhCwgqqnZYVfCNpUx3w1VBtrmdIm3v82Qt18xgtEmD0eTN5dpXo GkFQNhsnKyYuWLwZQlYGayN0eSNISEpVsF6sBzPxHcRe6eBf998sbZ1Olbfb2pOuHohl 2DRg== X-Forwarded-Encrypted: i=1; AJvYcCULN9jTt4lZ0brYNaOSJLgeL99obfDgh0luRttKBtpm0m6+dSmaGK3XuGENf8Q+Ixsnt8LZfFOBi0LxMcI=@vger.kernel.org X-Gm-Message-State: AOJu0YxSjOsAp2JH4M97G6T7ZSKjry76wN1dbvziVkd0KqKPOQSCMFh4 XsMBQIPnJ2NPjymkdUgTngXPbLHW0DC4u1b0d3OlqNgPE/heBmgZyRUm7cch87w= X-Gm-Gg: ASbGncstio+XRookLGqu1k3y1QPDocswOplGAMXltO+OHn38KKPfZZGo+SYtJmL5vJl 3Zu4Vp03ecNcevOKs2JkS7Ng3vFSljXWWSWyZB6USYDsxjhrPPonExKrQ1aBxIdMwxhdR40BM8p ruO2ROSnBjE6gkmIdolUG7G1WZgv3ieTCpsHRk5So/PGKdfounTnzVO9cl4kFbWlwmPDjjlh+gO p0wmv1GjAfeNLkdZagD3SvMIMtiRHCDcg+XWBGv1cncnhHfB9ROCYzXPKuo3sRSVXkJhc15Ykc8 rx33jIv18jvuZG7pO7pRVZRJfLwkaHXRZga53f1Bq4Mr0myiVas0Xxzod3NEs+1RK+7sa4NMjof br/v6flglj7stv+1sjw== X-Google-Smtp-Source: AGHT+IFuikkOqVd4ie/rto6RTVRiUKXX5Ny1yEgJY/2UID0mwhI5huiRL7EVBPUS9cNV555QANcLHQ== X-Received: by 2002:a05:6000:240d:b0:39c:1257:cd40 with SMTP id ffacd0b85a97d-39d8fda74b1mr2765420f8f.58.1744302632176; Thu, 10 Apr 2025 09:30:32 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:1a13:cd5d:5261:ebfe? ([2a01:e0a:3d9:2080:1a13:cd5d:5261:ebfe]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39d8938a4dasm5257351f8f.48.2025.04.10.09.30.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Apr 2025 09:30:31 -0700 (PDT) Message-ID: Date: Thu, 10 Apr 2025 18:30:30 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v4 6/6] media: platform: qcom/iris: add sm8650 support To: Bryan O'Donoghue , Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250409-topic-sm8x50-iris-v10-v4-0-40e411594285@linaro.org> <20250409-topic-sm8x50-iris-v10-v4-6-40e411594285@linaro.org> <36e25d6e-36de-fec6-e54d-0683503c7a09@quicinc.com> <1550c870-188e-4b41-b17c-2009cda41ffc@linaro.org> <8cade183-72ac-eac1-1a57-a9db37657fca@quicinc.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/04/2025 18:06, Bryan O'Donoghue wrote: > On 10/04/2025 16:40, neil.armstrong@linaro.org wrote: >> On 10/04/2025 15:07, Dikshita Agarwal wrote: >>> >>> >>> On 4/10/2025 2:43 PM, Vikash Garodia wrote: >>>> >>>> On 4/10/2025 2:31 PM, Neil Armstrong wrote: >>>>> On 09/04/2025 18:57, Vikash Garodia wrote: >>>>>> Hi Neil, >>>>>> >>>>>> On 4/9/2025 8:08 PM, Neil Armstrong wrote: >>>>>>> Add support for the SM8650 platform by re-using the SM8550 >>>>>>> definitions and using the vpu33 ops. >>>>>>> >>>>>>> The SM8650/vpu33 requires more reset lines, but the H.264 >>>>>>> decoder capabilities are identical. >>>>>>> >>>>>>> Tested-by: Bryan O'Donoghue # x1e Dell >>>>>>> Signed-off-by: Neil Armstrong >>>>>>> --- >>>>>>>    .../platform/qcom/iris/iris_platform_common.h      |  1 + >>>>>>>    .../platform/qcom/iris/iris_platform_sm8550.c      | 64 +++++++ +++++++++++++++ >>>>>>>    drivers/media/platform/qcom/iris/iris_probe.c      |  4 ++ >>>>>>>    3 files changed, 69 insertions(+) >>>>>>> >>>>>>> diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h >>>>>>> b/drivers/media/platform/qcom/iris/iris_platform_common.h >>>>>>> index >>>>>>> fdd40fd80178c4c66b37e392d07a0a62f492f108..6bc3a7975b04d612f6c89206eae95dac678695fc 100644 >>>>>>> --- a/drivers/media/platform/qcom/iris/iris_platform_common.h >>>>>>> +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h >>>>>>> @@ -35,6 +35,7 @@ enum pipe_type { >>>>>>>      extern struct iris_platform_data sm8250_data; >>>>>>>    extern struct iris_platform_data sm8550_data; >>>>>>> +extern struct iris_platform_data sm8650_data; >>>>>>>      enum platform_clk_type { >>>>>>>        IRIS_AXI_CLK, >>>>>>> diff --git a/drivers/media/platform/qcom/iris/iris_platform_sm8550.c >>>>>>> b/drivers/media/platform/qcom/iris/iris_platform_sm8550.c >>>>>>> index >>>>>>> 35d278996c430f2856d0fe59586930061a271c3e..d0f8fa960d53367023e41bc5807ba3f8beae2efc 100644 >>>>>>> --- a/drivers/media/platform/qcom/iris/iris_platform_sm8550.c >>>>>>> +++ b/drivers/media/platform/qcom/iris/iris_platform_sm8550.c >>>>>>> @@ -144,6 +144,10 @@ static const struct icc_info sm8550_icc_table[] = { >>>>>>>      static const char * const sm8550_clk_reset_table[] = { "bus" }; >>>>>>>    +static const char * const sm8650_clk_reset_table[] = { "bus", "core" }; >>>>>>> + >>>>>>> +static const char * const sm8650_controller_reset_table[] = { "xo" }; >>>>>>> + >>>>>>>    static const struct bw_info sm8550_bw_table_dec[] = { >>>>>>>        { ((4096 * 2160) / 256) * 60, 1608000 }, >>>>>>>        { ((4096 * 2160) / 256) * 30,  826000 }, >>>>>>> @@ -264,3 +268,63 @@ struct iris_platform_data sm8550_data = { >>>>>>>        .dec_op_int_buf_tbl = sm8550_dec_op_int_buf_tbl, >>>>>>>        .dec_op_int_buf_tbl_size = ARRAY_SIZE(sm8550_dec_op_int_buf_tbl), >>>>>>>    }; >>>>>>> + >>>>>>> +/* >>>>>>> + * Shares most of SM8550 data except: >>>>>>> + * - vpu_ops to iris_vpu33_ops >>>>>>> + * - clk_rst_tbl to sm8650_clk_reset_table >>>>>>> + * - controller_rst_tbl to sm8650_controller_reset_table >>>>>>> + * - fwname to "qcom/vpu/vpu33_p4.mbn" >>>>>>> + */ >>>>>>> +struct iris_platform_data sm8650_data = { >>>>>>> +    .get_instance = iris_hfi_gen2_get_instance, >>>>>>> +    .init_hfi_command_ops = iris_hfi_gen2_command_ops_init, >>>>>>> +    .init_hfi_response_ops = iris_hfi_gen2_response_ops_init, >>>>>>> +    .vpu_ops = &iris_vpu33_ops, >>>>>>> +    .set_preset_registers = iris_set_sm8550_preset_registers, >>>>>>> +    .icc_tbl = sm8550_icc_table, >>>>>>> +    .icc_tbl_size = ARRAY_SIZE(sm8550_icc_table), >>>>>>> +    .clk_rst_tbl = sm8650_clk_reset_table, >>>>>>> +    .clk_rst_tbl_size = ARRAY_SIZE(sm8650_clk_reset_table), >>>>>>> +    .controller_rst_tbl = sm8650_controller_reset_table, >>>>>>> +    .controller_rst_tbl_size = ARRAY_SIZE(sm8650_controller_reset_table), >>>>>>> +    .bw_tbl_dec = sm8550_bw_table_dec, >>>>>>> +    .bw_tbl_dec_size = ARRAY_SIZE(sm8550_bw_table_dec), >>>>>>> +    .pmdomain_tbl = sm8550_pmdomain_table, >>>>>>> +    .pmdomain_tbl_size = ARRAY_SIZE(sm8550_pmdomain_table), >>>>>>> +    .opp_pd_tbl = sm8550_opp_pd_table, >>>>>>> +    .opp_pd_tbl_size = ARRAY_SIZE(sm8550_opp_pd_table), >>>>>>> +    .clk_tbl = sm8550_clk_table, >>>>>>> +    .clk_tbl_size = ARRAY_SIZE(sm8550_clk_table), >>>>>>> +    /* Upper bound of DMA address range */ >>>>>>> +    .dma_mask = 0xe0000000 - 1, >>>>>>> +    .fwname = "qcom/vpu/vpu33_p4.mbn", >>>>>>> +    .pas_id = IRIS_PAS_ID, >>>>>>> +    .inst_caps = &platform_inst_cap_sm8550, >>>>>>> +    .inst_fw_caps = inst_fw_cap_sm8550, >>>>>>> +    .inst_fw_caps_size = ARRAY_SIZE(inst_fw_cap_sm8550), >>>>>>> +    .tz_cp_config_data = &tz_cp_config_sm8550, >>>>>>> +    .core_arch = VIDEO_ARCH_LX, >>>>>>> +    .hw_response_timeout = HW_RESPONSE_TIMEOUT_VALUE, >>>>>>> +    .ubwc_config = &ubwc_config_sm8550, >>>>>>> +    .num_vpp_pipe = 4, >>>>>>> +    .max_session_count = 16, >>>>>>> +    .max_core_mbpf = ((8192 * 4352) / 256) * 2, >>>>>>> +    .input_config_params = >>>>>>> +        sm8550_vdec_input_config_params, >>>>>>> +    .input_config_params_size = >>>>>>> +        ARRAY_SIZE(sm8550_vdec_input_config_params), >>>>>>> +    .output_config_params = >>>>>>> +        sm8550_vdec_output_config_params, >>>>>>> +    .output_config_params_size = >>>>>>> +        ARRAY_SIZE(sm8550_vdec_output_config_params), >>>>>>> +    .dec_input_prop = sm8550_vdec_subscribe_input_properties, >>>>>>> +    .dec_input_prop_size = ARRAY_SIZE(sm8550_vdec_subscribe_input_properties), >>>>>>> +    .dec_output_prop = sm8550_vdec_subscribe_output_properties, >>>>>>> +    .dec_output_prop_size = >>>>>>> ARRAY_SIZE(sm8550_vdec_subscribe_output_properties), >>>>>>> + >>>>>>> +    .dec_ip_int_buf_tbl = sm8550_dec_ip_int_buf_tbl, >>>>>>> +    .dec_ip_int_buf_tbl_size = ARRAY_SIZE(sm8550_dec_ip_int_buf_tbl), >>>>>>> +    .dec_op_int_buf_tbl = sm8550_dec_op_int_buf_tbl, >>>>>>> +    .dec_op_int_buf_tbl_size = ARRAY_SIZE(sm8550_dec_op_int_buf_tbl), >>>>>>> +}; >>>>>> While i was extending the data for QCS8300 (one another iris-v3 variant), i >>>>>> realize that this file iris_platform_sm8550.c is getting dumped with all SOC >>>>>> platform data. It would be a good idea at this point to split it into something >>>>>> like this >>>>>> 1. Introduce SOC specific c file and move the respective SOC platform data to >>>>>> it, for ex, in this case sm8650_data >>>>>> 2. Move the common structs from iris_platform_sm8550.c to >>>>>> iris_platform_common.h. This way more SOCs getting added in future, can include >>>>>> the common header to reuse them, otherwise it would end up using 8550.c for all >>>>>> future SOC. >>>>>> >>>>>> Share your comments if you have any better approach to manage/re- use these >>>>>> platform data considering more SOCs getting added. >>>>> >>>>> Right, yes the architecture is fine, but I don't feel iris_platform_common is >>>>> the right >>>>> place, perhaps we could introduce a platform_catalog.c where we could place all >>>>> the common >>>>> platform data and reuse them from the platform_.c files ? >>>> Common structs would certainly need to be part of a header which can be >>>> included. Where do you plan to keep common struct to be used across SOC specific >>>> file in your approach ? >>>>> >>>>> I can design prototype on top of this patchset as an RFC. >>>> I was thinking that the changes are not that big, and can be done in existing >>>> series though. >>>> >>> For now, I think you can introduce a platform_sm8650.c as part of this >>> series and use the common structure from platform_sm8550.c. >>> Shouldn't be a big change. >> >> I tried but I don't how to solve this, you need a build-time ARRAY_SIZE for >> the arrays, so they need to be in the same .c file to allow a build-time >> evaluation of ARRAY_SIZE. If he common tables are moved into a header >> they will be duplicated into both platform_sm8650 & platform_sm8550 objects >> which is not what we want. >> >> The solution would be to write all the platform tables & iris_platform_data >> into headers, with common headers, then include those into a platform_catalog.c >> like is done for the drm/msm/dpu1 catalog. >> >> Neil >> >>> >>> Later you can post a separate patch series to add platform_catalog.c and >>> have common struct placed there which can be used across different SOC >>> platform files. >>> >>> or other way is, >>> Post a patch series to introduce platform_catalog.c with common struct and >>> then rebase your 8650 series on top of it. >>> >>> Thanks, >>> Dikshita >>>> Thanks, >>>> Vikash >>>>> >>>>> Neil >>>>> >>>>>> >>>>>> Regards, >>>>>> Vikash >>>>>> >>>>>>> diff --git a/drivers/media/platform/qcom/iris/iris_probe.c >>>>>>> b/drivers/media/platform/qcom/iris/iris_probe.c >>>>>>> index >>>>>>> 4f8bce6e2002bffee4c93dcaaf6e52bf4e40992e..7cd8650fbe9c09598670530103e3d5edf32953e7 100644 >>>>>>> --- a/drivers/media/platform/qcom/iris/iris_probe.c >>>>>>> +++ b/drivers/media/platform/qcom/iris/iris_probe.c >>>>>>> @@ -345,6 +345,10 @@ static const struct of_device_id iris_dt_match[] = { >>>>>>>                .data = &sm8250_data, >>>>>>>            }, >>>>>>>    #endif >>>>>>> +    { >>>>>>> +        .compatible = "qcom,sm8650-iris", >>>>>>> +        .data = &sm8650_data, >>>>>>> +    }, >>>>>>>        { }, >>>>>>>    }; >>>>>>>    MODULE_DEVICE_TABLE(of, iris_dt_match); >>>>>>> >>>>> >> > > Eh as I read the suggestion about putting the structs - instantiating the structs in the header, I wondered if that would link but anyway. > > One way to solve this without going the dpu1 route right now is to rename the platform files > > iris_platform_sm8250.c -> iris_platform_common_hfi_gen1.c > iris_platform_sm8550.c -> iris_platform_common_hfi_gen2.c > > The differentiation around HFI into "generations" instead of incrementing the already existing HFIXXX version is unfortunate. > > At least this way we have a repository of common HFI code located in each file, in expectation of HFI GEN3 whenever. Yeah I somehow did something like that, please review: https://lore.kernel.org/all/20250410-topic-sm8x50-upstream-iris-catalog-v5-0-44a431574c25@linaro.org/ Neil > > --- > bod