mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Lukasz Luba <l.luba@partner.samsung.com>
To: linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	"rjw@rjwysocki.net" <rjw@rjwysocki.net>
Cc: tjakobi@math.uni-bielefeld.de, myungjoo.ham@samsung.com,
	kyungmin.park@samsung.com, cw00.choi@samsung.com,
	rjw@rjwysocki.net, len.brown@intel.com, pavel@ucw.cz,
	gregkh@linuxfoundation.org, keescook@chromium.org,
	anton@enomsg.org, ccross@android.com, tony.luck@intel.com,
	robh+dt@kernel.org, mark.rutland@arm.com, kgene@kernel.org,
	krzk@kernel.org, m.szyprowski@samsung.com,
	b.zolnierkie@samsung.com
Subject: Re: [PATCH v3 4/5] drivers: power: suspend: call devfreq suspend/resume
Date: Thu, 13 Dec 2018 15:35:25 +0100	[thread overview]
Message-ID: <ce1d415d-2a00-ef0e-6b58-23d16cffee4a@partner.samsung.com> (raw)
In-Reply-To: <1544007956-28889-5-git-send-email-l.luba@partner.samsung.com>

Hi Rafael,

I see that you have pulled 3 patches.
Please take also this patch, which is actually enabling the feature.

Regards,
Lukasz

On 12/5/18 12:05 PM, Lukasz Luba wrote:
> Devfreq framework supports suspend of its devices.
> Call the the devfreq interface and allow devfreq devices preserve/restore
> their states during suspend/resume.
> 
> Suggested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
> ---
>   drivers/base/power/main.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
> index a690fd4..0992e67 100644
> --- a/drivers/base/power/main.c
> +++ b/drivers/base/power/main.c
> @@ -32,6 +32,7 @@
>   #include <trace/events/power.h>
>   #include <linux/cpufreq.h>
>   #include <linux/cpuidle.h>
> +#include <linux/devfreq.h>
>   #include <linux/timer.h>
>   
>   #include "../base.h"
> @@ -1078,6 +1079,7 @@ void dpm_resume(pm_message_t state)
>   	dpm_show_time(starttime, state, 0, NULL);
>   
>   	cpufreq_resume();
> +	devfreq_resume();
>   	trace_suspend_resume(TPS("dpm_resume"), state.event, false);
>   }
>   
> @@ -1852,6 +1854,7 @@ int dpm_suspend(pm_message_t state)
>   	trace_suspend_resume(TPS("dpm_suspend"), state.event, true);
>   	might_sleep();
>   
> +	devfreq_suspend();
>   	cpufreq_suspend();
>   
>   	mutex_lock(&dpm_list_mtx);
> 

  reply	other threads:[~2018-12-13 14:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20181205110616eucas1p1e0e17b0c6a96c3b6d77516d4b02de8b1@eucas1p1.samsung.com>
2018-12-05 11:05 ` [PATCH v3 0/5] devfreq: handle suspend/resume Lukasz Luba
     [not found]   ` <CGME20181205110619eucas1p2eb8553c60b4e23b07c76f02b3867827c@eucas1p2.samsung.com>
2018-12-05 11:05     ` [PATCH v3 1/5] devfreq: refactor set_target frequency function Lukasz Luba
     [not found]   ` <CGME20181205110620eucas1p14de70dc092580b684a0304b5ce771605@eucas1p1.samsung.com>
2018-12-05 11:05     ` [PATCH v3 2/5] devfreq: add support for suspend/resume of a devfreq device Lukasz Luba
2018-12-06  1:17       ` Chanwoo Choi
2018-12-06 10:13         ` Lukasz Luba
     [not found]       ` <CGME20181205110620eucas1p14de70dc092580b684a0304b5ce771605@epcms1p1>
2018-12-11  1:43         ` MyungJoo Ham
2018-12-11  8:26           ` Lukasz Luba
     [not found]   ` <CGME20181205110622eucas1p23d788afd54ad34c0a2663efac8734648@eucas1p2.samsung.com>
2018-12-05 11:05     ` [PATCH v3 3/5] devfreq: add devfreq_suspend/resume() functions Lukasz Luba
2018-12-06  1:30       ` Chanwoo Choi
     [not found]       ` <CGME20181205110622eucas1p23d788afd54ad34c0a2663efac8734648@epcms1p3>
2018-12-11  2:45         ` MyungJoo Ham
     [not found]   ` <CGME20181205110623eucas1p120f9d8b38822bf856a5b7d427d00e49f@eucas1p1.samsung.com>
2018-12-05 11:05     ` [PATCH v3 4/5] drivers: power: suspend: call devfreq suspend/resume Lukasz Luba
2018-12-13 14:35       ` Lukasz Luba [this message]
     [not found]       ` <CGME20181205110623eucas1p120f9d8b38822bf856a5b7d427d00e49f@epcms1p7>
2018-12-21  0:33         ` MyungJoo Ham
2019-01-02 15:08           ` Lukasz Luba
2019-01-03 10:08             ` Rafael J. Wysocki
     [not found]   ` <CGME20181205110625eucas1p10c7b3137fb77ae51a211c4f040c4eb6f@eucas1p1.samsung.com>
2018-12-05 11:05     ` [PATCH v3 5/5] arm: dts: exynos4: opp-suspend in DMC and leftbus Lukasz Luba
2018-12-05 11:12       ` Krzysztof Kozlowski
2018-12-05 11:45         ` Lukasz Luba
     [not found]   ` <CGME20181205110619eucas1p2eb8553c60b4e23b07c76f02b3867827c@epcms1p7>
2018-12-11  2:08     ` [PATCH v3 1/5] devfreq: refactor set_target frequency function MyungJoo Ham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce1d415d-2a00-ef0e-6b58-23d16cffee4a@partner.samsung.com \
    --to=l.luba@partner.samsung.com \
    --cc=anton@enomsg.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=ccross@android.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=keescook@chromium.org \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=len.brown@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mark.rutland@arm.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=pavel@ucw.cz \
    --cc=rjw@rjwysocki.net \
    --cc=robh+dt@kernel.org \
    --cc=tjakobi@math.uni-bielefeld.de \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®