From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Dave Hansen <dave.hansen@intel.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com, corbet@lwn.net,
jgross@suse.com, andrew.cooper3@citrix.com, peterz@infradead.org,
Jason@zx2c4.com, thomas.lendacky@amd.com, puwen@hygon.cn,
x86@kernel.org, linux-doc@vger.kernel.org,
oleksandr@natalenko.name
Subject: Re: [PATCH v2.1 2/2] x86/Documentation: Add documentation about cluster
Date: Tue, 18 Apr 2023 09:19:44 +0700 [thread overview]
Message-ID: <ce1dcea0-748a-878c-cb2b-3730690004a4@gmail.com> (raw)
In-Reply-To: <7b068fc1-2d88-27c3-b561-0a6c36c589da@intel.com>
On 4/17/23 07:23, Dave Hansen wrote:
> On 4/14/23 19:24, Bagas Sanjaya wrote:
>> On 4/14/23 10:17, K Prateek Nayak wrote:
>>> + - cluster_id:
>>> +
>>> + A per-CPU variable containing:
>>> +
>>> + - Upper bits extracted from the APIC ID. CPUs which have the same value
>>> + in these bits share an L2 and have the same cluster_id.
>>> +
>>> + CPUs for which cluster information is unavailable will show 65535
>>> + (BAD_APICID) as the cluster_id.
>> "... return cluster_id of 65535 (BAD_APICID)."
>
> Bagas, this is talking about a per-cpu variable. Variables don't
> "return" things, functions do.
>
Oops, I don't see that!
> I also have a request: I'd really appreciate if you could avoid
> reviewing x86-related documentation. The review comments that I've seen
> coming from you have not helped x86 documentation. They've hurt the
> patches more than they have helped.
>
OK, thanks!
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2023-04-18 2:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 17:29 [PATCH v2 0/2] arch/x86: Set L2 Cache ID on AMD and Hygon processors K Prateek Nayak
2023-04-13 17:29 ` [PATCH v2 1/2] " K Prateek Nayak
2023-04-13 17:29 ` [PATCH v2 2/2] x86/Documentation: Add documentation about cluster K Prateek Nayak
2023-04-13 17:57 ` Dave Hansen
2023-04-14 2:37 ` K Prateek Nayak
2023-04-14 3:17 ` [PATCH v2.1 " K Prateek Nayak
2023-04-15 2:24 ` Bagas Sanjaya
2023-04-17 0:23 ` Dave Hansen
2023-04-18 2:19 ` Bagas Sanjaya [this message]
2023-05-18 2:27 ` [PATCH v2 0/2] arch/x86: Set L2 Cache ID on AMD and Hygon processors K Prateek Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce1dcea0-748a-878c-cb2b-3730690004a4@gmail.com \
--to=bagasdotme@gmail.com \
--cc=Jason@zx2c4.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleksandr@natalenko.name \
--cc=peterz@infradead.org \
--cc=puwen@hygon.cn \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®